From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079D3C43461 for ; Wed, 16 Sep 2020 19:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98A5F20809 for ; Wed, 16 Sep 2020 19:21:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nFj128Hp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727749AbgIPTVY (ORCPT ); Wed, 16 Sep 2020 15:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727338AbgIPTTa (ORCPT ); Wed, 16 Sep 2020 15:19:30 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2C86C061352 for ; Wed, 16 Sep 2020 12:17:48 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id t14so4440970pgl.10 for ; Wed, 16 Sep 2020 12:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0uNOvGB6rUb/6Wge2+zVi2CVioKcm2kY4sTfTs2ztTc=; b=nFj128Hpt/ngFdgL72D8VO/D730YM7ANn/edQINa2cXvgEwmgYFnSZMkXaJVuCe59Z r+feZtf+0MAPDm46d2xzx5bnRsHNumFHEH5RQFKfdM+Cin0R89gxg0cUqQt5J9CmoJB4 mot0FWrSiCH4Cdke16zQylNGIMUj7BliwwyqwyYClSKGlcBQlQGWUgP0SG/1m5HWOMAe eCQCFRaGaAjZTzhLSgma2Qn0i9h7xbWO9121lYc6dcJ9lmCdPMw0bfW11TfXnrhC3Mls 60NT9PgtUgFbDFe63GmNVWmXSDPq6ef2MSaHO/IftMTYLk3nMRbs/IBZJHtqFE3iGJw+ /QAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0uNOvGB6rUb/6Wge2+zVi2CVioKcm2kY4sTfTs2ztTc=; b=WPBALr3HXVmPT8bDn9zinLj0kjMBftuliS2wtybYGfkFQZt97mcJkk68D8s21n7Bgs glVNpoFYo76MFuJ/FjCVWEgSL8LVoWhx+kkLs9XUon6bHeIiFjsEhefSdBSp7p16UaS4 0HAVJK6go/BzEoHYO0AQJJSIChKz0pFgTeFizbt1yX+vefGljfOC/V9KIAodwH0vktq9 y0PgxL2fVzk1d1m9qes2549gOLedneqtUl5caC+UHRPo295v1gFBvZySagatWvAh78Wd 5nnwpT8mCP7Fcv2KYXIzSzW07mguEThJcknLsJaUAL8hhUq9G3kjh3mDCdivscZ/9/IB lSNg== X-Gm-Message-State: AOAM532vEWyH60UBhua/abcEq6HWFdHYjU5sotWbILX5YyEfJdX9cTKb efCLCiAuF8G761trTcofBWZqqQ== X-Google-Smtp-Source: ABdhPJx0MiHiiGTPhNQdOx875EloCFk/Qn3vdbGOL8WQgxcaBGrvx0ggnF6mqJ8WhqZweIupkKPE+Q== X-Received: by 2002:a62:503:0:b029:13e:d13d:a0f9 with SMTP id 3-20020a6205030000b029013ed13da0f9mr23556330pff.21.1600283868487; Wed, 16 Sep 2020 12:17:48 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id b2sm11373688pfp.3.2020.09.16.12.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 12:17:48 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/16] coresight: etm4x: Fix issues within reset interface of sysfs Date: Wed, 16 Sep 2020 13:17:29 -0600 Message-Id: <20200916191737.4001561-9-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916191737.4001561-1-mathieu.poirier@linaro.org> References: <20200916191737.4001561-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Zhou The member @nr_addr_cmp is not a bool value, using operator '>' instead to avoid unexpected failure. Cc: Mathieu Poirier Cc: Suzuki K Poulose Cc: Mike Leach Cc: Shaokun Zhang Cc: lizixian@hisilicon.com Fixes: a77de2637c9e ("coresight: etm4x: moving sysFS entries to a dedicated file") Signed-off-by: Jonathan Zhou Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c index b673e738bc9a..a588cd6de01c 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c @@ -206,7 +206,7 @@ static ssize_t reset_store(struct device *dev, * each trace run. */ config->vinst_ctrl = BIT(0); - if (drvdata->nr_addr_cmp == true) { + if (drvdata->nr_addr_cmp > 0) { config->mode |= ETM_MODE_VIEWINST_STARTSTOP; /* SSSTATUS, bit[9] */ config->vinst_ctrl |= BIT(9); -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AE31C433E2 for ; Wed, 16 Sep 2020 19:20:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D000206B5 for ; Wed, 16 Sep 2020 19:20:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DhyUHcVc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nFj128Hp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D000206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wSO6zvf0kHJA4jqFCHNkZoOHAfgb5N3qQQFLY4naPN8=; b=DhyUHcVcAvpQx30sB2VIFeccZ ih4tMGKMsFUr9QOMHsoHt8tmMUOTRcdXvI+wDGgatdAA8VFfn727jfOTnTgzWzlj7UwRSOn4U0k0p iz3kq7xl33h1he9lyEEaKBukXxgcTh4gDyIuVc7hHK1Xd4BekAgOhd9YorBcxeURuN9WjZdgrVrYn ezyyESTKicO9PLZRg3EluE4m2/DsumLayHOrObuEuDGh1zTC5QTPOzL0G3C6tp3+vusdxGChnLkTt A+h0LsAqj5l+CyniFNGw+yShoUhi++gLSmyjDDEiKpmu87aRX8WWP608mClFXVQdsmuaFkCkswlTW WIcspIt7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIcwt-0005MB-KI; Wed, 16 Sep 2020 19:18:35 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIcwA-00057x-Iv for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 19:17:51 +0000 Received: by mail-pf1-x441.google.com with SMTP id b124so4515511pfg.13 for ; Wed, 16 Sep 2020 12:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0uNOvGB6rUb/6Wge2+zVi2CVioKcm2kY4sTfTs2ztTc=; b=nFj128Hpt/ngFdgL72D8VO/D730YM7ANn/edQINa2cXvgEwmgYFnSZMkXaJVuCe59Z r+feZtf+0MAPDm46d2xzx5bnRsHNumFHEH5RQFKfdM+Cin0R89gxg0cUqQt5J9CmoJB4 mot0FWrSiCH4Cdke16zQylNGIMUj7BliwwyqwyYClSKGlcBQlQGWUgP0SG/1m5HWOMAe eCQCFRaGaAjZTzhLSgma2Qn0i9h7xbWO9121lYc6dcJ9lmCdPMw0bfW11TfXnrhC3Mls 60NT9PgtUgFbDFe63GmNVWmXSDPq6ef2MSaHO/IftMTYLk3nMRbs/IBZJHtqFE3iGJw+ /QAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0uNOvGB6rUb/6Wge2+zVi2CVioKcm2kY4sTfTs2ztTc=; b=tblza+fBNPuaUFAaGzBQk8VN0Da/6I98WUm29ETU7DuH9I9fg2YADheW/Hk2BseLFk /mqksGHpS+I5ZF8SAKd6RTtORzRlYDY9vrtsE1jAxV1nYkV2NFe29G5vfq59qrsd6Px6 diOC1U+fFTZ106Iitr3hJ1WEAMQwSdoLxF4sKY9onatNWHngvkFcgruoYdTd1Hlk1ER2 zY8zIcT7zyn5Ij2x1N99rmFR/hNcUX6LyAV5SimYAFWJoNeOeAZLiR8Ic4YAeY+z6DAv yaJ6Nvd4rmFm6DcKr5V29If+SL1bG5RxNODkU4zYyZd67E9IJT34toBr3cotuNQ2E7DS 8Z2Q== X-Gm-Message-State: AOAM531i88VCclLQUUfDVf664CtT4sL8/AQABvSpwf98p238xHqLRxyb a/1G/ah+P/L045lRsyxxmFDD5g== X-Google-Smtp-Source: ABdhPJx0MiHiiGTPhNQdOx875EloCFk/Qn3vdbGOL8WQgxcaBGrvx0ggnF6mqJ8WhqZweIupkKPE+Q== X-Received: by 2002:a62:503:0:b029:13e:d13d:a0f9 with SMTP id 3-20020a6205030000b029013ed13da0f9mr23556330pff.21.1600283868487; Wed, 16 Sep 2020 12:17:48 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id b2sm11373688pfp.3.2020.09.16.12.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 12:17:48 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 08/16] coresight: etm4x: Fix issues within reset interface of sysfs Date: Wed, 16 Sep 2020 13:17:29 -0600 Message-Id: <20200916191737.4001561-9-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200916191737.4001561-1-mathieu.poirier@linaro.org> References: <20200916191737.4001561-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_151750_662483_B3ACE750 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Jonathan Zhou The member @nr_addr_cmp is not a bool value, using operator '>' instead to avoid unexpected failure. Cc: Mathieu Poirier Cc: Suzuki K Poulose Cc: Mike Leach Cc: Shaokun Zhang Cc: lizixian@hisilicon.com Fixes: a77de2637c9e ("coresight: etm4x: moving sysFS entries to a dedicated file") Signed-off-by: Jonathan Zhou Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm4x-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c index b673e738bc9a..a588cd6de01c 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-sysfs.c @@ -206,7 +206,7 @@ static ssize_t reset_store(struct device *dev, * each trace run. */ config->vinst_ctrl = BIT(0); - if (drvdata->nr_addr_cmp == true) { + if (drvdata->nr_addr_cmp > 0) { config->mode |= ETM_MODE_VIEWINST_STARTSTOP; /* SSSTATUS, bit[9] */ config->vinst_ctrl |= BIT(9); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel