[PATCH V3 00/10] fix some comment spelling errors

[PATCH V3 00/10] fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors, this series fixed this
spelling errors.

v2 -> v3:
  fix coding style problems in v2 version

v1 -> v2:
  address Peter Maydell's comments
  address Alex Bennee's comments
  add reviewed-by for patch 1,2,3,4,5,6,9,10

zhaolichang (10):
  qemu/: fix some comment spelling errors
  migration/: fix some comment spelling errors
  docs/: fix some comment spelling errors
  scripts/: fix some comment spelling errors
  util/: fix some comment spelling errors
  linux-user/: fix some comment spelling errors
  block/: fix some comment spelling errors
  disas/: fix some comment spelling errors
  qapi/: fix some comment spelling errors
  contrib/: fix some comment spelling errors

 Changelog                                |  2 +-
 accel/tcg/user-exec.c                    |  2 +-
 audio/audio.c                            |  2 +-
 block.c                                  |  2 +-
 block/block-copy.c                       |  2 +-
 block/linux-aio.c                        |  2 +-
 block/mirror.c                           |  2 +-
 block/vhdx.c                             |  2 +-
 block/vhdx.h                             |  4 ++--
 configure                                |  2 +-
 contrib/gitdm/filetypes.txt              |  6 +++---
 contrib/ivshmem-client/ivshmem-client.h  |  2 +-
 contrib/libvhost-user/libvhost-user.c    |  4 ++--
 contrib/libvhost-user/libvhost-user.h    |  2 +-
 disas/hppa.c                             |  2 +-
 disas/m68k.c                             |  8 ++++----
 disas/ppc.c                              |  2 +-
 docs/COLO-FT.txt                         |  6 +++---
 docs/devel/blkdebug.txt                  |  2 +-
 docs/devel/migration.rst                 |  2 +-
 docs/devel/testing.rst                   |  2 +-
 docs/devel/tracing.txt                   |  2 +-
 docs/interop/bitmaps.rst                 |  2 +-
 docs/interop/dbus.rst                    |  4 ++--
 docs/interop/nbd.txt                     |  2 +-
 docs/interop/vhost-user-gpu.rst          |  2 +-
 docs/interop/vhost-user.rst              |  4 ++--
 docs/rdma.txt                            |  2 +-
 docs/specs/ppc-spapr-hotplug.txt         |  4 ++--
 docs/specs/ppc-spapr-xive.rst            |  4 ++--
 docs/system/arm/aspeed.rst               |  2 +-
 docs/system/deprecated.rst               |  8 ++++----
 docs/system/target-avr.rst               |  4 ++--
 docs/tools/virtiofsd.rst                 |  2 +-
 fsdev/virtfs-proxy-helper.c              |  2 +-
 hmp-commands.hx                          |  2 +-
 libdecnumber/decNumber.c                 |  2 +-
 linux-user/aarch64/signal.c              |  2 +-
 linux-user/cris/target_syscall.h         |  4 ++--
 linux-user/flat.h                        |  2 +-
 linux-user/flatload.c                    |  4 ++--
 linux-user/host/ppc64/safe-syscall.inc.S |  2 +-
 linux-user/syscall.c                     |  4 ++--
 migration/colo-failover.c                |  2 +-
 migration/colo.c                         |  2 +-
 migration/multifd.c                      |  4 ++--
 migration/postcopy-ram.c                 |  4 ++--
 migration/postcopy-ram.h                 |  2 +-
 migration/ram.c                          | 10 +++++-----
 migration/rdma.c                         |  8 ++++----
 migration/savevm.c                       |  4 ++--
 qapi/block-core.json                     |  4 ++--
 qapi/crypto.json                         |  4 ++--
 qemu-img.c                               |  2 +-
 qobject/qdict.c                          |  2 +-
 scripts/checkpatch.pl                    |  2 +-
 scripts/clean-header-guards.pl           |  2 +-
 scripts/decodetree.py                    |  6 +++---
 scripts/oss-fuzz/build.sh                |  2 +-
 scripts/tracetool/__init__.py            |  2 +-
 scsi/pr-manager-helper.c                 |  2 +-
 util/osdep.c                             |  2 +-
 util/qemu-progress.c                     |  2 +-
 util/qemu-sockets.c                      |  2 +-
 util/qemu-thread-win32.c                 |  2 +-
 util/qht.c                               |  2 +-
 util/trace-events                        |  2 +-
 67 files changed, 101 insertions(+), 101 deletions(-)

-- 
2.26.2.windows.1

[PATCH V3 01/10] qemu/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
---
 Changelog                   | 2 +-
 accel/tcg/user-exec.c       | 2 +-
 audio/audio.c               | 2 +-
 block.c                     | 2 +-
 configure                   | 2 +-
 fsdev/virtfs-proxy-helper.c | 2 +-
 hmp-commands.hx             | 2 +-
 libdecnumber/decNumber.c    | 2 +-
 qemu-img.c                  | 2 +-
 qobject/qdict.c             | 2 +-
 scsi/pr-manager-helper.c    | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/Changelog b/Changelog
index 4a90bb9e8b..f7e178ccc0 100644
--- a/Changelog
+++ b/Changelog
@@ -241,7 +241,7 @@ version 0.8.0:
 version 0.7.2:
 
   - x86_64 fixes (Win2000 and Linux 2.6 boot in 32 bit)
-  - merge self modifying code handling in dirty ram page mecanism.
+  - merge self modifying code handling in dirty ram page mechanism.
   - MIPS fixes (Ralf Baechle)
   - better user net performances
 
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index bb039eb32d..5c96819ded 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -88,7 +88,7 @@ static inline int handle_cpu_signal(uintptr_t pc, siginfo_t *info,
          * use that value directly.  Within cpu_restore_state_from_tb, we
          * assume PC comes from GETPC(), as used by the helper functions,
          * so we adjust the address by -GETPC_ADJ to form an address that
-         * is within the call insn, so that the address does not accidentially
+         * is within the call insn, so that the address does not accidentally
          * match the beginning of the next guest insn.  However, when the
          * pc comes from the signal frame it points to the actual faulting
          * host memory insn and not the return from a call insn.
diff --git a/audio/audio.c b/audio/audio.c
index ce8c6dec5f..1a68cfaafb 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1674,7 +1674,7 @@ static AudioState *audio_init(Audiodev *dev, const char *name)
         head = audio_handle_legacy_opts();
         /*
          * In case of legacy initialization, all Audiodevs in the list will have
-         * the same configuration (except the driver), so it does't matter which
+         * the same configuration (except the driver), so it doesn't matter which
          * one we chose.  We need an Audiodev to set up AudioState before we can
          * init a driver.  Also note that dev at this point is still in the
          * list.
diff --git a/block.c b/block.c
index 9538af4884..11ab55f80b 100644
--- a/block.c
+++ b/block.c
@@ -2602,7 +2602,7 @@ static void bdrv_replace_child_noperm(BdrvChild *child,
 
 /*
  * Updates @child to change its reference to point to @new_bs, including
- * checking and applying the necessary permisson updates both to the old node
+ * checking and applying the necessary permission updates both to the old node
  * and to @new_bs.
  *
  * NULL is passed as @new_bs for removing the reference before freeing @child.
diff --git a/configure b/configure
index ce27eafb0a..c74d79bfbc 100755
--- a/configure
+++ b/configure
@@ -3411,7 +3411,7 @@ EOF
     xfs="yes"
   else
     if test "$xfs" = "yes" ; then
-      feature_not_found "xfs" "Instal xfsprogs/xfslibs devel"
+      feature_not_found "xfs" "Install xfsprogs/xfslibs devel"
     fi
     xfs=no
   fi
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index de061a8a0e..15c0e79b06 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -518,7 +518,7 @@ static void statfs_to_prstatfs(ProxyStatFS *pr_stfs, struct statfs *stfs)
 
 /*
  * Gets stat/statfs information and packs in out_iovec structure
- * on success returns number of bytes packed in out_iovec struture
+ * on success returns number of bytes packed in out_iovec structure
  * otherwise returns -errno
  */
 static int do_stat(int type, struct iovec *iovec, struct iovec *out_iovec)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 60f395c276..27c4bbe0f2 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1267,7 +1267,7 @@ ERST
     },
 SRST
 ``drive_backup``
-  Start a point-in-time copy of a block device to a specificed target.
+  Start a point-in-time copy of a block device to a specified target.
 ERST
 
     {
diff --git a/libdecnumber/decNumber.c b/libdecnumber/decNumber.c
index 8c197023f4..1ffe458ad8 100644
--- a/libdecnumber/decNumber.c
+++ b/libdecnumber/decNumber.c
@@ -5626,7 +5626,7 @@ static const uShort LNnn[90] = {
 /*    would certainly save at least one if it were made ten times     */
 /*    bigger, too (for truncated fractions 0.100 through 0.999).      */
 /*    However, for most practical evaluations, at least four or five  */
-/*    iterations will be neede -- so this would only speed up by      */
+/*    iterations will be needed -- so this would only speed up by      */
 /*    20-25% and that probably does not justify increasing the table  */
 /*    size.							      */
 /*								      */
diff --git a/qemu-img.c b/qemu-img.c
index 1d8c5cd778..3b7700c780 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1188,7 +1188,7 @@ static int64_t find_nonzero(const uint8_t *buf, int64_t n)
  * 'pnum' is set to the number of sectors (including and immediately following
  * the first one) that are known to be in the same allocated/unallocated state.
  * The function will try to align the end offset to alignment boundaries so
- * that the request will at least end aligned and consequtive requests will
+ * that the request will at least end aligned and consecutive requests will
  * also start at an aligned offset.
  */
 static int is_allocated_sectors(const uint8_t *buf, int n, int *pnum,
diff --git a/qobject/qdict.c b/qobject/qdict.c
index 526de54ceb..1079bd3f6f 100644
--- a/qobject/qdict.c
+++ b/qobject/qdict.c
@@ -33,7 +33,7 @@ QDict *qdict_new(void)
 }
 
 /**
- * tdb_hash(): based on the hash agorithm from gdbm, via tdb
+ * tdb_hash(): based on the hash algorithm from gdbm, via tdb
  * (from module-init-tools)
  */
 static unsigned int tdb_hash(const char *name)
diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c
index d735b1e7f6..685ce7f92d 100644
--- a/scsi/pr-manager-helper.c
+++ b/scsi/pr-manager-helper.c
@@ -127,7 +127,7 @@ static int pr_manager_helper_initialize(PRManagerHelper *pr_mgr,
     qio_channel_set_delay(QIO_CHANNEL(sioc), false);
     pr_mgr->ioc = QIO_CHANNEL(sioc);
 
-    /* A simple feature negotation protocol, even though there is
+    /* A simple feature negotiation protocol, even though there is
      * no optional feature right now.
      */
     r = pr_manager_helper_read(pr_mgr, &flags, sizeof(flags), errp);
-- 
2.26.2.windows.1

[PATCH V3 02/10] migration/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the migration folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 migration/colo-failover.c |  2 +-
 migration/colo.c          |  2 +-
 migration/multifd.c       |  4 ++--
 migration/postcopy-ram.c  |  4 ++--
 migration/postcopy-ram.h  |  2 +-
 migration/ram.c           | 10 +++++-----
 migration/rdma.c          |  8 ++++----
 migration/savevm.c        |  4 ++--
 8 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/migration/colo-failover.c b/migration/colo-failover.c
index e9ca0b4774..b717edc8e2 100644
--- a/migration/colo-failover.c
+++ b/migration/colo-failover.c
@@ -46,7 +46,7 @@ void failover_request_active(Error **errp)
 {
    if (failover_set_state(FAILOVER_STATUS_NONE,
         FAILOVER_STATUS_REQUIRE) != FAILOVER_STATUS_NONE) {
-        error_setg(errp, "COLO failover is already actived");
+        error_setg(errp, "COLO failover is already activated");
         return;
     }
     failover_bh = qemu_bh_new(colo_failover_bh, NULL);
diff --git a/migration/colo.c b/migration/colo.c
index ea7d1e9d4e..80788d46b5 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -632,7 +632,7 @@ out:
     /*
      * It is safe to unregister notifier after failover finished.
      * Besides, colo_delay_timer and colo_checkpoint_sem can't be
-     * released befor unregister notifier, or there will be use-after-free
+     * released before unregister notifier, or there will be use-after-free
      * error.
      */
     colo_compare_unregister_notifier(&packets_compare_notifier);
diff --git a/migration/multifd.c b/migration/multifd.c
index d0441202aa..ac84a61797 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -731,7 +731,7 @@ static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque)
         qemu_sem_post(&p->sem_sync);
         /*
          * Although multifd_send_thread is not created, but main migration
-         * thread neet to judge whether it is running, so we need to mark
+         * thread needs to judge whether it is running, so we need to mark
          * its status.
          */
         p->quit = true;
@@ -1042,7 +1042,7 @@ bool multifd_recv_all_channels_created(void)
 
 /*
  * Try to receive all multifd channels to get ready for the migration.
- * - Return true and do not set @errp when correctly receving all channels;
+ * - Return true and do not set @errp when correctly receiving all channels;
  * - Return false and do not set @errp when correctly receiving the current one;
  * - Return false and set @errp when failing to receive the current channel.
  */
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 1bb22f2b6c..baf094ba3a 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -237,7 +237,7 @@ release_ufd:
  * request_ufd_features: this function should be called only once on a newly
  * opened ufd, subsequent calls will lead to error.
  *
- * Returns: true on succes
+ * Returns: true on success
  *
  * @ufd: fd obtained from userfaultfd syscall
  * @features: bit mask see UFFD_API_FEATURES
@@ -807,7 +807,7 @@ static void mark_postcopy_blocktime_end(uintptr_t addr)
 
     low_time_offset = get_low_time_offset(dc);
     /* lookup cpu, to clear it,
-     * that algorithm looks straighforward, but it's not
+     * that algorithm looks straightforward, but it's not
      * optimal, more optimal algorithm is keeping tree or hash
      * where key is address value is a list of  */
     for (i = 0; i < smp_cpus; i++) {
diff --git a/migration/postcopy-ram.h b/migration/postcopy-ram.h
index 9941feb63a..6d2b3cf124 100644
--- a/migration/postcopy-ram.h
+++ b/migration/postcopy-ram.h
@@ -161,7 +161,7 @@ struct PostCopyFD {
  */
 void postcopy_register_shared_ufd(struct PostCopyFD *pcfd);
 void postcopy_unregister_shared_ufd(struct PostCopyFD *pcfd);
-/* Call each of the shared 'waker's registerd telling them of
+/* Call each of the shared 'waker's registered telling them of
  * availability of a block.
  */
 int postcopy_notify_shared_wake(RAMBlock *rb, uint64_t offset);
diff --git a/migration/ram.c b/migration/ram.c
index 76d4fee5d5..c5f36aeae5 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -256,7 +256,7 @@ int64_t ramblock_recv_bitmap_send(QEMUFile *file,
     /*
      * Always use little endian when sending the bitmap. This is
      * required that when source and destination VMs are not using the
-     * same endianess. (Note: big endian won't work.)
+     * same endianness. (Note: big endian won't work.)
      */
     bitmap_to_le(le_bitmap, block->receivedmap, nbits);
 
@@ -275,7 +275,7 @@ int64_t ramblock_recv_bitmap_send(QEMUFile *file,
     qemu_put_buffer(file, (const uint8_t *)le_bitmap, size);
     /*
      * Mark as an end, in case the middle part is screwed up due to
-     * some "misterious" reason.
+     * some "mysterious" reason.
      */
     qemu_put_be64(file, RAMBLOCK_RECV_BITMAP_ENDING);
     qemu_fflush(file);
@@ -718,7 +718,7 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
     /*
      * Reaching here means the page has hit the xbzrle cache, no matter what
      * encoding result it is (normal encoding, overflow or skipping the page),
-     * count the page as encoded. This is used to caculate the encoding rate.
+     * count the page as encoded. This is used to calculate the encoding rate.
      *
      * Example: 2 pages (8KB) being encoded, first page encoding generates 2KB,
      * 2nd page turns out to be skipped (i.e. no new bytes written to the
@@ -3705,7 +3705,7 @@ int ram_dirty_bitmap_reload(MigrationState *s, RAMBlock *block)
 
     /*
      * Note: see comments in ramblock_recv_bitmap_send() on why we
-     * need the endianess convertion, and the paddings.
+     * need the endianness conversion, and the paddings.
      */
     local_size = ROUND_UP(local_size, 8);
 
@@ -3743,7 +3743,7 @@ int ram_dirty_bitmap_reload(MigrationState *s, RAMBlock *block)
     }
 
     /*
-     * Endianess convertion. We are during postcopy (though paused).
+     * Endianness conversion. We are during postcopy (though paused).
      * The dirty bitmap won't change. We can directly modify it.
      */
     bitmap_from_le(block->bmap, le_bitmap, nbits);
diff --git a/migration/rdma.c b/migration/rdma.c
index 1dc563ec3f..8f43d69b06 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1511,7 +1511,7 @@ static int qemu_rdma_wait_comp_channel(RDMAContext *rdma)
     } else {
         /* This is the source side, we're in a separate thread
          * or destination prior to migration_fd_process_incoming()
-         * after postcopy, the destination also in a seprate thread.
+         * after postcopy, the destination also in a separate thread.
          * we can't yield; so we have to poll the fd.
          * But we need to be able to handle 'cancel' or an error
          * without hanging forever.
@@ -2268,7 +2268,7 @@ static inline int qemu_rdma_buffer_mergable(RDMAContext *rdma,
  *    chunk, then start a new chunk and flush() the old chunk.
  * 3. To keep the hardware busy, we also group chunks into batches
  *    and only require that a batch gets acknowledged in the completion
- *    qeueue instead of each individual chunk.
+ *    queue instead of each individual chunk.
  */
 static int qemu_rdma_write(QEMUFile *f, RDMAContext *rdma,
                            uint64_t block_offset, uint64_t offset,
@@ -3150,7 +3150,7 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void *opaque,
     if (size > 0) {
         /*
          * Add this page to the current 'chunk'. If the chunk
-         * is full, or the page doen't belong to the current chunk,
+         * is full, or the page doesn't belong to the current chunk,
          * an actual RDMA write will occur and a new chunk will be formed.
          */
         ret = qemu_rdma_write(f, rdma, block_offset, offset, size);
@@ -4103,7 +4103,7 @@ void rdma_start_outgoing_migration(void *opaque,
         goto err;
     }
 
-    /* RDMA postcopy need a seprate queue pair for return path */
+    /* RDMA postcopy need a separate queue pair for return path */
     if (migrate_postcopy()) {
         rdma_return_path = qemu_rdma_data_init(host_port, errp);
 
diff --git a/migration/savevm.c b/migration/savevm.c
index 304d98ff78..ee21e981ba 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2795,7 +2795,7 @@ void qmp_xen_save_devices_state(const char *filename, bool has_live, bool live,
 
     if (!has_live) {
         /* live default to true so old version of Xen tool stack can have a
-         * successfull live migration */
+         * successful live migration */
         live = true;
     }
 
@@ -2818,7 +2818,7 @@ void qmp_xen_save_devices_state(const char *filename, bool has_live, bool live,
          * "xen-save-devices-state" and in case of migration failure, libxl
          * would call "cont".
          * So call bdrv_inactivate_all (release locks) here to let the other
-         * side of the migration take controle of the images.
+         * side of the migration take control of the images.
          */
         if (live && !saved_vm_running) {
             ret = bdrv_inactivate_all();
-- 
2.26.2.windows.1

[PATCH V3 03/10] docs/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the docs folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 docs/COLO-FT.txt                 | 6 +++---
 docs/devel/blkdebug.txt          | 2 +-
 docs/devel/migration.rst         | 2 +-
 docs/devel/testing.rst           | 2 +-
 docs/devel/tracing.txt           | 2 +-
 docs/interop/bitmaps.rst         | 2 +-
 docs/interop/dbus.rst            | 4 ++--
 docs/interop/nbd.txt             | 2 +-
 docs/interop/vhost-user-gpu.rst  | 2 +-
 docs/interop/vhost-user.rst      | 4 ++--
 docs/rdma.txt                    | 2 +-
 docs/specs/ppc-spapr-hotplug.txt | 4 ++--
 docs/specs/ppc-spapr-xive.rst    | 4 ++--
 docs/system/arm/aspeed.rst       | 2 +-
 docs/system/deprecated.rst       | 8 ++++----
 docs/system/target-avr.rst       | 4 ++--
 docs/tools/virtiofsd.rst         | 2 +-
 17 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt
index c8e1740935..bc5fb2a1bb 100644
--- a/docs/COLO-FT.txt
+++ b/docs/COLO-FT.txt
@@ -91,7 +91,7 @@ the heartbeat stops responding, the secondary node will trigger a failover
 as soon as it determines the absence.
 
 COLO disk Manager:
-When primary VM writes data into image, the colo disk manger captures this data
+When primary VM writes data into image, the colo disk manager captures this data
 and sends it to secondary VM's which makes sure the context of secondary VM's
 image is consistent with the context of primary VM 's image.
 For more details, please refer to docs/block-replication.txt.
@@ -146,12 +146,12 @@ in test procedure.
 
 == Test procedure ==
 Note: Here we are running both instances on the same host for testing,
-change the IP Addresses if you want to run it on two hosts. Initally
+change the IP Addresses if you want to run it on two hosts. Initially
 127.0.0.1 is the Primary Host and 127.0.0.2 is the Secondary Host.
 
 == Startup qemu ==
 1. Primary:
-Note: Initally, $imagefolder/primary.qcow2 needs to be copied to all hosts.
+Note: Initially, $imagefolder/primary.qcow2 needs to be copied to all hosts.
 You don't need to change any IP's here, because 0.0.0.0 listens on any
 interface. The chardev's with 127.0.0.1 IP's loopback to the local qemu
 instance.
diff --git a/docs/devel/blkdebug.txt b/docs/devel/blkdebug.txt
index 43d8e8f9c6..0b0c128d35 100644
--- a/docs/devel/blkdebug.txt
+++ b/docs/devel/blkdebug.txt
@@ -62,7 +62,7 @@ Rules support the following attributes:
 
   errno - the numeric errno value to return when a request matches this rule.
           The errno values depend on the host since the numeric values are not
-          standarized in the POSIX specification.
+          standardized in the POSIX specification.
 
   sector - (optional) a sector number that the request must overlap in order to
            match this rule
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index 2eb08624fc..49112bb27a 100644
--- a/docs/devel/migration.rst
+++ b/docs/devel/migration.rst
@@ -625,7 +625,7 @@ It can be issued immediately after migration is started or any
 time later on.  Issuing it after the end of a migration is harmless.
 
 Blocktime is a postcopy live migration metric, intended to show how
-long the vCPU was in state of interruptable sleep due to pagefault.
+long the vCPU was in state of interruptible sleep due to pagefault.
 That metric is calculated both for all vCPUs as overlapped value, and
 separately for each vCPU. These values are calculated on destination
 side.  To enable postcopy blocktime calculation, enter following
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 196e3bc35e..bd64c1bdcd 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -471,7 +471,7 @@ the warning.
 A few important files for suppressing warnings are:
 
 tests/tsan/suppressions.tsan - Has TSan warnings we wish to suppress at runtime.
-The comment on each supression will typically indicate why we are
+The comment on each suppression will typically indicate why we are
 suppressing it.  More information on the file format can be found here:
 
 https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions
diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
index 6144d9921b..d2160655b4 100644
--- a/docs/devel/tracing.txt
+++ b/docs/devel/tracing.txt
@@ -55,7 +55,7 @@ without any sub-directory path prefix. eg io/channel-buffer.c would do
   #include "trace.h"
 
 To access the 'io/trace.h' file. While it is possible to include a trace.h
-file from outside a source files' own sub-directory, this is discouraged in
+file from outside a source file's own sub-directory, this is discouraged in
 general. It is strongly preferred that all events be declared directly in
 the sub-directory that uses them. The only exception is where there are some
 shared trace events defined in the top level directory trace-events file.
diff --git a/docs/interop/bitmaps.rst b/docs/interop/bitmaps.rst
index c20bd37a79..059ad67929 100644
--- a/docs/interop/bitmaps.rst
+++ b/docs/interop/bitmaps.rst
@@ -484,7 +484,7 @@ Bitmaps can generally be modified at any time, but certain operations often
 only make sense when paired directly with other commands. When a VM is paused,
 it's easy to ensure that no guest writes occur between individual QMP
 commands. When a VM is running, this is difficult to accomplish with
-individual QMP commands that may allow guest writes to occur inbetween each
+individual QMP commands that may allow guest writes to occur between each
 command.
 
 For example, using only individual QMP commands, we could:
diff --git a/docs/interop/dbus.rst b/docs/interop/dbus.rst
index 76a5bde625..be596d3f41 100644
--- a/docs/interop/dbus.rst
+++ b/docs/interop/dbus.rst
@@ -57,7 +57,7 @@ Depending on the use case, you may choose different scenarios:
  - Everything the same UID
 
    - Convenient for developers
-   - Improved reliability - crash of one part doens't take
+   - Improved reliability - crash of one part doesn't take
      out entire VM
    - No security benefit over traditional QEMU, unless additional
      unless additional controls such as SELinux or AppArmor are
@@ -87,7 +87,7 @@ For example, to allow only ``qemu`` user to talk to ``qemu-helper``
   </policy>
 
 
-dbus-daemon can also perfom SELinux checks based on the security
+dbus-daemon can also perform SELinux checks based on the security
 context of the source and the target. For example, ``virtiofs_t``
 could be allowed to send a message to ``svirt_t``, but ``virtiofs_t``
 wouldn't be allowed to send a message to ``virtiofs_t``.
diff --git a/docs/interop/nbd.txt b/docs/interop/nbd.txt
index 4511880961..f3b3cacc96 100644
--- a/docs/interop/nbd.txt
+++ b/docs/interop/nbd.txt
@@ -53,5 +53,5 @@ the operation of that feature.
 * 2.12: NBD_CMD_BLOCK_STATUS for "base:allocation"
 * 3.0: NBD_OPT_STARTTLS with TLS Pre-Shared Keys (PSK),
 NBD_CMD_BLOCK_STATUS for "qemu:dirty-bitmap:", NBD_CMD_CACHE
-* 4.2: NBD_FLAG_CAN_MULTI_CONN for sharable read-only exports,
+* 4.2: NBD_FLAG_CAN_MULTI_CONN for shareable read-only exports,
 NBD_CMD_FLAG_FAST_ZERO
diff --git a/docs/interop/vhost-user-gpu.rst b/docs/interop/vhost-user-gpu.rst
index 688f8b4259..3268bf405c 100644
--- a/docs/interop/vhost-user-gpu.rst
+++ b/docs/interop/vhost-user-gpu.rst
@@ -66,7 +66,7 @@ VhostUserGpuCursorPos
 
 :scanout-id: ``u32``, the scanout where the cursor is located
 
-:x/y: ``u32``, the cursor postion
+:x/y: ``u32``, the cursor position
 
 VhostUserGpuCursorUpdate
 ^^^^^^^^^^^^^^^^^^^^^^^^
diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
index 10e3e3475e..988f154144 100644
--- a/docs/interop/vhost-user.rst
+++ b/docs/interop/vhost-user.rst
@@ -464,7 +464,7 @@ the ``VHOST_USER_SET_MEM_TABLE`` request. For invalidation events, the
 (3), the I/O virtual address and the size. On success, the slave is
 expected to reply with a zero payload, non-zero otherwise.
 
-The slave relies on the slave communcation channel (see :ref:`Slave
+The slave relies on the slave communication channel (see :ref:`Slave
 communication <slave_communication>` section below) to send IOTLB miss
 and access failure events, by sending ``VHOST_USER_SLAVE_IOTLB_MSG``
 requests to the master with a ``struct vhost_iotlb_msg`` as
@@ -1450,7 +1450,7 @@ vhost-user backends can provide various devices & services and may
 need to be configured manually depending on the use case. However, it
 is a good idea to follow the conventions listed here when
 possible. Users, QEMU or libvirt, can then rely on some common
-behaviour to avoid heterogenous configuration and management of the
+behaviour to avoid heterogeneous configuration and management of the
 backend programs and facilitate interoperability.
 
 Each backend installed on a host system should come with at least one
diff --git a/docs/rdma.txt b/docs/rdma.txt
index a86e992c84..49dc9f8bca 100644
--- a/docs/rdma.txt
+++ b/docs/rdma.txt
@@ -261,7 +261,7 @@ qemu_rdma_exchange_send(header, data, optional response header & data):
    of the connection (described below).
 
 All of the remaining command types (not including 'ready')
-described above all use the aformentioned two functions to do the hard work:
+described above all use the aforementioned two functions to do the hard work:
 
 1. After connection setup, RAMBlock information is exchanged using
    this protocol before the actual migration begins. This information includes
diff --git a/docs/specs/ppc-spapr-hotplug.txt b/docs/specs/ppc-spapr-hotplug.txt
index 859d52cce6..d4fb2d46d9 100644
--- a/docs/specs/ppc-spapr-hotplug.txt
+++ b/docs/specs/ppc-spapr-hotplug.txt
@@ -371,7 +371,7 @@ ibm,dynamic-memory
 
 This property describes the dynamically reconfigurable memory. It is a
 property encoded array that has an integer N, the number of LMBs followed
-by N LMB list entires.
+by N LMB list entries.
 
 Each LMB list entry consists of the following elements:
 
@@ -390,7 +390,7 @@ Each LMB list entry consists of the following elements:
 ibm,dynamic-memory-v2
 
 This property describes the dynamically reconfigurable memory. This is
-an alternate and newer way to describe dyanamically reconfigurable memory.
+an alternate and newer way to describe dynamically reconfigurable memory.
 It is a property encoded array that has an integer N (the number of
 LMB set entries) followed by N LMB set entries. There is an LMB set entry
 for each sequential group of LMBs that share common attributes.
diff --git a/docs/specs/ppc-spapr-xive.rst b/docs/specs/ppc-spapr-xive.rst
index 7144347560..f47f739e01 100644
--- a/docs/specs/ppc-spapr-xive.rst
+++ b/docs/specs/ppc-spapr-xive.rst
@@ -46,7 +46,7 @@ default mode. ``dual`` means that both modes XICS **and** XIVE are
 supported and if the guest OS supports XIVE, this mode will be
 selected.
 
-The choosen interrupt mode is activated after a reconfiguration done
+The chosen interrupt mode is activated after a reconfiguration done
 in a machine reset.
 
 KVM negotiation
@@ -158,7 +158,7 @@ XIVE Device tree properties
 ---------------------------
 
 The properties for the PAPR interrupt controller node when the *XIVE
-native exploitation mode* is selected shoud contain:
+native exploitation mode* is selected should contain:
 
 - ``device_type``
 
diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst
index 45f891eb3c..fe45840fbe 100644
--- a/docs/system/arm/aspeed.rst
+++ b/docs/system/arm/aspeed.rst
@@ -72,7 +72,7 @@ Boot options
 ------------
 
 The Aspeed machines can be started using the -kernel option to load a
-Linux kernel or from a firmare image which can be downloaded from the
+Linux kernel or from a firmware image which can be downloaded from the
 OpenPOWER jenkins :
 
    https://openpower.xyz/
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 0cb8b01424..808c334fe7 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -79,7 +79,7 @@ Creating sound card devices and vnc without ``audiodev=`` property (since 4.2)
 
 When not using the deprecated legacy audio config, each sound card
 should specify an ``audiodev=`` property.  Additionally, when using
-vnc, you should specify an ``audiodev=`` propery if you plan to
+vnc, you should specify an ``audiodev=`` property if you plan to
 transmit audio through the VNC protocol.
 
 Creating sound card devices using ``-soundhw`` (since 5.1)
@@ -111,7 +111,7 @@ Splitting RAM by default between NUMA nodes has the same issues as ``mem``
 parameter described above with the difference that the role of the user plays
 QEMU using implicit generic or board specific splitting rule.
 Use ``memdev`` with *memory-backend-ram* backend or ``mem`` (if
-it's supported by used machine type) to define mapping explictly instead.
+it's supported by used machine type) to define mapping explicitly instead.
 
 ``-mem-path`` fallback to RAM (since 4.1)
 '''''''''''''''''''''''''''''''''''''''''
@@ -541,10 +541,10 @@ The ``[hub_id name]`` parameter tuple of the 'hostfwd_add' and
 Guest Emulator ISAs
 -------------------
 
-RISC-V ISA privledge specification version 1.09.1 (removed in 5.1)
+RISC-V ISA privilege specification version 1.09.1 (removed in 5.1)
 ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
 
-The RISC-V ISA privledge specification version 1.09.1 has been removed.
+The RISC-V ISA privilege specification version 1.09.1 has been removed.
 QEMU supports both the newer version 1.10.0 and the ratified version 1.11.0, these
 should be used instead of the 1.09.1 version.
 
diff --git a/docs/system/target-avr.rst b/docs/system/target-avr.rst
index eb5c513cce..25ab46ef05 100644
--- a/docs/system/target-avr.rst
+++ b/docs/system/target-avr.rst
@@ -10,7 +10,7 @@ xmega6 and xmega7.
 
 As for now it supports few Arduino boards for educational and testing purposes.
 These boards use a ATmega controller, which model is limited to USART & 16-bit
-timer devices, enought to run FreeRTOS based applications (like
+timer devices, enough to run FreeRTOS based applications (like
 https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo/AVR_ATMega2560_GCC/demo.elf
 ).
 
@@ -30,7 +30,7 @@ AVR cpu
 
    telnet localhost 5678
 
-- Debugging wit GDB debugger::
+- Debugging with GDB debugger::
 
    qemu-system-avr -machine mega2560 -bios demo.elf -s -S
 
diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
index e33c81ed41..7fe6a87291 100644
--- a/docs/tools/virtiofsd.rst
+++ b/docs/tools/virtiofsd.rst
@@ -76,7 +76,7 @@ Options
     I/O timeout in seconds.  The default depends on cache= option.
 
   * writeback|no_writeback -
-    Enable/disable writeback cache. The cache alows the FUSE client to buffer
+    Enable/disable writeback cache. The cache allows the FUSE client to buffer
     and merge write requests.  The default is ``no_writeback``.
 
   * xattr|no_xattr -
-- 
2.26.2.windows.1

[PATCH V3 04/10] scripts/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the scripts folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 scripts/checkpatch.pl          | 2 +-
 scripts/clean-header-guards.pl | 2 +-
 scripts/decodetree.py          | 6 +++---
 scripts/oss-fuzz/build.sh      | 2 +-
 scripts/tracetool/__init__.py  | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd3faa154c..50910899f2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1870,7 +1870,7 @@ sub process {
 			substr($s, 0, length($c), '');
 
 			# Make sure we remove the line prefixes as we have
-			# none on the first line, and are going to readd them
+			# none on the first line, and are going to re-add them
 			# where necessary.
 			$s =~ s/\n./\n/gs;
 
diff --git a/scripts/clean-header-guards.pl b/scripts/clean-header-guards.pl
index f47d673ad5..a6680253b1 100755
--- a/scripts/clean-header-guards.pl
+++ b/scripts/clean-header-guards.pl
@@ -19,7 +19,7 @@
 # Does the following:
 # - Header files without a recognizable header guard are skipped.
 # - Clean up any untidy header guards in-place.  Warn if the cleanup
-#   renames guard symbols, and explain how to find occurences of these
+#   renames guard symbols, and explain how to find occurrences of these
 #   symbols that may have to be updated manually.
 # - Warn about duplicate header guard symbols.  To make full use of
 #   this warning, you should clean up *all* headers in one run.
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index c02de9865b..60fd3b5e5f 100644
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -94,7 +94,7 @@ def str_indent(c):
 
 
 def str_fields(fields):
-    """Return a string uniquely identifing FIELDS"""
+    """Return a string uniquely identifying FIELDS"""
     r = ''
     for n in sorted(fields.keys()):
         r += '_' + n
@@ -814,7 +814,7 @@ def parse_generic(lineno, parent_pat, name, toks):
     arg = None
     fmt = None
     for t in toks:
-        # '&Foo' gives a format an explcit argument set.
+        # '&Foo' gives a format an explicit argument set.
         if re.fullmatch(re_arg_ident, t):
             tt = t[1:]
             if arg:
@@ -903,7 +903,7 @@ def parse_generic(lineno, parent_pat, name, toks):
     elif not (is_format and width == 0) and width != insnwidth:
         error(lineno, 'definition has {0} bits'.format(width))
 
-    # Do not check for fields overlaping fields; one valid usage
+    # Do not check for fields overlapping fields; one valid usage
     # is to be able to duplicate fields via import.
     fieldmask = 0
     for f in flds.values():
diff --git a/scripts/oss-fuzz/build.sh b/scripts/oss-fuzz/build.sh
index d16207eb67..0c3ca9e06f 100755
--- a/scripts/oss-fuzz/build.sh
+++ b/scripts/oss-fuzz/build.sh
@@ -69,7 +69,7 @@ mkdir -p "$DEST_DIR/lib/"  # Copy the shared libraries here
 
 if ! make "-j$(nproc)" qemu-fuzz-i386; then
     fatal "Build failed. Please specify a compiler with fuzzing support"\
-          "using the \$CC and \$CXX environemnt variables"\
+          "using the \$CC and \$CXX environment variables"\
           "\nFor example: CC=clang CXX=clang++ $0"
 fi
 
diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
index 3ccfa1e116..3ee54be223 100644
--- a/scripts/tracetool/__init__.py
+++ b/scripts/tracetool/__init__.py
@@ -34,7 +34,7 @@ def error(*lines):
 def out(*lines, **kwargs):
     """Write a set of output lines.
 
-    You can use kwargs as a shorthand for mapping variables when formating all
+    You can use kwargs as a shorthand for mapping variables when formatting all
     the strings in lines.
     """
     lines = [ l % kwargs for l in lines ]
-- 
2.26.2.windows.1

[PATCH V3 05/10] util/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the util folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
---
 util/osdep.c             | 2 +-
 util/qemu-progress.c     | 2 +-
 util/qemu-sockets.c      | 2 +-
 util/qemu-thread-win32.c | 2 +-
 util/qht.c               | 2 +-
 util/trace-events        | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/util/osdep.c b/util/osdep.c
index 4829c07ff6..e50dc2214e 100644
--- a/util/osdep.c
+++ b/util/osdep.c
@@ -392,7 +392,7 @@ int qemu_unlink(const char *name)
  * Set errno if fewer than `count' bytes are written.
  *
  * This function don't work with non-blocking fd's.
- * Any of the possibilities with non-bloking fd's is bad:
+ * Any of the possibilities with non-blocking fd's is bad:
  *   - return a short write (then name is wrong)
  *   - busy wait adding (errno == EAGAIN) to the loop
  */
diff --git a/util/qemu-progress.c b/util/qemu-progress.c
index 3c2223c1a2..20d51f8c12 100644
--- a/util/qemu-progress.c
+++ b/util/qemu-progress.c
@@ -131,7 +131,7 @@ void qemu_progress_end(void)
 /*
  * Report progress.
  * @delta is how much progress we made.
- * If @max is zero, @delta is an absolut value of the total job done.
+ * If @max is zero, @delta is an absolute value of the total job done.
  * Else, @delta is a progress delta since the last call, as a fraction
  * of @max.  I.e. the delta is @delta * @max / 100. This allows
  * relative accounting of functions which may be a different fraction of
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index b37d288866..99ce2fd5e6 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -416,7 +416,7 @@ static struct addrinfo *inet_parse_connect_saddr(InetSocketAddress *saddr,
 
     /* At least FreeBSD and OS-X 10.6 declare AI_V4MAPPED but
      * then don't implement it in their getaddrinfo(). Detect
-     * this and retry without the flag since that's preferrable
+     * this and retry without the flag since that's preferable
      * to a fatal error
      */
     if (rc == EAI_BADFLAGS &&
diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
index 56a83333da..d207b0cb58 100644
--- a/util/qemu-thread-win32.c
+++ b/util/qemu-thread-win32.c
@@ -289,7 +289,7 @@ void qemu_event_wait(QemuEvent *ev)
             ResetEvent(ev->event);
 
             /* Tell qemu_event_set that there are waiters.  No need to retry
-             * because there cannot be a concurent busy->free transition.
+             * because there cannot be a concurrent busy->free transition.
              * After the CAS, the event will be either set or busy.
              */
             if (atomic_cmpxchg(&ev->value, EV_FREE, EV_BUSY) == EV_SET) {
diff --git a/util/qht.c b/util/qht.c
index 67e5d5b916..b2e020c398 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -49,7 +49,7 @@
  * it anymore.
  *
  * Writers check for concurrent resizes by comparing ht->map before and after
- * acquiring their bucket lock. If they don't match, a resize has occured
+ * acquiring their bucket lock. If they don't match, a resize has occurred
  * while the bucket spinlock was being acquired.
  *
  * Related Work:
diff --git a/util/trace-events b/util/trace-events
index 4e894aa9c3..24c31803b0 100644
--- a/util/trace-events
+++ b/util/trace-events
@@ -28,7 +28,7 @@ qemu_file_monitor_add_watch(void *mon, const char *dirpath, const char *filename
 qemu_file_monitor_remove_watch(void *mon, const char *dirpath, int64_t id) "File monitor %p remove watch dir='%s' id=%" PRId64
 qemu_file_monitor_new(void *mon, int fd) "File monitor %p created fd=%d"
 qemu_file_monitor_enable_watch(void *mon, const char *dirpath, int id) "File monitor %p enable watch dir='%s' id=%u"
-qemu_file_monitor_disable_watch(void *mon, const char *dirpath, int id) "Fle monitor %p disable watch dir='%s' id=%u"
+qemu_file_monitor_disable_watch(void *mon, const char *dirpath, int id) "File monitor %p disable watch dir='%s' id=%u"
 qemu_file_monitor_event(void *mon, const char *dirpath, const char *filename, int mask, unsigned int id) "File monitor %p event dir='%s' file='%s' mask=0x%x id=%u"
 qemu_file_monitor_dispatch(void *mon, const char *dirpath, const char *filename, int ev, void *cb, void *opaque, int64_t id) "File monitor %p dispatch dir='%s' file='%s' ev=%d cb=%p opaque=%p id=%" PRId64
 
-- 
2.26.2.windows.1

[PATCH V3 06/10] linux-user/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the linux-user folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
---
 linux-user/aarch64/signal.c              | 2 +-
 linux-user/cris/target_syscall.h         | 4 ++--
 linux-user/flat.h                        | 2 +-
 linux-user/flatload.c                    | 4 ++--
 linux-user/host/ppc64/safe-syscall.inc.S | 2 +-
 linux-user/syscall.c                     | 4 ++--
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/linux-user/aarch64/signal.c b/linux-user/aarch64/signal.c
index cd521ee42d..d50c1ae583 100644
--- a/linux-user/aarch64/signal.c
+++ b/linux-user/aarch64/signal.c
@@ -78,7 +78,7 @@ struct target_sve_context {
     struct target_aarch64_ctx head;
     uint16_t vl;
     uint16_t reserved[3];
-    /* The actual SVE data immediately follows.  It is layed out
+    /* The actual SVE data immediately follows.  It is laid out
      * according to TARGET_SVE_SIG_{Z,P}REG_OFFSET, based off of
      * the original struct pointer.
      */
diff --git a/linux-user/cris/target_syscall.h b/linux-user/cris/target_syscall.h
index d109a6b42a..19e1281403 100644
--- a/linux-user/cris/target_syscall.h
+++ b/linux-user/cris/target_syscall.h
@@ -4,7 +4,7 @@
 #define UNAME_MACHINE "cris"
 #define UNAME_MINIMUM_RELEASE "2.6.32"
 
-/* pt_regs not only specifices the format in the user-struct during
+/* pt_regs not only specifies the format in the user-struct during
  * ptrace but is also the frame format used in the kernel prologue/epilogues
  * themselves
  */
@@ -32,7 +32,7 @@ struct target_pt_regs {
         unsigned long spc;
         unsigned long ccs;
         unsigned long srp;
-        unsigned long erp; /* This is actually the debugged process' PC */
+        unsigned long erp; /* This is actually the debugged process's PC */
         /* For debugging purposes; saved only when needed. */
         unsigned long exs;
         unsigned long eda;
diff --git a/linux-user/flat.h b/linux-user/flat.h
index 1e44b33443..ed518e2013 100644
--- a/linux-user/flat.h
+++ b/linux-user/flat.h
@@ -43,7 +43,7 @@ struct flat_hdr {
 	abi_ulong reloc_count;  /* Number of relocation records */
 	abi_ulong flags;
 	abi_ulong build_date;   /* When the program/library was built */
-	abi_ulong filler[5];    /* Reservered, set to zero */
+	abi_ulong filler[5];    /* Reserved, set to zero */
 };
 
 #define FLAT_FLAG_RAM    0x0001 /* load program entirely into RAM */
diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index 8fb448f0bf..14d2999d15 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -442,7 +442,7 @@ static int load_flat_file(struct linux_binprm * bprm,
     indx_len = (indx_len + 15) & ~(abi_ulong)15;
 
     /*
-     * Alloate the address space.
+     * Allocate the address space.
      */
     probe_guest_base(bprm->filename, 0,
                      text_len + data_len + extra + indx_len);
@@ -794,7 +794,7 @@ int load_flt_binary(struct linux_binprm *bprm, struct image_info *info)
 #error here
     for (i = MAX_SHARED_LIBS-1; i>0; i--) {
             if (libinfo[i].loaded) {
-                    /* Push previos first to call address */
+                    /* Push previous first to call address */
                     --sp;
                     if (put_user_ual(start_addr, sp))
                         return -EFAULT;
diff --git a/linux-user/host/ppc64/safe-syscall.inc.S b/linux-user/host/ppc64/safe-syscall.inc.S
index 8ed73a5b86..875133173b 100644
--- a/linux-user/host/ppc64/safe-syscall.inc.S
+++ b/linux-user/host/ppc64/safe-syscall.inc.S
@@ -84,7 +84,7 @@ safe_syscall_end:
 
 	/* code path when we didn't execute the syscall */
 0:	addi	3, 0, -TARGET_ERESTARTSYS
-	ld 14, 16(1) /* restore r14 to its orginal value */
+	ld 14, 16(1) /* restore r14 to its original value */
 	blr
 	.cfi_endproc
 
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 55ac5c3208..897d20c076 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -481,7 +481,7 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
 
 
 #if defined(TARGET_NR_timer_create)
-/* Maxiumum of 32 active POSIX timers allowed at any one time. */
+/* Maximum of 32 active POSIX timers allowed at any one time. */
 static timer_t g_posix_timers[32] = { 0, } ;
 
 static inline int next_free_host_timer(void)
@@ -8180,7 +8180,7 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
     switch(num) {
     case TARGET_NR_exit:
         /* In old applications this may be used to implement _exit(2).
-           However in threaded applictions it is used for thread termination,
+           However in threaded applications it is used for thread termination,
            and _exit_group is used for application termination.
            Do thread termination if we have more then one thread.  */
 
-- 
2.26.2.windows.1

[PATCH V3 07/10] block/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the block folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
---
 block/block-copy.c | 2 +-
 block/linux-aio.c  | 2 +-
 block/mirror.c     | 2 +-
 block/vhdx.c       | 2 +-
 block/vhdx.h       | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/block/block-copy.c b/block/block-copy.c
index cd9bc47c8f..5eb8912e0a 100644
--- a/block/block-copy.c
+++ b/block/block-copy.c
@@ -321,7 +321,7 @@ static coroutine_fn int block_copy_task_run(AioTaskPool *pool,
  * Do copy of cluster-aligned chunk. Requested region is allowed to exceed
  * s->len only to cover last cluster when s->len is not aligned to clusters.
  *
- * No sync here: nor bitmap neighter intersecting requests handling, only copy.
+ * No sync here: neither bitmap nor intersecting requests handling, only copy.
  *
  * Returns 0 on success.
  */
diff --git a/block/linux-aio.c b/block/linux-aio.c
index 3c0527c2bf..772ff860ea 100644
--- a/block/linux-aio.c
+++ b/block/linux-aio.c
@@ -222,7 +222,7 @@ static void qemu_laio_process_completions(LinuxAioState *s)
 
     /* If we are nested we have to notify the level above that we are done
      * by setting event_max to zero, upper level will then jump out of it's
-     * own `for` loop.  If we are the last all counters droped to zero. */
+     * own `for` loop.  If we are the last all counters dropped to zero. */
     s->event_max = 0;
     s->event_idx = 0;
 }
diff --git a/block/mirror.c b/block/mirror.c
index 26acf4af6f..c798a1e54e 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -479,7 +479,7 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s)
 
     job_pause_point(&s->common.job);
 
-    /* Find the number of consective dirty chunks following the first dirty
+    /* Find the number of consecutive dirty chunks following the first dirty
      * one, and wait for in flight requests in them. */
     bdrv_dirty_bitmap_lock(s->dirty_bitmap);
     while (nb_chunks * s->granularity < s->buf_size) {
diff --git a/block/vhdx.c b/block/vhdx.c
index 356ec4c455..99cc3d12bb 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -1073,7 +1073,7 @@ static int vhdx_open(BlockDriverState *bs, QDict *options, int flags,
         goto fail;
     }
 
-    /* endian convert populated BAT field entires */
+    /* endian convert populated BAT field entries */
     for (i = 0; i < s->bat_entries; i++) {
         s->bat[i] = le64_to_cpu(s->bat[i]);
     }
diff --git a/block/vhdx.h b/block/vhdx.h
index 0b74924cee..e385e484b4 100644
--- a/block/vhdx.h
+++ b/block/vhdx.h
@@ -212,7 +212,7 @@ typedef struct QEMU_PACKED VHDXLogDataSector {
     uint32_t    sequence_high;          /* 4 MSB of 8 byte sequence_number */
     uint8_t     data[4084];             /* raw data, bytes 8-4091 (inclusive).
                                            see the data descriptor field for the
-                                           other mising bytes */
+                                           other missing bytes */
     uint32_t    sequence_low;           /* 4 LSB of 8 byte sequence_number */
 } VHDXLogDataSector;
 
@@ -257,7 +257,7 @@ typedef struct QEMU_PACKED VHDXMetadataTableHeader {
 
 #define VHDX_META_FLAGS_IS_USER         0x01    /* max 1024 entries */
 #define VHDX_META_FLAGS_IS_VIRTUAL_DISK 0x02    /* virtual disk metadata if set,
-                                                   otherwise file metdata */
+                                                   otherwise file metadata */
 #define VHDX_META_FLAGS_IS_REQUIRED     0x04    /* parse must understand this
                                                    entry to open the file */
 typedef struct QEMU_PACKED VHDXMetadataTableEntry {
-- 
2.26.2.windows.1

[PATCH V3 08/10] disas/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the disas folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
---
 disas/hppa.c | 2 +-
 disas/m68k.c | 8 ++++----
 disas/ppc.c  | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/disas/hppa.c b/disas/hppa.c
index 2dbd1fc445..dcf9a47f34 100644
--- a/disas/hppa.c
+++ b/disas/hppa.c
@@ -2021,7 +2021,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info)
 			fput_fp_reg (GET_FIELD (insn, 6, 10), info);
 		      break;
 
-		      /* 'fA' will not generate a space before the regsiter
+		      /* 'fA' will not generate a space before the register
 			 name.  Normally that is fine.  Except that it
 			 causes problems with xmpyu which has no FP format
 			 completer.  */
diff --git a/disas/m68k.c b/disas/m68k.c
index 863409c67c..aefaecfbd6 100644
--- a/disas/m68k.c
+++ b/disas/m68k.c
@@ -70,7 +70,7 @@ struct floatformat
   unsigned int exp_start;
   unsigned int exp_len;
   /* Bias added to a "true" exponent to form the biased exponent.  It
-     is intentionally signed as, otherwize, -exp_bias can turn into a
+     is intentionally signed as, otherwise, -exp_bias can turn into a
      very large number (e.g., given the exp_bias of 0x3fff and a 64
      bit long, the equation (long)(1 - exp_bias) evaluates to
      4294950914) instead of -16382).  */
@@ -479,7 +479,7 @@ struct m68k_opcode_alias
       and remaining 3 bits of register shifted 9 bits in first word.
       Indicate upper/lower in 1 bit shifted 7 bits in second word.
       Use with `R' or `u' format.
-   n  `m' withouth upper/lower indication. (For M[S]ACx; 4 bits split
+   n  `m' without upper/lower indication. (For M[S]ACx; 4 bits split
       with MSB shifted 6 bits in first word and remaining 3 bits of
       register shifted 9 bits in first word.  No upper/lower
       indication is done.)  Use with `R' or `u' format.
@@ -854,7 +854,7 @@ fetch_arg (unsigned char *buffer,
 
 /* Check if an EA is valid for a particular code.  This is required
    for the EMAC instructions since the type of source address determines
-   if it is a EMAC-load instruciton if the EA is mode 2-5, otherwise it
+   if it is a EMAC-load instruction if the EA is mode 2-5, otherwise it
    is a non-load EMAC instruction and the bits mean register Ry.
    A similar case exists for the movem instructions where the register
    mask is interpreted differently for different EAs.  */
@@ -1080,7 +1080,7 @@ print_indexed (int basereg,
 
 /* Returns number of bytes "eaten" by the operand, or
    return -1 if an invalid operand was found, or -2 if
-   an opcode tabe error was found.
+   an opcode table error was found.
    ADDR is the pc for this arg to be relative to.  */
 
 static int
diff --git a/disas/ppc.c b/disas/ppc.c
index 63e97cfe1d..02be878198 100644
--- a/disas/ppc.c
+++ b/disas/ppc.c
@@ -5226,7 +5226,7 @@ operand_value_powerpc (const struct powerpc_operand *operand,
       if ((operand->flags & PPC_OPERAND_SIGNED) != 0)
 	{
 	  /* BITM is always some number of zeros followed by some
-	     number of ones, followed by some numer of zeros.  */
+	     number of ones, followed by some number of zeros.  */
 	  unsigned long top = operand->bitm;
 	  /* top & -top gives the rightmost 1 bit, so this
 	     fills in any trailing zeros.  */
-- 
2.26.2.windows.1

[PATCH V3 09/10] qapi/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the qapi folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/block-core.json | 4 ++--
 qapi/crypto.json     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 2d94873ca0..3c16f1e11d 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1795,7 +1795,7 @@
 #
 # @block-backend: corresponds to BlockBackend
 #
-# @block-job: corresonds to BlockJob
+# @block-job: corresponds to BlockJob
 #
 # @block-driver: corresponds to BlockDriverState
 #
@@ -2067,7 +2067,7 @@
 # @target: name of the destination dirty bitmap
 #
 # @bitmaps: name(s) of the source dirty bitmap(s) at @node and/or fully
-#           specifed BlockDirtyBitmap elements. The latter are supported
+#           specified BlockDirtyBitmap elements. The latter are supported
 #           since 4.1.
 #
 # Since: 4.0
diff --git a/qapi/crypto.json b/qapi/crypto.json
index bb7930d332..2aebe6fa20 100644
--- a/qapi/crypto.json
+++ b/qapi/crypto.json
@@ -336,7 +336,7 @@
 #                 written into added active keyslots
 #
 # @old-secret:    Optional (for deactivation only)
-#                 If given will deactive all keyslots that
+#                 If given will deactivate all keyslots that
 #                 match password located in QCryptoSecret with this ID
 #
 # @iter-time:     Optional (for activation only)
@@ -354,7 +354,7 @@
 #                 keyslot to deactivate
 #
 # @secret:        Optional. The ID of a QCryptoSecret object providing the
-#                 password to use to retrive current master key.
+#                 password to use to retrieve current master key.
 #                 Defaults to the same secret that was used to open the image
 #
 #
-- 
2.26.2.windows.1

[PATCH V3 10/10] contrib/: fix some comment spelling errors

[zhaolichang]

I found that there are many spelling errors in the comments of qemu,
so I used the spellcheck tool to check the spelling errors
and finally found some spelling errors in the contrib folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
---
 contrib/gitdm/filetypes.txt             | 6 +++---
 contrib/ivshmem-client/ivshmem-client.h | 2 +-
 contrib/libvhost-user/libvhost-user.c   | 4 ++--
 contrib/libvhost-user/libvhost-user.h   | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/contrib/gitdm/filetypes.txt b/contrib/gitdm/filetypes.txt
index 9e9c505205..d2d6f6db8d 100644
--- a/contrib/gitdm/filetypes.txt
+++ b/contrib/gitdm/filetypes.txt
@@ -22,7 +22,7 @@
 # in the gitdm sample-config directory.
 #
 # This file contains associations parameters regarding filetypes
-# (documentation, develompent, multimedia, images...)
+# (documentation, development, multimedia, images...)
 #
 # format:
 # filetype <type> <regex> [<comment>]
@@ -59,8 +59,8 @@ filetype code \.s$	# Assembly
 filetype code \.S$	# Assembly
 filetype code \.asm$	# Assembly
 filetype code \.awk$	# awk
-filetype code ^common$  # script fragements
-filetype code ^common.*$  # script fragements
+filetype code ^common$  # script fragments
+filetype code ^common.*$  # script fragments
 filetype code (qom|qmp)-\w+$  # python script fragments
 
 #
diff --git a/contrib/ivshmem-client/ivshmem-client.h b/contrib/ivshmem-client/ivshmem-client.h
index fe3cc4a03d..fc45a38060 100644
--- a/contrib/ivshmem-client/ivshmem-client.h
+++ b/contrib/ivshmem-client/ivshmem-client.h
@@ -174,7 +174,7 @@ int ivshmem_client_notify_all_vects(const IvshmemClient *client,
                                     const IvshmemClientPeer *peer);
 
 /**
- * Broadcat a notification to all vectors of all peers
+ * Broadcast a notification to all vectors of all peers
  *
  * @client: The ivshmem client
  *
diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
index 53f16bdf08..9d30ff2283 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -684,7 +684,7 @@ vu_add_mem_reg(VuDev *dev, VhostUserMsg *vmsg) {
 
     /*
      * If we are in postcopy mode and we receive a u64 payload with a 0 value
-     * we know all the postcopy client bases have been recieved, and we
+     * we know all the postcopy client bases have been received, and we
      * should start generating faults.
      */
     if (track_ramblocks &&
@@ -973,7 +973,7 @@ vu_set_mem_table_exec(VuDev *dev, VhostUserMsg *vmsg)
     for (i = 0; i < dev->max_queues; i++) {
         if (dev->vq[i].vring.desc) {
             if (map_ring(dev, &dev->vq[i])) {
-                vu_panic(dev, "remaping queue %d during setmemtable", i);
+                vu_panic(dev, "remapping queue %d during setmemtable", i);
             }
         }
     }
diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h
index 844c37c648..287ac5fec7 100644
--- a/contrib/libvhost-user/libvhost-user.h
+++ b/contrib/libvhost-user/libvhost-user.h
@@ -424,7 +424,7 @@ typedef struct VuVirtqElement {
  * @remove_watch: a remove_watch callback
  * @iface: a VuDevIface structure with vhost-user device callbacks
  *
- * Intializes a VuDev vhost-user context.
+ * Initializes a VuDev vhost-user context.
  *
  * Returns: true on success, false on failure.
  **/
-- 
2.26.2.windows.1

Re: [PATCH V3 00/10] fix some comment spelling errors

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200917075029.313-1-zhaolichang@huawei.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.






The full log is available at
http://patchew.org/logs/20200917075029.313-1-zhaolichang@huawei.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH V3 00/10] fix some comment spelling errors

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200917075029.313-1-zhaolichang@huawei.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.






The full log is available at
http://patchew.org/logs/20200917075029.313-1-zhaolichang@huawei.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH V3 08/10] disas/: fix some comment spelling errors

[Alex Bennée]

zhaolichang <zhaolichang@huawei.com> writes:

> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the disas folder.
>
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

I suggest on your next posting you CC qemu-trivial@nongnu.org so the
patches can get pulled in via the trivial tree.

> ---
>  disas/hppa.c | 2 +-
>  disas/m68k.c | 8 ++++----
>  disas/ppc.c  | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/disas/hppa.c b/disas/hppa.c
> index 2dbd1fc445..dcf9a47f34 100644
> --- a/disas/hppa.c
> +++ b/disas/hppa.c
> @@ -2021,7 +2021,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info)
>  			fput_fp_reg (GET_FIELD (insn, 6, 10), info);
>  		      break;
>  
> -		      /* 'fA' will not generate a space before the regsiter
> +		      /* 'fA' will not generate a space before the register
>  			 name.  Normally that is fine.  Except that it
>  			 causes problems with xmpyu which has no FP format
>  			 completer.  */
> diff --git a/disas/m68k.c b/disas/m68k.c
> index 863409c67c..aefaecfbd6 100644
> --- a/disas/m68k.c
> +++ b/disas/m68k.c
> @@ -70,7 +70,7 @@ struct floatformat
>    unsigned int exp_start;
>    unsigned int exp_len;
>    /* Bias added to a "true" exponent to form the biased exponent.  It
> -     is intentionally signed as, otherwize, -exp_bias can turn into a
> +     is intentionally signed as, otherwise, -exp_bias can turn into a
>       very large number (e.g., given the exp_bias of 0x3fff and a 64
>       bit long, the equation (long)(1 - exp_bias) evaluates to
>       4294950914) instead of -16382).  */
> @@ -479,7 +479,7 @@ struct m68k_opcode_alias
>        and remaining 3 bits of register shifted 9 bits in first word.
>        Indicate upper/lower in 1 bit shifted 7 bits in second word.
>        Use with `R' or `u' format.
> -   n  `m' withouth upper/lower indication. (For M[S]ACx; 4 bits split
> +   n  `m' without upper/lower indication. (For M[S]ACx; 4 bits split
>        with MSB shifted 6 bits in first word and remaining 3 bits of
>        register shifted 9 bits in first word.  No upper/lower
>        indication is done.)  Use with `R' or `u' format.
> @@ -854,7 +854,7 @@ fetch_arg (unsigned char *buffer,
>  
>  /* Check if an EA is valid for a particular code.  This is required
>     for the EMAC instructions since the type of source address determines
> -   if it is a EMAC-load instruciton if the EA is mode 2-5, otherwise it
> +   if it is a EMAC-load instruction if the EA is mode 2-5, otherwise it
>     is a non-load EMAC instruction and the bits mean register Ry.
>     A similar case exists for the movem instructions where the register
>     mask is interpreted differently for different EAs.  */
> @@ -1080,7 +1080,7 @@ print_indexed (int basereg,
>  
>  /* Returns number of bytes "eaten" by the operand, or
>     return -1 if an invalid operand was found, or -2 if
> -   an opcode tabe error was found.
> +   an opcode table error was found.
>     ADDR is the pc for this arg to be relative to.  */
>  
>  static int
> diff --git a/disas/ppc.c b/disas/ppc.c
> index 63e97cfe1d..02be878198 100644
> --- a/disas/ppc.c
> +++ b/disas/ppc.c
> @@ -5226,7 +5226,7 @@ operand_value_powerpc (const struct powerpc_operand *operand,
>        if ((operand->flags & PPC_OPERAND_SIGNED) != 0)
>  	{
>  	  /* BITM is always some number of zeros followed by some
> -	     number of ones, followed by some numer of zeros.  */
> +	     number of ones, followed by some number of zeros.  */
>  	  unsigned long top = operand->bitm;
>  	  /* top & -top gives the rightmost 1 bit, so this
>  	     fills in any trailing zeros.  */


-- 
Alex Bennée

Re: [PATCH V3 00/10] fix some comment spelling errors

[no-reply]

Patchew URL: https://patchew.org/QEMU/20200917075029.313-1-zhaolichang@huawei.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.






The full log is available at
http://patchew.org/logs/20200917075029.313-1-zhaolichang@huawei.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH V3 01/10] qemu/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
> ---
>  Changelog                   | 2 +-
>  accel/tcg/user-exec.c       | 2 +-
>  audio/audio.c               | 2 +-
>  block.c                     | 2 +-
>  configure                   | 2 +-
>  fsdev/virtfs-proxy-helper.c | 2 +-
>  hmp-commands.hx             | 2 +-
>  libdecnumber/decNumber.c    | 2 +-
>  qemu-img.c                  | 2 +-
>  qobject/qdict.c             | 2 +-
>  scsi/pr-manager-helper.c    | 2 +-
>  11 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/Changelog b/Changelog
> index 4a90bb9e8b..f7e178ccc0 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -241,7 +241,7 @@ version 0.8.0:
>  version 0.7.2:
>  
>    - x86_64 fixes (Win2000 and Linux 2.6 boot in 32 bit)
> -  - merge self modifying code handling in dirty ram page mecanism.
> +  - merge self modifying code handling in dirty ram page mechanism.
>    - MIPS fixes (Ralf Baechle)
>    - better user net performances
>  
> diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
> index bb039eb32d..5c96819ded 100644
> --- a/accel/tcg/user-exec.c
> +++ b/accel/tcg/user-exec.c
> @@ -88,7 +88,7 @@ static inline int handle_cpu_signal(uintptr_t pc, siginfo_t *info,
>           * use that value directly.  Within cpu_restore_state_from_tb, we
>           * assume PC comes from GETPC(), as used by the helper functions,
>           * so we adjust the address by -GETPC_ADJ to form an address that
> -         * is within the call insn, so that the address does not accidentially
> +         * is within the call insn, so that the address does not accidentally
>           * match the beginning of the next guest insn.  However, when the
>           * pc comes from the signal frame it points to the actual faulting
>           * host memory insn and not the return from a call insn.
> diff --git a/audio/audio.c b/audio/audio.c
> index ce8c6dec5f..1a68cfaafb 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -1674,7 +1674,7 @@ static AudioState *audio_init(Audiodev *dev, const char *name)
>          head = audio_handle_legacy_opts();
>          /*
>           * In case of legacy initialization, all Audiodevs in the list will have
> -         * the same configuration (except the driver), so it does't matter which
> +         * the same configuration (except the driver), so it doesn't matter which
>           * one we chose.  We need an Audiodev to set up AudioState before we can
>           * init a driver.  Also note that dev at this point is still in the
>           * list.
> diff --git a/block.c b/block.c
> index 9538af4884..11ab55f80b 100644
> --- a/block.c
> +++ b/block.c
> @@ -2602,7 +2602,7 @@ static void bdrv_replace_child_noperm(BdrvChild *child,
>  
>  /*
>   * Updates @child to change its reference to point to @new_bs, including
> - * checking and applying the necessary permisson updates both to the old node
> + * checking and applying the necessary permission updates both to the old node
>   * and to @new_bs.
>   *
>   * NULL is passed as @new_bs for removing the reference before freeing @child.
> diff --git a/configure b/configure
> index ce27eafb0a..c74d79bfbc 100755
> --- a/configure
> +++ b/configure
> @@ -3411,7 +3411,7 @@ EOF
>      xfs="yes"
>    else
>      if test "$xfs" = "yes" ; then
> -      feature_not_found "xfs" "Instal xfsprogs/xfslibs devel"
> +      feature_not_found "xfs" "Install xfsprogs/xfslibs devel"
>      fi
>      xfs=no
>    fi
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index de061a8a0e..15c0e79b06 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -518,7 +518,7 @@ static void statfs_to_prstatfs(ProxyStatFS *pr_stfs, struct statfs *stfs)
>  
>  /*
>   * Gets stat/statfs information and packs in out_iovec structure
> - * on success returns number of bytes packed in out_iovec struture
> + * on success returns number of bytes packed in out_iovec structure
>   * otherwise returns -errno
>   */
>  static int do_stat(int type, struct iovec *iovec, struct iovec *out_iovec)
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 60f395c276..27c4bbe0f2 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1267,7 +1267,7 @@ ERST
>      },
>  SRST
>  ``drive_backup``
> -  Start a point-in-time copy of a block device to a specificed target.
> +  Start a point-in-time copy of a block device to a specified target.
>  ERST
>  
>      {
> diff --git a/libdecnumber/decNumber.c b/libdecnumber/decNumber.c
> index 8c197023f4..1ffe458ad8 100644
> --- a/libdecnumber/decNumber.c
> +++ b/libdecnumber/decNumber.c
> @@ -5626,7 +5626,7 @@ static const uShort LNnn[90] = {
>  /*    would certainly save at least one if it were made ten times     */
>  /*    bigger, too (for truncated fractions 0.100 through 0.999).      */
>  /*    However, for most practical evaluations, at least four or five  */
> -/*    iterations will be neede -- so this would only speed up by      */
> +/*    iterations will be needed -- so this would only speed up by      */
>  /*    20-25% and that probably does not justify increasing the table  */
>  /*    size.							      */
>  /*								      */
> diff --git a/qemu-img.c b/qemu-img.c
> index 1d8c5cd778..3b7700c780 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1188,7 +1188,7 @@ static int64_t find_nonzero(const uint8_t *buf, int64_t n)
>   * 'pnum' is set to the number of sectors (including and immediately following
>   * the first one) that are known to be in the same allocated/unallocated state.
>   * The function will try to align the end offset to alignment boundaries so
> - * that the request will at least end aligned and consequtive requests will
> + * that the request will at least end aligned and consecutive requests will
>   * also start at an aligned offset.
>   */
>  static int is_allocated_sectors(const uint8_t *buf, int n, int *pnum,
> diff --git a/qobject/qdict.c b/qobject/qdict.c
> index 526de54ceb..1079bd3f6f 100644
> --- a/qobject/qdict.c
> +++ b/qobject/qdict.c
> @@ -33,7 +33,7 @@ QDict *qdict_new(void)
>  }
>  
>  /**
> - * tdb_hash(): based on the hash agorithm from gdbm, via tdb
> + * tdb_hash(): based on the hash algorithm from gdbm, via tdb
>   * (from module-init-tools)
>   */
>  static unsigned int tdb_hash(const char *name)
> diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c
> index d735b1e7f6..685ce7f92d 100644
> --- a/scsi/pr-manager-helper.c
> +++ b/scsi/pr-manager-helper.c
> @@ -127,7 +127,7 @@ static int pr_manager_helper_initialize(PRManagerHelper *pr_mgr,
>      qio_channel_set_delay(QIO_CHANNEL(sioc), false);
>      pr_mgr->ioc = QIO_CHANNEL(sioc);
>  
> -    /* A simple feature negotation protocol, even though there is
> +    /* A simple feature negotiation protocol, even though there is
>       * no optional feature right now.
>       */
>      r = pr_manager_helper_read(pr_mgr, &flags, sizeof(flags), errp);
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH V3 02/10] migration/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the migration folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  migration/colo-failover.c |  2 +-
>  migration/colo.c          |  2 +-
>  migration/multifd.c       |  4 ++--
>  migration/postcopy-ram.c  |  4 ++--
>  migration/postcopy-ram.h  |  2 +-
>  migration/ram.c           | 10 +++++-----
>  migration/rdma.c          |  8 ++++----
>  migration/savevm.c        |  4 ++--
>  8 files changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/migration/colo-failover.c b/migration/colo-failover.c
> index e9ca0b4774..b717edc8e2 100644
> --- a/migration/colo-failover.c
> +++ b/migration/colo-failover.c
> @@ -46,7 +46,7 @@ void failover_request_active(Error **errp)
>  {
>     if (failover_set_state(FAILOVER_STATUS_NONE,
>          FAILOVER_STATUS_REQUIRE) != FAILOVER_STATUS_NONE) {
> -        error_setg(errp, "COLO failover is already actived");
> +        error_setg(errp, "COLO failover is already activated");
>          return;
>      }
>      failover_bh = qemu_bh_new(colo_failover_bh, NULL);
> diff --git a/migration/colo.c b/migration/colo.c
> index ea7d1e9d4e..80788d46b5 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -632,7 +632,7 @@ out:
>      /*
>       * It is safe to unregister notifier after failover finished.
>       * Besides, colo_delay_timer and colo_checkpoint_sem can't be
> -     * released befor unregister notifier, or there will be use-after-free
> +     * released before unregister notifier, or there will be use-after-free
>       * error.
>       */
>      colo_compare_unregister_notifier(&packets_compare_notifier);
> diff --git a/migration/multifd.c b/migration/multifd.c
> index d0441202aa..ac84a61797 100644
> --- a/migration/multifd.c
> +++ b/migration/multifd.c
> @@ -731,7 +731,7 @@ static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque)
>          qemu_sem_post(&p->sem_sync);
>          /*
>           * Although multifd_send_thread is not created, but main migration
> -         * thread neet to judge whether it is running, so we need to mark
> +         * thread needs to judge whether it is running, so we need to mark
>           * its status.
>           */
>          p->quit = true;
> @@ -1042,7 +1042,7 @@ bool multifd_recv_all_channels_created(void)
>  
>  /*
>   * Try to receive all multifd channels to get ready for the migration.
> - * - Return true and do not set @errp when correctly receving all channels;
> + * - Return true and do not set @errp when correctly receiving all channels;
>   * - Return false and do not set @errp when correctly receiving the current one;
>   * - Return false and set @errp when failing to receive the current channel.
>   */
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index 1bb22f2b6c..baf094ba3a 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -237,7 +237,7 @@ release_ufd:
>   * request_ufd_features: this function should be called only once on a newly
>   * opened ufd, subsequent calls will lead to error.
>   *
> - * Returns: true on succes
> + * Returns: true on success
>   *
>   * @ufd: fd obtained from userfaultfd syscall
>   * @features: bit mask see UFFD_API_FEATURES
> @@ -807,7 +807,7 @@ static void mark_postcopy_blocktime_end(uintptr_t addr)
>  
>      low_time_offset = get_low_time_offset(dc);
>      /* lookup cpu, to clear it,
> -     * that algorithm looks straighforward, but it's not
> +     * that algorithm looks straightforward, but it's not
>       * optimal, more optimal algorithm is keeping tree or hash
>       * where key is address value is a list of  */
>      for (i = 0; i < smp_cpus; i++) {
> diff --git a/migration/postcopy-ram.h b/migration/postcopy-ram.h
> index 9941feb63a..6d2b3cf124 100644
> --- a/migration/postcopy-ram.h
> +++ b/migration/postcopy-ram.h
> @@ -161,7 +161,7 @@ struct PostCopyFD {
>   */
>  void postcopy_register_shared_ufd(struct PostCopyFD *pcfd);
>  void postcopy_unregister_shared_ufd(struct PostCopyFD *pcfd);
> -/* Call each of the shared 'waker's registerd telling them of
> +/* Call each of the shared 'waker's registered telling them of
>   * availability of a block.
>   */
>  int postcopy_notify_shared_wake(RAMBlock *rb, uint64_t offset);
> diff --git a/migration/ram.c b/migration/ram.c
> index 76d4fee5d5..c5f36aeae5 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -256,7 +256,7 @@ int64_t ramblock_recv_bitmap_send(QEMUFile *file,
>      /*
>       * Always use little endian when sending the bitmap. This is
>       * required that when source and destination VMs are not using the
> -     * same endianess. (Note: big endian won't work.)
> +     * same endianness. (Note: big endian won't work.)
>       */
>      bitmap_to_le(le_bitmap, block->receivedmap, nbits);
>  
> @@ -275,7 +275,7 @@ int64_t ramblock_recv_bitmap_send(QEMUFile *file,
>      qemu_put_buffer(file, (const uint8_t *)le_bitmap, size);
>      /*
>       * Mark as an end, in case the middle part is screwed up due to
> -     * some "misterious" reason.
> +     * some "mysterious" reason.
>       */
>      qemu_put_be64(file, RAMBLOCK_RECV_BITMAP_ENDING);
>      qemu_fflush(file);
> @@ -718,7 +718,7 @@ static int save_xbzrle_page(RAMState *rs, uint8_t **current_data,
>      /*
>       * Reaching here means the page has hit the xbzrle cache, no matter what
>       * encoding result it is (normal encoding, overflow or skipping the page),
> -     * count the page as encoded. This is used to caculate the encoding rate.
> +     * count the page as encoded. This is used to calculate the encoding rate.
>       *
>       * Example: 2 pages (8KB) being encoded, first page encoding generates 2KB,
>       * 2nd page turns out to be skipped (i.e. no new bytes written to the
> @@ -3705,7 +3705,7 @@ int ram_dirty_bitmap_reload(MigrationState *s, RAMBlock *block)
>  
>      /*
>       * Note: see comments in ramblock_recv_bitmap_send() on why we
> -     * need the endianess convertion, and the paddings.
> +     * need the endianness conversion, and the paddings.
>       */
>      local_size = ROUND_UP(local_size, 8);
>  
> @@ -3743,7 +3743,7 @@ int ram_dirty_bitmap_reload(MigrationState *s, RAMBlock *block)
>      }
>  
>      /*
> -     * Endianess convertion. We are during postcopy (though paused).
> +     * Endianness conversion. We are during postcopy (though paused).
>       * The dirty bitmap won't change. We can directly modify it.
>       */
>      bitmap_from_le(block->bmap, le_bitmap, nbits);
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 1dc563ec3f..8f43d69b06 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -1511,7 +1511,7 @@ static int qemu_rdma_wait_comp_channel(RDMAContext *rdma)
>      } else {
>          /* This is the source side, we're in a separate thread
>           * or destination prior to migration_fd_process_incoming()
> -         * after postcopy, the destination also in a seprate thread.
> +         * after postcopy, the destination also in a separate thread.
>           * we can't yield; so we have to poll the fd.
>           * But we need to be able to handle 'cancel' or an error
>           * without hanging forever.
> @@ -2268,7 +2268,7 @@ static inline int qemu_rdma_buffer_mergable(RDMAContext *rdma,
>   *    chunk, then start a new chunk and flush() the old chunk.
>   * 3. To keep the hardware busy, we also group chunks into batches
>   *    and only require that a batch gets acknowledged in the completion
> - *    qeueue instead of each individual chunk.
> + *    queue instead of each individual chunk.
>   */
>  static int qemu_rdma_write(QEMUFile *f, RDMAContext *rdma,
>                             uint64_t block_offset, uint64_t offset,
> @@ -3150,7 +3150,7 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void *opaque,
>      if (size > 0) {
>          /*
>           * Add this page to the current 'chunk'. If the chunk
> -         * is full, or the page doen't belong to the current chunk,
> +         * is full, or the page doesn't belong to the current chunk,
>           * an actual RDMA write will occur and a new chunk will be formed.
>           */
>          ret = qemu_rdma_write(f, rdma, block_offset, offset, size);
> @@ -4103,7 +4103,7 @@ void rdma_start_outgoing_migration(void *opaque,
>          goto err;
>      }
>  
> -    /* RDMA postcopy need a seprate queue pair for return path */
> +    /* RDMA postcopy need a separate queue pair for return path */
>      if (migrate_postcopy()) {
>          rdma_return_path = qemu_rdma_data_init(host_port, errp);
>  
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 304d98ff78..ee21e981ba 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -2795,7 +2795,7 @@ void qmp_xen_save_devices_state(const char *filename, bool has_live, bool live,
>  
>      if (!has_live) {
>          /* live default to true so old version of Xen tool stack can have a
> -         * successfull live migration */
> +         * successful live migration */
>          live = true;
>      }
>  
> @@ -2818,7 +2818,7 @@ void qmp_xen_save_devices_state(const char *filename, bool has_live, bool live,
>           * "xen-save-devices-state" and in case of migration failure, libxl
>           * would call "cont".
>           * So call bdrv_inactivate_all (release locks) here to let the other
> -         * side of the migration take controle of the images.
> +         * side of the migration take control of the images.
>           */
>          if (live && !saved_vm_running) {
>              ret = bdrv_inactivate_all();
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH V3 03/10] docs/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the docs folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  docs/COLO-FT.txt                 | 6 +++---
>  docs/devel/blkdebug.txt          | 2 +-
>  docs/devel/migration.rst         | 2 +-
>  docs/devel/testing.rst           | 2 +-
>  docs/devel/tracing.txt           | 2 +-
>  docs/interop/bitmaps.rst         | 2 +-
>  docs/interop/dbus.rst            | 4 ++--
>  docs/interop/nbd.txt             | 2 +-
>  docs/interop/vhost-user-gpu.rst  | 2 +-
>  docs/interop/vhost-user.rst      | 4 ++--
>  docs/rdma.txt                    | 2 +-
>  docs/specs/ppc-spapr-hotplug.txt | 4 ++--
>  docs/specs/ppc-spapr-xive.rst    | 4 ++--
>  docs/system/arm/aspeed.rst       | 2 +-
>  docs/system/deprecated.rst       | 8 ++++----
>  docs/system/target-avr.rst       | 4 ++--
>  docs/tools/virtiofsd.rst         | 2 +-
>  17 files changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt
> index c8e1740935..bc5fb2a1bb 100644
> --- a/docs/COLO-FT.txt
> +++ b/docs/COLO-FT.txt
> @@ -91,7 +91,7 @@ the heartbeat stops responding, the secondary node will trigger a failover
>  as soon as it determines the absence.
>  
>  COLO disk Manager:
> -When primary VM writes data into image, the colo disk manger captures this data
> +When primary VM writes data into image, the colo disk manager captures this data
>  and sends it to secondary VM's which makes sure the context of secondary VM's
>  image is consistent with the context of primary VM 's image.
>  For more details, please refer to docs/block-replication.txt.
> @@ -146,12 +146,12 @@ in test procedure.
>  
>  == Test procedure ==
>  Note: Here we are running both instances on the same host for testing,
> -change the IP Addresses if you want to run it on two hosts. Initally
> +change the IP Addresses if you want to run it on two hosts. Initially
>  127.0.0.1 is the Primary Host and 127.0.0.2 is the Secondary Host.
>  
>  == Startup qemu ==
>  1. Primary:
> -Note: Initally, $imagefolder/primary.qcow2 needs to be copied to all hosts.
> +Note: Initially, $imagefolder/primary.qcow2 needs to be copied to all hosts.
>  You don't need to change any IP's here, because 0.0.0.0 listens on any
>  interface. The chardev's with 127.0.0.1 IP's loopback to the local qemu
>  instance.
> diff --git a/docs/devel/blkdebug.txt b/docs/devel/blkdebug.txt
> index 43d8e8f9c6..0b0c128d35 100644
> --- a/docs/devel/blkdebug.txt
> +++ b/docs/devel/blkdebug.txt
> @@ -62,7 +62,7 @@ Rules support the following attributes:
>  
>    errno - the numeric errno value to return when a request matches this rule.
>            The errno values depend on the host since the numeric values are not
> -          standarized in the POSIX specification.
> +          standardized in the POSIX specification.
>  
>    sector - (optional) a sector number that the request must overlap in order to
>             match this rule
> diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
> index 2eb08624fc..49112bb27a 100644
> --- a/docs/devel/migration.rst
> +++ b/docs/devel/migration.rst
> @@ -625,7 +625,7 @@ It can be issued immediately after migration is started or any
>  time later on.  Issuing it after the end of a migration is harmless.
>  
>  Blocktime is a postcopy live migration metric, intended to show how
> -long the vCPU was in state of interruptable sleep due to pagefault.
> +long the vCPU was in state of interruptible sleep due to pagefault.
>  That metric is calculated both for all vCPUs as overlapped value, and
>  separately for each vCPU. These values are calculated on destination
>  side.  To enable postcopy blocktime calculation, enter following
> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> index 196e3bc35e..bd64c1bdcd 100644
> --- a/docs/devel/testing.rst
> +++ b/docs/devel/testing.rst
> @@ -471,7 +471,7 @@ the warning.
>  A few important files for suppressing warnings are:
>  
>  tests/tsan/suppressions.tsan - Has TSan warnings we wish to suppress at runtime.
> -The comment on each supression will typically indicate why we are
> +The comment on each suppression will typically indicate why we are
>  suppressing it.  More information on the file format can be found here:
>  
>  https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions
> diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt
> index 6144d9921b..d2160655b4 100644
> --- a/docs/devel/tracing.txt
> +++ b/docs/devel/tracing.txt
> @@ -55,7 +55,7 @@ without any sub-directory path prefix. eg io/channel-buffer.c would do
>    #include "trace.h"
>  
>  To access the 'io/trace.h' file. While it is possible to include a trace.h
> -file from outside a source files' own sub-directory, this is discouraged in
> +file from outside a source file's own sub-directory, this is discouraged in
>  general. It is strongly preferred that all events be declared directly in
>  the sub-directory that uses them. The only exception is where there are some
>  shared trace events defined in the top level directory trace-events file.
> diff --git a/docs/interop/bitmaps.rst b/docs/interop/bitmaps.rst
> index c20bd37a79..059ad67929 100644
> --- a/docs/interop/bitmaps.rst
> +++ b/docs/interop/bitmaps.rst
> @@ -484,7 +484,7 @@ Bitmaps can generally be modified at any time, but certain operations often
>  only make sense when paired directly with other commands. When a VM is paused,
>  it's easy to ensure that no guest writes occur between individual QMP
>  commands. When a VM is running, this is difficult to accomplish with
> -individual QMP commands that may allow guest writes to occur inbetween each
> +individual QMP commands that may allow guest writes to occur between each
>  command.
>  
>  For example, using only individual QMP commands, we could:
> diff --git a/docs/interop/dbus.rst b/docs/interop/dbus.rst
> index 76a5bde625..be596d3f41 100644
> --- a/docs/interop/dbus.rst
> +++ b/docs/interop/dbus.rst
> @@ -57,7 +57,7 @@ Depending on the use case, you may choose different scenarios:
>   - Everything the same UID
>  
>     - Convenient for developers
> -   - Improved reliability - crash of one part doens't take
> +   - Improved reliability - crash of one part doesn't take
>       out entire VM
>     - No security benefit over traditional QEMU, unless additional
>       unless additional controls such as SELinux or AppArmor are
> @@ -87,7 +87,7 @@ For example, to allow only ``qemu`` user to talk to ``qemu-helper``
>    </policy>
>  
>  
> -dbus-daemon can also perfom SELinux checks based on the security
> +dbus-daemon can also perform SELinux checks based on the security
>  context of the source and the target. For example, ``virtiofs_t``
>  could be allowed to send a message to ``svirt_t``, but ``virtiofs_t``
>  wouldn't be allowed to send a message to ``virtiofs_t``.
> diff --git a/docs/interop/nbd.txt b/docs/interop/nbd.txt
> index 4511880961..f3b3cacc96 100644
> --- a/docs/interop/nbd.txt
> +++ b/docs/interop/nbd.txt
> @@ -53,5 +53,5 @@ the operation of that feature.
>  * 2.12: NBD_CMD_BLOCK_STATUS for "base:allocation"
>  * 3.0: NBD_OPT_STARTTLS with TLS Pre-Shared Keys (PSK),
>  NBD_CMD_BLOCK_STATUS for "qemu:dirty-bitmap:", NBD_CMD_CACHE
> -* 4.2: NBD_FLAG_CAN_MULTI_CONN for sharable read-only exports,
> +* 4.2: NBD_FLAG_CAN_MULTI_CONN for shareable read-only exports,
>  NBD_CMD_FLAG_FAST_ZERO
> diff --git a/docs/interop/vhost-user-gpu.rst b/docs/interop/vhost-user-gpu.rst
> index 688f8b4259..3268bf405c 100644
> --- a/docs/interop/vhost-user-gpu.rst
> +++ b/docs/interop/vhost-user-gpu.rst
> @@ -66,7 +66,7 @@ VhostUserGpuCursorPos
>  
>  :scanout-id: ``u32``, the scanout where the cursor is located
>  
> -:x/y: ``u32``, the cursor postion
> +:x/y: ``u32``, the cursor position
>  
>  VhostUserGpuCursorUpdate
>  ^^^^^^^^^^^^^^^^^^^^^^^^
> diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
> index 10e3e3475e..988f154144 100644
> --- a/docs/interop/vhost-user.rst
> +++ b/docs/interop/vhost-user.rst
> @@ -464,7 +464,7 @@ the ``VHOST_USER_SET_MEM_TABLE`` request. For invalidation events, the
>  (3), the I/O virtual address and the size. On success, the slave is
>  expected to reply with a zero payload, non-zero otherwise.
>  
> -The slave relies on the slave communcation channel (see :ref:`Slave
> +The slave relies on the slave communication channel (see :ref:`Slave
>  communication <slave_communication>` section below) to send IOTLB miss
>  and access failure events, by sending ``VHOST_USER_SLAVE_IOTLB_MSG``
>  requests to the master with a ``struct vhost_iotlb_msg`` as
> @@ -1450,7 +1450,7 @@ vhost-user backends can provide various devices & services and may
>  need to be configured manually depending on the use case. However, it
>  is a good idea to follow the conventions listed here when
>  possible. Users, QEMU or libvirt, can then rely on some common
> -behaviour to avoid heterogenous configuration and management of the
> +behaviour to avoid heterogeneous configuration and management of the
>  backend programs and facilitate interoperability.
>  
>  Each backend installed on a host system should come with at least one
> diff --git a/docs/rdma.txt b/docs/rdma.txt
> index a86e992c84..49dc9f8bca 100644
> --- a/docs/rdma.txt
> +++ b/docs/rdma.txt
> @@ -261,7 +261,7 @@ qemu_rdma_exchange_send(header, data, optional response header & data):
>     of the connection (described below).
>  
>  All of the remaining command types (not including 'ready')
> -described above all use the aformentioned two functions to do the hard work:
> +described above all use the aforementioned two functions to do the hard work:
>  
>  1. After connection setup, RAMBlock information is exchanged using
>     this protocol before the actual migration begins. This information includes
> diff --git a/docs/specs/ppc-spapr-hotplug.txt b/docs/specs/ppc-spapr-hotplug.txt
> index 859d52cce6..d4fb2d46d9 100644
> --- a/docs/specs/ppc-spapr-hotplug.txt
> +++ b/docs/specs/ppc-spapr-hotplug.txt
> @@ -371,7 +371,7 @@ ibm,dynamic-memory
>  
>  This property describes the dynamically reconfigurable memory. It is a
>  property encoded array that has an integer N, the number of LMBs followed
> -by N LMB list entires.
> +by N LMB list entries.
>  
>  Each LMB list entry consists of the following elements:
>  
> @@ -390,7 +390,7 @@ Each LMB list entry consists of the following elements:
>  ibm,dynamic-memory-v2
>  
>  This property describes the dynamically reconfigurable memory. This is
> -an alternate and newer way to describe dyanamically reconfigurable memory.
> +an alternate and newer way to describe dynamically reconfigurable memory.
>  It is a property encoded array that has an integer N (the number of
>  LMB set entries) followed by N LMB set entries. There is an LMB set entry
>  for each sequential group of LMBs that share common attributes.
> diff --git a/docs/specs/ppc-spapr-xive.rst b/docs/specs/ppc-spapr-xive.rst
> index 7144347560..f47f739e01 100644
> --- a/docs/specs/ppc-spapr-xive.rst
> +++ b/docs/specs/ppc-spapr-xive.rst
> @@ -46,7 +46,7 @@ default mode. ``dual`` means that both modes XICS **and** XIVE are
>  supported and if the guest OS supports XIVE, this mode will be
>  selected.
>  
> -The choosen interrupt mode is activated after a reconfiguration done
> +The chosen interrupt mode is activated after a reconfiguration done
>  in a machine reset.
>  
>  KVM negotiation
> @@ -158,7 +158,7 @@ XIVE Device tree properties
>  ---------------------------
>  
>  The properties for the PAPR interrupt controller node when the *XIVE
> -native exploitation mode* is selected shoud contain:
> +native exploitation mode* is selected should contain:
>  
>  - ``device_type``
>  
> diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst
> index 45f891eb3c..fe45840fbe 100644
> --- a/docs/system/arm/aspeed.rst
> +++ b/docs/system/arm/aspeed.rst
> @@ -72,7 +72,7 @@ Boot options
>  ------------
>  
>  The Aspeed machines can be started using the -kernel option to load a
> -Linux kernel or from a firmare image which can be downloaded from the
> +Linux kernel or from a firmware image which can be downloaded from the
>  OpenPOWER jenkins :
>  
>     https://openpower.xyz/
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 0cb8b01424..808c334fe7 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -79,7 +79,7 @@ Creating sound card devices and vnc without ``audiodev=`` property (since 4.2)
>  
>  When not using the deprecated legacy audio config, each sound card
>  should specify an ``audiodev=`` property.  Additionally, when using
> -vnc, you should specify an ``audiodev=`` propery if you plan to
> +vnc, you should specify an ``audiodev=`` property if you plan to
>  transmit audio through the VNC protocol.
>  
>  Creating sound card devices using ``-soundhw`` (since 5.1)
> @@ -111,7 +111,7 @@ Splitting RAM by default between NUMA nodes has the same issues as ``mem``
>  parameter described above with the difference that the role of the user plays
>  QEMU using implicit generic or board specific splitting rule.
>  Use ``memdev`` with *memory-backend-ram* backend or ``mem`` (if
> -it's supported by used machine type) to define mapping explictly instead.
> +it's supported by used machine type) to define mapping explicitly instead.
>  
>  ``-mem-path`` fallback to RAM (since 4.1)
>  '''''''''''''''''''''''''''''''''''''''''
> @@ -541,10 +541,10 @@ The ``[hub_id name]`` parameter tuple of the 'hostfwd_add' and
>  Guest Emulator ISAs
>  -------------------
>  
> -RISC-V ISA privledge specification version 1.09.1 (removed in 5.1)
> +RISC-V ISA privilege specification version 1.09.1 (removed in 5.1)
>  ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
>  
> -The RISC-V ISA privledge specification version 1.09.1 has been removed.
> +The RISC-V ISA privilege specification version 1.09.1 has been removed.
>  QEMU supports both the newer version 1.10.0 and the ratified version 1.11.0, these
>  should be used instead of the 1.09.1 version.
>  
> diff --git a/docs/system/target-avr.rst b/docs/system/target-avr.rst
> index eb5c513cce..25ab46ef05 100644
> --- a/docs/system/target-avr.rst
> +++ b/docs/system/target-avr.rst
> @@ -10,7 +10,7 @@ xmega6 and xmega7.
>  
>  As for now it supports few Arduino boards for educational and testing purposes.
>  These boards use a ATmega controller, which model is limited to USART & 16-bit
> -timer devices, enought to run FreeRTOS based applications (like
> +timer devices, enough to run FreeRTOS based applications (like
>  https://github.com/seharris/qemu-avr-tests/blob/master/free-rtos/Demo/AVR_ATMega2560_GCC/demo.elf
>  ).
>  
> @@ -30,7 +30,7 @@ AVR cpu
>  
>     telnet localhost 5678
>  
> -- Debugging wit GDB debugger::
> +- Debugging with GDB debugger::
>  
>     qemu-system-avr -machine mega2560 -bios demo.elf -s -S
>  
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index e33c81ed41..7fe6a87291 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -76,7 +76,7 @@ Options
>      I/O timeout in seconds.  The default depends on cache= option.
>  
>    * writeback|no_writeback -
> -    Enable/disable writeback cache. The cache alows the FUSE client to buffer
> +    Enable/disable writeback cache. The cache allows the FUSE client to buffer
>      and merge write requests.  The default is ``no_writeback``.
>  
>    * xattr|no_xattr -
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH V3 04/10] scripts/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the scripts folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  scripts/checkpatch.pl          | 2 +-
>  scripts/clean-header-guards.pl | 2 +-
>  scripts/decodetree.py          | 6 +++---
>  scripts/oss-fuzz/build.sh      | 2 +-
>  scripts/tracetool/__init__.py  | 2 +-
>  5 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index bd3faa154c..50910899f2 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1870,7 +1870,7 @@ sub process {
>  			substr($s, 0, length($c), '');
>  
>  			# Make sure we remove the line prefixes as we have
> -			# none on the first line, and are going to readd them
> +			# none on the first line, and are going to re-add them
>  			# where necessary.
>  			$s =~ s/\n./\n/gs;
>  
> diff --git a/scripts/clean-header-guards.pl b/scripts/clean-header-guards.pl
> index f47d673ad5..a6680253b1 100755
> --- a/scripts/clean-header-guards.pl
> +++ b/scripts/clean-header-guards.pl
> @@ -19,7 +19,7 @@
>  # Does the following:
>  # - Header files without a recognizable header guard are skipped.
>  # - Clean up any untidy header guards in-place.  Warn if the cleanup
> -#   renames guard symbols, and explain how to find occurences of these
> +#   renames guard symbols, and explain how to find occurrences of these
>  #   symbols that may have to be updated manually.
>  # - Warn about duplicate header guard symbols.  To make full use of
>  #   this warning, you should clean up *all* headers in one run.
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index c02de9865b..60fd3b5e5f 100644
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -94,7 +94,7 @@ def str_indent(c):
>  
>  
>  def str_fields(fields):
> -    """Return a string uniquely identifing FIELDS"""
> +    """Return a string uniquely identifying FIELDS"""
>      r = ''
>      for n in sorted(fields.keys()):
>          r += '_' + n
> @@ -814,7 +814,7 @@ def parse_generic(lineno, parent_pat, name, toks):
>      arg = None
>      fmt = None
>      for t in toks:
> -        # '&Foo' gives a format an explcit argument set.
> +        # '&Foo' gives a format an explicit argument set.
>          if re.fullmatch(re_arg_ident, t):
>              tt = t[1:]
>              if arg:
> @@ -903,7 +903,7 @@ def parse_generic(lineno, parent_pat, name, toks):
>      elif not (is_format and width == 0) and width != insnwidth:
>          error(lineno, 'definition has {0} bits'.format(width))
>  
> -    # Do not check for fields overlaping fields; one valid usage
> +    # Do not check for fields overlapping fields; one valid usage
>      # is to be able to duplicate fields via import.
>      fieldmask = 0
>      for f in flds.values():
> diff --git a/scripts/oss-fuzz/build.sh b/scripts/oss-fuzz/build.sh
> index d16207eb67..0c3ca9e06f 100755
> --- a/scripts/oss-fuzz/build.sh
> +++ b/scripts/oss-fuzz/build.sh
> @@ -69,7 +69,7 @@ mkdir -p "$DEST_DIR/lib/"  # Copy the shared libraries here
>  
>  if ! make "-j$(nproc)" qemu-fuzz-i386; then
>      fatal "Build failed. Please specify a compiler with fuzzing support"\
> -          "using the \$CC and \$CXX environemnt variables"\
> +          "using the \$CC and \$CXX environment variables"\
>            "\nFor example: CC=clang CXX=clang++ $0"
>  fi
>  
> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
> index 3ccfa1e116..3ee54be223 100644
> --- a/scripts/tracetool/__init__.py
> +++ b/scripts/tracetool/__init__.py
> @@ -34,7 +34,7 @@ def error(*lines):
>  def out(*lines, **kwargs):
>      """Write a set of output lines.
>  
> -    You can use kwargs as a shorthand for mapping variables when formating all
> +    You can use kwargs as a shorthand for mapping variables when formatting all
>      the strings in lines.
>      """
>      lines = [ l % kwargs for l in lines ]
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH V3 05/10] util/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the util folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
> ---
>  util/osdep.c             | 2 +-
>  util/qemu-progress.c     | 2 +-
>  util/qemu-sockets.c      | 2 +-
>  util/qemu-thread-win32.c | 2 +-
>  util/qht.c               | 2 +-
>  util/trace-events        | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/util/osdep.c b/util/osdep.c
> index 4829c07ff6..e50dc2214e 100644
> --- a/util/osdep.c
> +++ b/util/osdep.c
> @@ -392,7 +392,7 @@ int qemu_unlink(const char *name)
>   * Set errno if fewer than `count' bytes are written.
>   *
>   * This function don't work with non-blocking fd's.
> - * Any of the possibilities with non-bloking fd's is bad:
> + * Any of the possibilities with non-blocking fd's is bad:
>   *   - return a short write (then name is wrong)
>   *   - busy wait adding (errno == EAGAIN) to the loop
>   */
> diff --git a/util/qemu-progress.c b/util/qemu-progress.c
> index 3c2223c1a2..20d51f8c12 100644
> --- a/util/qemu-progress.c
> +++ b/util/qemu-progress.c
> @@ -131,7 +131,7 @@ void qemu_progress_end(void)
>  /*
>   * Report progress.
>   * @delta is how much progress we made.
> - * If @max is zero, @delta is an absolut value of the total job done.
> + * If @max is zero, @delta is an absolute value of the total job done.
>   * Else, @delta is a progress delta since the last call, as a fraction
>   * of @max.  I.e. the delta is @delta * @max / 100. This allows
>   * relative accounting of functions which may be a different fraction of
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index b37d288866..99ce2fd5e6 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -416,7 +416,7 @@ static struct addrinfo *inet_parse_connect_saddr(InetSocketAddress *saddr,
>  
>      /* At least FreeBSD and OS-X 10.6 declare AI_V4MAPPED but
>       * then don't implement it in their getaddrinfo(). Detect
> -     * this and retry without the flag since that's preferrable
> +     * this and retry without the flag since that's preferable
>       * to a fatal error
>       */
>      if (rc == EAI_BADFLAGS &&
> diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
> index 56a83333da..d207b0cb58 100644
> --- a/util/qemu-thread-win32.c
> +++ b/util/qemu-thread-win32.c
> @@ -289,7 +289,7 @@ void qemu_event_wait(QemuEvent *ev)
>              ResetEvent(ev->event);
>  
>              /* Tell qemu_event_set that there are waiters.  No need to retry
> -             * because there cannot be a concurent busy->free transition.
> +             * because there cannot be a concurrent busy->free transition.
>               * After the CAS, the event will be either set or busy.
>               */
>              if (atomic_cmpxchg(&ev->value, EV_FREE, EV_BUSY) == EV_SET) {
> diff --git a/util/qht.c b/util/qht.c
> index 67e5d5b916..b2e020c398 100644
> --- a/util/qht.c
> +++ b/util/qht.c
> @@ -49,7 +49,7 @@
>   * it anymore.
>   *
>   * Writers check for concurrent resizes by comparing ht->map before and after
> - * acquiring their bucket lock. If they don't match, a resize has occured
> + * acquiring their bucket lock. If they don't match, a resize has occurred
>   * while the bucket spinlock was being acquired.
>   *
>   * Related Work:
> diff --git a/util/trace-events b/util/trace-events
> index 4e894aa9c3..24c31803b0 100644
> --- a/util/trace-events
> +++ b/util/trace-events
> @@ -28,7 +28,7 @@ qemu_file_monitor_add_watch(void *mon, const char *dirpath, const char *filename
>  qemu_file_monitor_remove_watch(void *mon, const char *dirpath, int64_t id) "File monitor %p remove watch dir='%s' id=%" PRId64
>  qemu_file_monitor_new(void *mon, int fd) "File monitor %p created fd=%d"
>  qemu_file_monitor_enable_watch(void *mon, const char *dirpath, int id) "File monitor %p enable watch dir='%s' id=%u"
> -qemu_file_monitor_disable_watch(void *mon, const char *dirpath, int id) "Fle monitor %p disable watch dir='%s' id=%u"
> +qemu_file_monitor_disable_watch(void *mon, const char *dirpath, int id) "File monitor %p disable watch dir='%s' id=%u"
>  qemu_file_monitor_event(void *mon, const char *dirpath, const char *filename, int mask, unsigned int id) "File monitor %p event dir='%s' file='%s' mask=0x%x id=%u"
>  qemu_file_monitor_dispatch(void *mon, const char *dirpath, const char *filename, int ev, void *cb, void *opaque, int64_t id) "File monitor %p dispatch dir='%s' file='%s' ev=%d cb=%p opaque=%p id=%" PRId64
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH V3 06/10] linux-user/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the linux-user folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
> ---
>  linux-user/aarch64/signal.c              | 2 +-
>  linux-user/cris/target_syscall.h         | 4 ++--
>  linux-user/flat.h                        | 2 +-
>  linux-user/flatload.c                    | 4 ++--
>  linux-user/host/ppc64/safe-syscall.inc.S | 2 +-
>  linux-user/syscall.c                     | 4 ++--
>  6 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/linux-user/aarch64/signal.c b/linux-user/aarch64/signal.c
> index cd521ee42d..d50c1ae583 100644
> --- a/linux-user/aarch64/signal.c
> +++ b/linux-user/aarch64/signal.c
> @@ -78,7 +78,7 @@ struct target_sve_context {
>      struct target_aarch64_ctx head;
>      uint16_t vl;
>      uint16_t reserved[3];
> -    /* The actual SVE data immediately follows.  It is layed out
> +    /* The actual SVE data immediately follows.  It is laid out
>       * according to TARGET_SVE_SIG_{Z,P}REG_OFFSET, based off of
>       * the original struct pointer.
>       */
> diff --git a/linux-user/cris/target_syscall.h b/linux-user/cris/target_syscall.h
> index d109a6b42a..19e1281403 100644
> --- a/linux-user/cris/target_syscall.h
> +++ b/linux-user/cris/target_syscall.h
> @@ -4,7 +4,7 @@
>  #define UNAME_MACHINE "cris"
>  #define UNAME_MINIMUM_RELEASE "2.6.32"
>  
> -/* pt_regs not only specifices the format in the user-struct during
> +/* pt_regs not only specifies the format in the user-struct during
>   * ptrace but is also the frame format used in the kernel prologue/epilogues
>   * themselves
>   */
> @@ -32,7 +32,7 @@ struct target_pt_regs {
>          unsigned long spc;
>          unsigned long ccs;
>          unsigned long srp;
> -        unsigned long erp; /* This is actually the debugged process' PC */
> +        unsigned long erp; /* This is actually the debugged process's PC */
>          /* For debugging purposes; saved only when needed. */
>          unsigned long exs;
>          unsigned long eda;
> diff --git a/linux-user/flat.h b/linux-user/flat.h
> index 1e44b33443..ed518e2013 100644
> --- a/linux-user/flat.h
> +++ b/linux-user/flat.h
> @@ -43,7 +43,7 @@ struct flat_hdr {
>  	abi_ulong reloc_count;  /* Number of relocation records */
>  	abi_ulong flags;
>  	abi_ulong build_date;   /* When the program/library was built */
> -	abi_ulong filler[5];    /* Reservered, set to zero */
> +	abi_ulong filler[5];    /* Reserved, set to zero */
>  };
>  
>  #define FLAT_FLAG_RAM    0x0001 /* load program entirely into RAM */
> diff --git a/linux-user/flatload.c b/linux-user/flatload.c
> index 8fb448f0bf..14d2999d15 100644
> --- a/linux-user/flatload.c
> +++ b/linux-user/flatload.c
> @@ -442,7 +442,7 @@ static int load_flat_file(struct linux_binprm * bprm,
>      indx_len = (indx_len + 15) & ~(abi_ulong)15;
>  
>      /*
> -     * Alloate the address space.
> +     * Allocate the address space.
>       */
>      probe_guest_base(bprm->filename, 0,
>                       text_len + data_len + extra + indx_len);
> @@ -794,7 +794,7 @@ int load_flt_binary(struct linux_binprm *bprm, struct image_info *info)
>  #error here
>      for (i = MAX_SHARED_LIBS-1; i>0; i--) {
>              if (libinfo[i].loaded) {
> -                    /* Push previos first to call address */
> +                    /* Push previous first to call address */
>                      --sp;
>                      if (put_user_ual(start_addr, sp))
>                          return -EFAULT;
> diff --git a/linux-user/host/ppc64/safe-syscall.inc.S b/linux-user/host/ppc64/safe-syscall.inc.S
> index 8ed73a5b86..875133173b 100644
> --- a/linux-user/host/ppc64/safe-syscall.inc.S
> +++ b/linux-user/host/ppc64/safe-syscall.inc.S
> @@ -84,7 +84,7 @@ safe_syscall_end:
>  
>  	/* code path when we didn't execute the syscall */
>  0:	addi	3, 0, -TARGET_ERESTARTSYS
> -	ld 14, 16(1) /* restore r14 to its orginal value */
> +	ld 14, 16(1) /* restore r14 to its original value */
>  	blr
>  	.cfi_endproc
>  
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 55ac5c3208..897d20c076 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -481,7 +481,7 @@ _syscall4(int, sys_prlimit64, pid_t, pid, int, resource,
>  
>  
>  #if defined(TARGET_NR_timer_create)
> -/* Maxiumum of 32 active POSIX timers allowed at any one time. */
> +/* Maximum of 32 active POSIX timers allowed at any one time. */
>  static timer_t g_posix_timers[32] = { 0, } ;
>  
>  static inline int next_free_host_timer(void)
> @@ -8180,7 +8180,7 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
>      switch(num) {
>      case TARGET_NR_exit:
>          /* In old applications this may be used to implement _exit(2).
> -           However in threaded applictions it is used for thread termination,
> +           However in threaded applications it is used for thread termination,
>             and _exit_group is used for application termination.
>             Do thread termination if we have more then one thread.  */
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH V3 08/10] disas/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 10:44, Alex Bennée a écrit :
> 
> zhaolichang <zhaolichang@huawei.com> writes:
> 
>> I found that there are many spelling errors in the comments of qemu,
>> so I used the spellcheck tool to check the spelling errors
>> and finally found some spelling errors in the disas folder.
>>
>> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> 
> I suggest on your next posting you CC qemu-trivial@nongnu.org so the
> patches can get pulled in via the trivial tree.

It was.

Applied to my trivial-patches branch.

Thanks,
Laurent

> 
>> ---
>>  disas/hppa.c | 2 +-
>>  disas/m68k.c | 8 ++++----
>>  disas/ppc.c  | 2 +-
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/disas/hppa.c b/disas/hppa.c
>> index 2dbd1fc445..dcf9a47f34 100644
>> --- a/disas/hppa.c
>> +++ b/disas/hppa.c
>> @@ -2021,7 +2021,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info)
>>  			fput_fp_reg (GET_FIELD (insn, 6, 10), info);
>>  		      break;
>>  
>> -		      /* 'fA' will not generate a space before the regsiter
>> +		      /* 'fA' will not generate a space before the register
>>  			 name.  Normally that is fine.  Except that it
>>  			 causes problems with xmpyu which has no FP format
>>  			 completer.  */
>> diff --git a/disas/m68k.c b/disas/m68k.c
>> index 863409c67c..aefaecfbd6 100644
>> --- a/disas/m68k.c
>> +++ b/disas/m68k.c
>> @@ -70,7 +70,7 @@ struct floatformat
>>    unsigned int exp_start;
>>    unsigned int exp_len;
>>    /* Bias added to a "true" exponent to form the biased exponent.  It
>> -     is intentionally signed as, otherwize, -exp_bias can turn into a
>> +     is intentionally signed as, otherwise, -exp_bias can turn into a
>>       very large number (e.g., given the exp_bias of 0x3fff and a 64
>>       bit long, the equation (long)(1 - exp_bias) evaluates to
>>       4294950914) instead of -16382).  */
>> @@ -479,7 +479,7 @@ struct m68k_opcode_alias
>>        and remaining 3 bits of register shifted 9 bits in first word.
>>        Indicate upper/lower in 1 bit shifted 7 bits in second word.
>>        Use with `R' or `u' format.
>> -   n  `m' withouth upper/lower indication. (For M[S]ACx; 4 bits split
>> +   n  `m' without upper/lower indication. (For M[S]ACx; 4 bits split
>>        with MSB shifted 6 bits in first word and remaining 3 bits of
>>        register shifted 9 bits in first word.  No upper/lower
>>        indication is done.)  Use with `R' or `u' format.
>> @@ -854,7 +854,7 @@ fetch_arg (unsigned char *buffer,
>>  
>>  /* Check if an EA is valid for a particular code.  This is required
>>     for the EMAC instructions since the type of source address determines
>> -   if it is a EMAC-load instruciton if the EA is mode 2-5, otherwise it
>> +   if it is a EMAC-load instruction if the EA is mode 2-5, otherwise it
>>     is a non-load EMAC instruction and the bits mean register Ry.
>>     A similar case exists for the movem instructions where the register
>>     mask is interpreted differently for different EAs.  */
>> @@ -1080,7 +1080,7 @@ print_indexed (int basereg,
>>  
>>  /* Returns number of bytes "eaten" by the operand, or
>>     return -1 if an invalid operand was found, or -2 if
>> -   an opcode tabe error was found.
>> +   an opcode table error was found.
>>     ADDR is the pc for this arg to be relative to.  */
>>  
>>  static int
>> diff --git a/disas/ppc.c b/disas/ppc.c
>> index 63e97cfe1d..02be878198 100644
>> --- a/disas/ppc.c
>> +++ b/disas/ppc.c
>> @@ -5226,7 +5226,7 @@ operand_value_powerpc (const struct powerpc_operand *operand,
>>        if ((operand->flags & PPC_OPERAND_SIGNED) != 0)
>>  	{
>>  	  /* BITM is always some number of zeros followed by some
>> -	     number of ones, followed by some numer of zeros.  */
>> +	     number of ones, followed by some number of zeros.  */
>>  	  unsigned long top = operand->bitm;
>>  	  /* top & -top gives the rightmost 1 bit, so this
>>  	     fills in any trailing zeros.  */
> 
> 

Re: [PATCH V3 09/10] qapi/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the qapi folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/block-core.json | 4 ++--
>  qapi/crypto.json     | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 2d94873ca0..3c16f1e11d 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1795,7 +1795,7 @@
>  #
>  # @block-backend: corresponds to BlockBackend
>  #
> -# @block-job: corresonds to BlockJob
> +# @block-job: corresponds to BlockJob
>  #
>  # @block-driver: corresponds to BlockDriverState
>  #
> @@ -2067,7 +2067,7 @@
>  # @target: name of the destination dirty bitmap
>  #
>  # @bitmaps: name(s) of the source dirty bitmap(s) at @node and/or fully
> -#           specifed BlockDirtyBitmap elements. The latter are supported
> +#           specified BlockDirtyBitmap elements. The latter are supported
>  #           since 4.1.
>  #
>  # Since: 4.0
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index bb7930d332..2aebe6fa20 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -336,7 +336,7 @@
>  #                 written into added active keyslots
>  #
>  # @old-secret:    Optional (for deactivation only)
> -#                 If given will deactive all keyslots that
> +#                 If given will deactivate all keyslots that
>  #                 match password located in QCryptoSecret with this ID
>  #
>  # @iter-time:     Optional (for activation only)
> @@ -354,7 +354,7 @@
>  #                 keyslot to deactivate
>  #
>  # @secret:        Optional. The ID of a QCryptoSecret object providing the
> -#                 password to use to retrive current master key.
> +#                 password to use to retrieve current master key.
>  #                 Defaults to the same secret that was used to open the image
>  #
>  #
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH V3 08/10] disas/: fix some comment spelling errors

[Alex Bennée]

Laurent Vivier <laurent@vivier.eu> writes:

> Le 17/09/2020 à 10:44, Alex Bennée a écrit :
>> 
>> zhaolichang <zhaolichang@huawei.com> writes:
>> 
>>> I found that there are many spelling errors in the comments of qemu,
>>> so I used the spellcheck tool to check the spelling errors
>>> and finally found some spelling errors in the disas folder.
>>>
>>> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
>> 
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>> 
>> I suggest on your next posting you CC qemu-trivial@nongnu.org so the
>> patches can get pulled in via the trivial tree.
>
> It was.
>
> Applied to my trivial-patches branch.

I must be going blind, so it was. Thanks.

>
> Thanks,
> Laurent
>
>> 
>>> ---
>>>  disas/hppa.c | 2 +-
>>>  disas/m68k.c | 8 ++++----
>>>  disas/ppc.c  | 2 +-
>>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/disas/hppa.c b/disas/hppa.c
>>> index 2dbd1fc445..dcf9a47f34 100644
>>> --- a/disas/hppa.c
>>> +++ b/disas/hppa.c
>>> @@ -2021,7 +2021,7 @@ print_insn_hppa (bfd_vma memaddr, disassemble_info *info)
>>>  			fput_fp_reg (GET_FIELD (insn, 6, 10), info);
>>>  		      break;
>>>  
>>> -		      /* 'fA' will not generate a space before the regsiter
>>> +		      /* 'fA' will not generate a space before the register
>>>  			 name.  Normally that is fine.  Except that it
>>>  			 causes problems with xmpyu which has no FP format
>>>  			 completer.  */
>>> diff --git a/disas/m68k.c b/disas/m68k.c
>>> index 863409c67c..aefaecfbd6 100644
>>> --- a/disas/m68k.c
>>> +++ b/disas/m68k.c
>>> @@ -70,7 +70,7 @@ struct floatformat
>>>    unsigned int exp_start;
>>>    unsigned int exp_len;
>>>    /* Bias added to a "true" exponent to form the biased exponent.  It
>>> -     is intentionally signed as, otherwize, -exp_bias can turn into a
>>> +     is intentionally signed as, otherwise, -exp_bias can turn into a
>>>       very large number (e.g., given the exp_bias of 0x3fff and a 64
>>>       bit long, the equation (long)(1 - exp_bias) evaluates to
>>>       4294950914) instead of -16382).  */
>>> @@ -479,7 +479,7 @@ struct m68k_opcode_alias
>>>        and remaining 3 bits of register shifted 9 bits in first word.
>>>        Indicate upper/lower in 1 bit shifted 7 bits in second word.
>>>        Use with `R' or `u' format.
>>> -   n  `m' withouth upper/lower indication. (For M[S]ACx; 4 bits split
>>> +   n  `m' without upper/lower indication. (For M[S]ACx; 4 bits split
>>>        with MSB shifted 6 bits in first word and remaining 3 bits of
>>>        register shifted 9 bits in first word.  No upper/lower
>>>        indication is done.)  Use with `R' or `u' format.
>>> @@ -854,7 +854,7 @@ fetch_arg (unsigned char *buffer,
>>>  
>>>  /* Check if an EA is valid for a particular code.  This is required
>>>     for the EMAC instructions since the type of source address determines
>>> -   if it is a EMAC-load instruciton if the EA is mode 2-5, otherwise it
>>> +   if it is a EMAC-load instruction if the EA is mode 2-5, otherwise it
>>>     is a non-load EMAC instruction and the bits mean register Ry.
>>>     A similar case exists for the movem instructions where the register
>>>     mask is interpreted differently for different EAs.  */
>>> @@ -1080,7 +1080,7 @@ print_indexed (int basereg,
>>>  
>>>  /* Returns number of bytes "eaten" by the operand, or
>>>     return -1 if an invalid operand was found, or -2 if
>>> -   an opcode tabe error was found.
>>> +   an opcode table error was found.
>>>     ADDR is the pc for this arg to be relative to.  */
>>>  
>>>  static int
>>> diff --git a/disas/ppc.c b/disas/ppc.c
>>> index 63e97cfe1d..02be878198 100644
>>> --- a/disas/ppc.c
>>> +++ b/disas/ppc.c
>>> @@ -5226,7 +5226,7 @@ operand_value_powerpc (const struct powerpc_operand *operand,
>>>        if ((operand->flags & PPC_OPERAND_SIGNED) != 0)
>>>  	{
>>>  	  /* BITM is always some number of zeros followed by some
>>> -	     number of ones, followed by some numer of zeros.  */
>>> +	     number of ones, followed by some number of zeros.  */
>>>  	  unsigned long top = operand->bitm;
>>>  	  /* top & -top gives the rightmost 1 bit, so this
>>>  	     fills in any trailing zeros.  */
>> 
>> 


-- 
Alex Bennée