From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] TPASS in new test lib
Date: Thu, 17 Sep 2020 10:40:39 +0200 [thread overview]
Message-ID: <20200917084039.GA2352@yuki.lan> (raw)
In-Reply-To: <CY4PR13MB1175364547D2DA3A96262516FD210@CY4PR13MB1175.namprd13.prod.outlook.com>
Hi!
> That's fine. But it's probably better to avoid differences in
> test output as much as possible, when the change is so trivial. Petr seems to think
> there was a reason that the result string was changed between the old and new C library.
> If so, what is the reason? If the change is only cosmetic, then I'd argue it's worth
> being consistent, and I'll submit the patch properly. (Sorry the earlier version was
> inline in the message, rather than formatted correctly.)
I do not think that there was a strong reason for the difference apart
from an attempt to make the messages easier to read for a human reader
and to make it easier to figure out what exactly happened. The format of
the output messages was changed quite a bit in order to do that.
And as I said I do not have a strong opinion here, if you think that
this is important I'm okay with the changes.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-09-17 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 20:54 [LTP] TPASS in new test lib Bird, Tim
2020-09-16 4:50 ` Xiao Yang
2020-09-16 7:11 ` Petr Vorel
2020-09-16 8:54 ` Cyril Hrubis
2020-09-16 16:29 ` Bird, Tim
2020-09-17 8:40 ` Cyril Hrubis [this message]
2020-09-18 11:45 ` Cyril Hrubis
2020-09-17 10:45 ` Richard Palethorpe
2020-09-17 11:23 ` Petr Vorel
2020-09-17 11:33 ` Petr Vorel
2020-09-17 12:49 ` Cyril Hrubis
2020-09-16 8:43 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917084039.GA2352@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.