From: Michal Hocko <mhocko@suse.com>
To: Vijay Balakrishna <vijayb@linux.microsoft.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Oleg Nesterov <oleg@redhat.com>, Song Liu <songliubraving@fb.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Allen Pais <apais@microsoft.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user
Date: Thu, 17 Sep 2020 11:34:13 +0200 [thread overview]
Message-ID: <20200917093413.GB29887@dhcp22.suse.cz> (raw)
In-Reply-To: <20200917092805.GA29887@dhcp22.suse.cz>
On Thu 17-09-20 11:28:06, Michal Hocko wrote:
> On Wed 16-09-20 23:39:39, Vijay Balakrishna wrote:
> > set_recommended_min_free_kbytes need to honor min_free_kbytes set by the
> > user. Post start-of-day THP enable or memory hotplug operations can
> > lose user specified min_free_kbytes, in particular when it is higher than
> > calculated recommended value.
>
> I was about to recommend a more detailed explanation when I have
> realized that this patch is not really needed after all. Unless I am
> missing something.
>
> init_per_zone_wmark_min ignores the newly calculated min_free_kbytes if
> it is lower than user_min_free_kbytes. So calculated min_free_kbytes >=
> user_min_free_kbytes.
>
> Except for value clamping when the value is reduced and this likely
> needs fixing. But set_recommended_min_free_kbytes should be fine.
Something like
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index fab5e97dc9ca..69731b19d9bf 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -7875,9 +7875,9 @@ int __meminit init_per_zone_wmark_min(void)
if (new_min_free_kbytes > user_min_free_kbytes) {
min_free_kbytes = new_min_free_kbytes;
if (min_free_kbytes < 128)
- min_free_kbytes = 128;
+ min_free_kbytes = max(128, user_min_free_kbytes);
if (min_free_kbytes > 262144)
- min_free_kbytes = 262144;
+ min_free_kbytes = max(262144, user_min_free_kbytes);
} else {
pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n",
new_min_free_kbytes, user_min_free_kbytes);
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-09-17 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 6:39 [v4] mm: khugepaged: avoid overriding min_free_kbytes set by user Vijay Balakrishna
2020-09-17 9:28 ` Michal Hocko
2020-09-17 9:34 ` Michal Hocko [this message]
2020-09-17 17:27 ` Vijay Balakrishna
2020-09-17 17:52 ` Michal Hocko
2020-09-17 18:16 ` Vijay Balakrishna
2020-09-18 5:56 ` Michal Hocko
2020-09-21 19:07 ` Vijay Balakrishna
2020-09-22 7:07 ` Kirill A. Shutemov
2020-09-22 10:07 ` Michal Hocko
2020-09-22 16:10 ` Vijay Balakrishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917093413.GB29887@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apais@microsoft.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=songliubraving@fb.com \
--cc=vijayb@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.