From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B99C433E2 for ; Thu, 17 Sep 2020 09:54:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99F8120838 for ; Thu, 17 Sep 2020 09:54:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G5eUcMix" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726543AbgIQJyz (ORCPT ); Thu, 17 Sep 2020 05:54:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbgIQJyz (ORCPT ); Thu, 17 Sep 2020 05:54:55 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA245C06174A for ; Thu, 17 Sep 2020 02:54:54 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id j7so839271plk.11 for ; Thu, 17 Sep 2020 02:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PJlBiIeS5Wdy2999YEJLifVI7R/wk8pty4fRR2lBgRs=; b=G5eUcMixy97pPQRUaJlNCnHmF1P60hPgz2mFAP2BIXDpYT4BtxuJZ5UPzi8yFOlFNE Dz8ouauaaFmcaB3SHVoxU/TaIi829YIaHyMBX31XgvQkQNFCpYA0+wooNtQNBiGkpKRZ jqJKXZE5if2AYb+oKIBZfs1Bs0KgrkaKWGK+9uzU9wRYYl7rGNIGrUzX6hKpcLMqY9/X BcYB7f0hMmHpqlmGlJm+XV4oL3DwqPocu2PAVBrBchDHKLJXnpen7XzWFlGSMlt2symy 4bOcvaUGowUIwKl3vcp2csFrTzXrxIsuhieHLrOh3vbfVbhAnWwJ1C3qYxbvE1cFnXdK i/4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PJlBiIeS5Wdy2999YEJLifVI7R/wk8pty4fRR2lBgRs=; b=hj0Y05YV54mwrupRwxsfhgS+25yJ3KQ+CjOytI5lHA64n/mBVlzOvEIoZebJMy9h13 oZVVhDkl8WRh2TzOIYBP4lZZMHgrW8OfFSFT5VgPIJ6c0E6mlyMqtQYjLM8DQxYYJs7W g/pre7ZNvVhZgxYvde6xArzyBuKYmuxGa4xImbF2aGpZTAyBi01vVsaBPyDjKLrixETt 7WNbwzh5At3SqtZmBuoNmLXszlSxtzPNZmVMQlUyY2h/UYX/nLNwdfYhpbL3h2aiBjfL j7Zk2DkyJXTSSCiAi9bu6aKpewWVWdtgXvbwprs0CEOad/8UMUul3EkM+AqymtIDSe0A AunQ== X-Gm-Message-State: AOAM533+FwMphs5it+6J20TzJaLir3yb/g6dLUZ5Bfj06wHi961+WQDI Av8Hcim+roNRR/QVtPQQPi4= X-Google-Smtp-Source: ABdhPJzuOpGFgvMt8I8gvUiYn7kWUfZIBqIbyo3e/S95bnvOZqn2ju/2Bwet3gGY2zXMf+u8ss2D8w== X-Received: by 2002:a17:90b:891:: with SMTP id bj17mr4239804pjb.11.1600336494426; Thu, 17 Sep 2020 02:54:54 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id c20sm5411643pfc.209.2020.09.17.02.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 02:54:53 -0700 (PDT) Date: Thu, 17 Sep 2020 18:54:50 +0900 From: Sergey Senozhatsky To: Leo Yan Cc: Sergey Senozhatsky , Arnaldo Carvalho de Melo , Mark Rutland , Peter Zijlstra , Will Deacon , John Garry , Mathieu Poirier , Namhyung Kim , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 Message-ID: <20200917095450.GA3049@jagdpanzerIV.localdomain> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917084744.GB12548@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917084744.GB12548@leoy-ThinkPad-X240s> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/09/17 16:47), Leo Yan wrote: [..] > > +static void event_get_key(struct evsel *evsel, > > + struct perf_sample *sample, > > + struct event_key *key) > > +{ > > + key->info = 0; > > + key->key = perf_evsel__intval(evsel, sample, kvm_exit_reason); > > Now the perf/core branch doesn't have API perf_evsel__intval(), and it > has been replaced with evsel__intval(); so please > > s/perf_evsel__intval/evsel__intval ACK. The kernel I'm using still have perf_evsel__intval(). > > + if (key->key == ARM_EXCEPTION_TRAP) { > > + key->key = perf_evsel__intval(evsel, sample, > > Ditto. ACK. Sorry about that. > Otherwise, this patch is good for me and I have tested this patch with > below commands: > > $ perf kvm stat record > $ perf kvm stat report "perf kvm stat live" should also work. > Reviewed-by: Leo Yan > Tested-by: Leo Yan Thanks! -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE02C433E2 for ; Thu, 17 Sep 2020 09:56:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 586A120770 for ; Thu, 17 Sep 2020 09:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zFcixdmm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G5eUcMix" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 586A120770 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3otsESkLvQ2aS7ltj/GfefNWl8og9lsdrjFe8i1meuM=; b=zFcixdmmWvtGfVL2C3jruZwcl +UbQpfNqYOwoJ64WT08FanitfcucdPpwhKsjJnuHnAzz55kDVvwgcWdFapckEGHAtLiKJffHl8y2U 0UZ+RiYEXmxjAzWQuAQStbiTb5EUkd5RFX+Nn8pk6Zu3TrHbEBqkG+Cb+BUknAT1RNty/tiMBIESa YEI6VHmapq4DstibAiXtOBWHzjCq43moB3+C2xn1TyMR+Pp2UskZAlfwBFXxwXjUuWNXgpBoNudsG cHapSbC1youX0wvLx5iT1r1pS58nZX9D11w8apmy4A0dA8k0Yjp/F7eUV+WIekbhgBULLfLjOqKdp J2wGnU2qg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIqd0-0006bI-NR; Thu, 17 Sep 2020 09:54:58 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIqcy-0006aM-Gr for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 09:54:57 +0000 Received: by mail-pl1-x641.google.com with SMTP id u9so856433plk.4 for ; Thu, 17 Sep 2020 02:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PJlBiIeS5Wdy2999YEJLifVI7R/wk8pty4fRR2lBgRs=; b=G5eUcMixy97pPQRUaJlNCnHmF1P60hPgz2mFAP2BIXDpYT4BtxuJZ5UPzi8yFOlFNE Dz8ouauaaFmcaB3SHVoxU/TaIi829YIaHyMBX31XgvQkQNFCpYA0+wooNtQNBiGkpKRZ jqJKXZE5if2AYb+oKIBZfs1Bs0KgrkaKWGK+9uzU9wRYYl7rGNIGrUzX6hKpcLMqY9/X BcYB7f0hMmHpqlmGlJm+XV4oL3DwqPocu2PAVBrBchDHKLJXnpen7XzWFlGSMlt2symy 4bOcvaUGowUIwKl3vcp2csFrTzXrxIsuhieHLrOh3vbfVbhAnWwJ1C3qYxbvE1cFnXdK i/4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PJlBiIeS5Wdy2999YEJLifVI7R/wk8pty4fRR2lBgRs=; b=cjeo+CMJr49RGNbJNoL7kIsJID/eyM0nSSCjOCfbzQOclvOMnJaHtv1ShFJVxZsTCe OpDdk1MN/MNrHwRqgJ4qJwljJqIYSpxv50RhWcVmG2GoIaf5eCxsiTryVgQtjIgpS3e9 HOLla2K6e9jfPYY0QxEa8uAtfW2t7NEZFZhGTnR4j3+laA7t9hn6OX1+0Xk7wADuKqOQ G5pf5pvV3TtZUUKjNLhnxmy5/GnUgPGXQq1zEa/qTu/RC0TjQy/iHpr1w590mW3Um1WS uH1mVV9k3qtr6k4pQtsbVXtvtVV3gCOJBcaKv013JbrLIOdD8QoN0FsAG20H2YGBWJn4 MdrA== X-Gm-Message-State: AOAM5326zVr8TTHQYvfAexserwV1ZjF3QJr3/fULehcXfjQvdroJaA9R +0HmeOl/rQAqfj6h3QWzMDU= X-Google-Smtp-Source: ABdhPJzuOpGFgvMt8I8gvUiYn7kWUfZIBqIbyo3e/S95bnvOZqn2ju/2Bwet3gGY2zXMf+u8ss2D8w== X-Received: by 2002:a17:90b:891:: with SMTP id bj17mr4239804pjb.11.1600336494426; Thu, 17 Sep 2020 02:54:54 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id c20sm5411643pfc.209.2020.09.17.02.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 02:54:53 -0700 (PDT) Date: Thu, 17 Sep 2020 18:54:50 +0900 From: Sergey Senozhatsky To: Leo Yan Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 Message-ID: <20200917095450.GA3049@jagdpanzerIV.localdomain> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917084744.GB12548@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917084744.GB12548@leoy-ThinkPad-X240s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_055456_611378_DD0A1582 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Mathieu Poirier , Peter Zijlstra , John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Sergey Senozhatsky , Suleiman Souhlal , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On (20/09/17 16:47), Leo Yan wrote: [..] > > +static void event_get_key(struct evsel *evsel, > > + struct perf_sample *sample, > > + struct event_key *key) > > +{ > > + key->info = 0; > > + key->key = perf_evsel__intval(evsel, sample, kvm_exit_reason); > > Now the perf/core branch doesn't have API perf_evsel__intval(), and it > has been replaced with evsel__intval(); so please > > s/perf_evsel__intval/evsel__intval ACK. The kernel I'm using still have perf_evsel__intval(). > > + if (key->key == ARM_EXCEPTION_TRAP) { > > + key->key = perf_evsel__intval(evsel, sample, > > Ditto. ACK. Sorry about that. > Otherwise, this patch is good for me and I have tested this patch with > below commands: > > $ perf kvm stat record > $ perf kvm stat report "perf kvm stat live" should also work. > Reviewed-by: Leo Yan > Tested-by: Leo Yan Thanks! -ss _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel