From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F40FC2BBD1 for ; Thu, 17 Sep 2020 12:46:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E083E21582 for ; Thu, 17 Sep 2020 12:46:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="bMnfncX2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726793AbgIQMqd (ORCPT ); Thu, 17 Sep 2020 08:46:33 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:42774 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727003AbgIQMnP (ORCPT ); Thu, 17 Sep 2020 08:43:15 -0400 X-Greylist: delayed 377 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 08:43:09 EDT Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08HCaTQ6032716; Thu, 17 Sep 2020 07:36:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600346189; bh=vYoWYgW6dB3En0e3iIC586CdvGCOhfHOK4t+npUDGJM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=bMnfncX2TGo97mlzV5RCdKdsS0EXF4SE6ZZBh8o8TLKoPlVKdoFE0DYvg4vWG8RZh Hpn/VJq4mBNNMeVp8HEK+CzhYGeMEdXBlOQbTsqBLzKWoiWFk+YDjZcFVeiNWQ/Qzu Gpo6jV33Q6PeANzA7HtUhrTENZWZymF7ToInMbis= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08HCaT6V015109 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Sep 2020 07:36:29 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 17 Sep 2020 07:36:29 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 17 Sep 2020 07:36:29 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08HCaTQu011989; Thu, 17 Sep 2020 07:36:29 -0500 Date: Thu, 17 Sep 2020 07:36:29 -0500 From: Nishanth Menon To: Kishon Vijay Abraham I CC: Peter Rosin , Roger Quadros , , , , , , Subject: Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines Message-ID: <20200917123629.ve77q7koqjlhgdhc@akan> References: <20200915112038.30219-1-rogerq@ti.com> <20200915112038.30219-2-rogerq@ti.com> <20200916154536.m552ft2jzfsaeokr@akan> <8a27f8f3-20c4-f72c-b683-81153107d867@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8a27f8f3-20c4-f72c-b683-81153107d867@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15:47-20200917, Kishon Vijay Abraham I wrote: [..] > > Thanks, good point. I am not sure if WIZ should even be used.. It is > > a TI internal prefix for various serdes solutions, but I agree that > > SERDES0 is too generic a terminology. That said, we should cleanup > > include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing > > j7200 changes. > > WIZ is defined in public TRM (https://www.ti.com/lit/pdf/spruiu1). > " Maybe give the TRM team a feedback to use a little more human readable naming? if I just ctrl+f "wiz" in the 10,000 page trm the first match is: "CA bits can be swizzled between any bit positions via the DDRSS_PHY_1053[23-0] PHY_ADR_ADDR_SEL_0 field" (it is not even in the table of contents?) However, if I search for serdes, and then go down to page 7773, "WIZ: The WIZ acts as a wrapper for the SerDes, and can both send control signals to and report status signals from the SerDes, and muxes SerDes to peripherals" just call it ti-k3-serdes-mux (since there are other TI serdes muxes..)? You dont want to be on the brunt of something like [1] caused by, your's truely.. Also this is never going to scale with the number of devices we are spinning out.. one header per SoC? makes no sense to me. [1] https://groups.google.com/forum/#!msg/linux.kernel/fcntv48yoOc/35bAdI1eaiUJ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2728CC433E2 for ; Thu, 17 Sep 2020 12:38:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C46632087D for ; Thu, 17 Sep 2020 12:38:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zTbdj36x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="bMnfncX2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C46632087D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Nj4HIgwkgxx5wYsK7AkErsZrP40KtB7KFx/9sXXwG0w=; b=zTbdj36x41A1qQTz4HEl+/K5V qo23lNtVAPnG+d2+Lr8VtDLwHk7t9yvy+dExsr5vCXfpj5oGfNJTAkuBWr63WjAYvUow9ZqvyN7B7 Bj05g051BgqDDyS1VqPL9/usDUDnQiqZ4IC4xmCt++99wRSoL99d7aZ/AkmmEIIsXKyE+1Qb6HB2F /GSSpe4LKvLDAR6kdwi09AMhLqlYxdQ2e8OJKN26f1PWwi05azgOzS1dTrOjcgT1LeWfR2Md6ufof Qz8j0LyRf3Y45qhGeKQ8vsy61XN/ZA7xT5bHLFZqRGIxcS+Myw1M3ScuVg4Ba88F+wq084xR2lq1m x8xsNJ1Sw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIt9R-0004oh-IV; Thu, 17 Sep 2020 12:36:37 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIt9O-0004nz-RH for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 12:36:35 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08HCaTQ6032716; Thu, 17 Sep 2020 07:36:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600346189; bh=vYoWYgW6dB3En0e3iIC586CdvGCOhfHOK4t+npUDGJM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=bMnfncX2TGo97mlzV5RCdKdsS0EXF4SE6ZZBh8o8TLKoPlVKdoFE0DYvg4vWG8RZh Hpn/VJq4mBNNMeVp8HEK+CzhYGeMEdXBlOQbTsqBLzKWoiWFk+YDjZcFVeiNWQ/Qzu Gpo6jV33Q6PeANzA7HtUhrTENZWZymF7ToInMbis= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08HCaT6V015109 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Sep 2020 07:36:29 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 17 Sep 2020 07:36:29 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 17 Sep 2020 07:36:29 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08HCaTQu011989; Thu, 17 Sep 2020 07:36:29 -0500 Date: Thu, 17 Sep 2020 07:36:29 -0500 From: Nishanth Menon To: Kishon Vijay Abraham I Subject: Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines Message-ID: <20200917123629.ve77q7koqjlhgdhc@akan> References: <20200915112038.30219-1-rogerq@ti.com> <20200915112038.30219-2-rogerq@ti.com> <20200916154536.m552ft2jzfsaeokr@akan> <8a27f8f3-20c4-f72c-b683-81153107d867@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a27f8f3-20c4-f72c-b683-81153107d867@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_083634_975747_E1127E07 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, robh+dt@kernel.org, Peter Rosin , linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15:47-20200917, Kishon Vijay Abraham I wrote: [..] > > Thanks, good point. I am not sure if WIZ should even be used.. It is > > a TI internal prefix for various serdes solutions, but I agree that > > SERDES0 is too generic a terminology. That said, we should cleanup > > include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing > > j7200 changes. > > WIZ is defined in public TRM (https://www.ti.com/lit/pdf/spruiu1). > " Maybe give the TRM team a feedback to use a little more human readable naming? if I just ctrl+f "wiz" in the 10,000 page trm the first match is: "CA bits can be swizzled between any bit positions via the DDRSS_PHY_1053[23-0] PHY_ADR_ADDR_SEL_0 field" (it is not even in the table of contents?) However, if I search for serdes, and then go down to page 7773, "WIZ: The WIZ acts as a wrapper for the SerDes, and can both send control signals to and report status signals from the SerDes, and muxes SerDes to peripherals" just call it ti-k3-serdes-mux (since there are other TI serdes muxes..)? You dont want to be on the brunt of something like [1] caused by, your's truely.. Also this is never going to scale with the number of devices we are spinning out.. one header per SoC? makes no sense to me. [1] https://groups.google.com/forum/#!msg/linux.kernel/fcntv48yoOc/35bAdI1eaiUJ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel