From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D729C43461 for ; Thu, 17 Sep 2020 14:56:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6457206E6 for ; Thu, 17 Sep 2020 14:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbgIQO4g (ORCPT ); Thu, 17 Sep 2020 10:56:36 -0400 Received: from mga01.intel.com ([192.55.52.88]:34475 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727215AbgIQOtx (ORCPT ); Thu, 17 Sep 2020 10:49:53 -0400 IronPort-SDR: Ce5CTOz0wjN8Z78iVc7HkP0BLzzbxDcuTMJ05NWKsg6IspgyxBqLXjtYbPvUtVjJ/COP2UU1QS 3QUxacFGU4Ig== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="177804239" X-IronPort-AV: E=Sophos;i="5.77,437,1596524400"; d="scan'208";a="177804239" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 07:44:21 -0700 IronPort-SDR: 2PjTpGPUJrmk/qAGxhB331O0Aj/pPwhH4tXe00zQmSC7rMAaOijzfKiwbCewdba0OWZ8HRpvcR 00Ep3pHxDpBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,437,1596524400"; d="scan'208";a="336439709" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 17 Sep 2020 07:44:17 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kIv8v-00HLiv-II; Thu, 17 Sep 2020 17:44:13 +0300 Date: Thu, 17 Sep 2020 17:44:13 +0300 From: Andy Shevchenko To: Dan Scally Cc: Sakari Ailus , yong.zhi@intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, gregkh@linuxfoundation.org, davem@davemloft.net, robh@kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, jorhand@linux.microsoft.com, kitakar@gmail.com, kieran.bingham@ideasonboard.com Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms Message-ID: <20200917144413.GN3956970@smile.fi.intel.com> References: <20200916213618.8003-1-djrscally@gmail.com> <20200917103343.GW26842@paasikivi.fi.intel.com> <8133a57d-ab4c-dccd-4325-9b10e7805648@gmail.com> <20200917124514.GK3956970@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 02:36:22PM +0100, Dan Scally wrote: > On 17/09/2020 13:45, Andy Shevchenko wrote: > > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: > >> On 17/09/2020 11:33, Sakari Ailus wrote: > > I will do better review for next version, assuming you will Cc reviewers and > > TWIMC people. Below is like small part of comments I may give to the code. > TWIMC? Missed this. To Whom It May Concern. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497CCC43461 for ; Thu, 17 Sep 2020 14:44:26 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E101F20684 for ; Thu, 17 Sep 2020 14:44:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E101F20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 6CE3787870; Thu, 17 Sep 2020 14:44:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a7VYfmOl7YAF; Thu, 17 Sep 2020 14:44:24 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id E9FD88785D; Thu, 17 Sep 2020 14:44:24 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id A9D091BF399 for ; Thu, 17 Sep 2020 14:44:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A59F18785D for ; Thu, 17 Sep 2020 14:44:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XtMWjg2YGoFj for ; Thu, 17 Sep 2020 14:44:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by whitealder.osuosl.org (Postfix) with ESMTPS id 06AE6877AE for ; Thu, 17 Sep 2020 14:44:22 +0000 (UTC) IronPort-SDR: Dr1imvJ42gKYq09lfjna4c3sN7yBi5GDyoKgOtVKiXX+xdTKrQCMlbUr+3Z1RkoZGAS1KXdffl SCe/OgFANZgw== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="139713531" X-IronPort-AV: E=Sophos;i="5.77,437,1596524400"; d="scan'208";a="139713531" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 07:44:21 -0700 IronPort-SDR: 2PjTpGPUJrmk/qAGxhB331O0Aj/pPwhH4tXe00zQmSC7rMAaOijzfKiwbCewdba0OWZ8HRpvcR 00Ep3pHxDpBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,437,1596524400"; d="scan'208";a="336439709" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 17 Sep 2020 07:44:17 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kIv8v-00HLiv-II; Thu, 17 Sep 2020 17:44:13 +0300 Date: Thu, 17 Sep 2020 17:44:13 +0300 From: Andy Shevchenko To: Dan Scally Subject: Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms Message-ID: <20200917144413.GN3956970@smile.fi.intel.com> References: <20200916213618.8003-1-djrscally@gmail.com> <20200917103343.GW26842@paasikivi.fi.intel.com> <8133a57d-ab4c-dccd-4325-9b10e7805648@gmail.com> <20200917124514.GK3956970@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, robh@kernel.org, jorhand@linux.microsoft.com, linux-media@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com, kitakar@gmail.com, Sakari Ailus , bingbu.cao@intel.com, mchehab@kernel.org, davem@davemloft.net, tian.shu.qiu@intel.com, yong.zhi@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Sep 17, 2020 at 02:36:22PM +0100, Dan Scally wrote: > On 17/09/2020 13:45, Andy Shevchenko wrote: > > On Thu, Sep 17, 2020 at 11:52:28AM +0100, Dan Scally wrote: > >> On 17/09/2020 11:33, Sakari Ailus wrote: > > I will do better review for next version, assuming you will Cc reviewers and > > TWIMC people. Below is like small part of comments I may give to the code. > TWIMC? Missed this. To Whom It May Concern. -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel