From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26627C43461 for ; Thu, 17 Sep 2020 19:55:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C756B206DB for ; Thu, 17 Sep 2020 19:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600372557; bh=OAcKwoDjKOPDSdsU+T5CHJlT04hOipONnzcreUUefdQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=o7Q9Lx0Pr2Wn/qYHwBovNZFjnqUFt+9LcVBRYLfzKkfJh7fR1KqqxUWf55B9fPFsn ack8WghJ720/KfQNXIEcUGVnBXZwmzdnxT0czxjmbsycu9VZbqKWWE55Mx4O7nc3nb /Uuwsd+FYa4r/ubAkvo8eWOunseB1Hct9+KHyS6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbgIQTz4 (ORCPT ); Thu, 17 Sep 2020 15:55:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:50530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbgIQO4E (ORCPT ); Thu, 17 Sep 2020 10:56:04 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE5672223D; Thu, 17 Sep 2020 14:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600353973; bh=OAcKwoDjKOPDSdsU+T5CHJlT04hOipONnzcreUUefdQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yWy7RkdPe2vMlXwdX1Y/RQ2zjLDxFcRBEsuaKQZvJX3dOWfIkCS5xpbmT6p4iPv0C IoTIVbpxIWCpV06ETCvwRqCPTpeKEVv26wRsDCmwk8wrMBWl7Gp3farhrExatEFEK7 MEQHXdQwx1wFaW71p/2vxqBvm+1FeKyUh0RxY6aI= Date: Thu, 17 Sep 2020 16:46:45 +0200 From: Greg Kroah-Hartman To: Shuah Khan Cc: Prateek Sood , Takashi Iwai , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, ben.hutchings@codethink.co.uk, lkft-triage@lists.linaro.org, pavel@denx.de, stable@vger.kernel.org Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review Message-ID: <20200917144645.GA275135@kroah.com> References: <20200915140653.610388773@linuxfoundation.org> <8277900f-d300-79fa-eac7-096686a6fbc3@linuxfoundation.org> <20200916062958.GH142621@kroah.com> <69e7c908-4332-91fd-bdb2-6be19fcbf126@linuxfoundation.org> <20200916152629.GD3018065@kroah.com> <09de87b0-8055-26ef-cc31-0c63e63e5d2a@linuxfoundation.org> <20200916172529.GA3056792@kroah.com> <9365ff94-2a28-cc5f-7487-a6d8d42de302@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9365ff94-2a28-cc5f-7487-a6d8d42de302@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 08:34:58AM -0600, Shuah Khan wrote: > On 9/16/20 11:25 AM, Greg Kroah-Hartman wrote: > > On Wed, Sep 16, 2020 at 09:34:52AM -0600, Shuah Khan wrote: > > > On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote: > > > > On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote: > > > > > On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote: > > > > > > On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote: > > > > > > > On 9/15/20 3:06 PM, Shuah Khan wrote: > > > > > > > > On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote: > > > > > > > > > This is the start of the stable review cycle for the 5.8.10 release. > > > > > > > > > There are 177 patches in this series, all will be posted as a response > > > > > > > > > to this one.  If anyone has any issues with these being applied, please > > > > > > > > > let me know. > > > > > > > > > > > > > > > > > > Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000. > > > > > > > > > Anything received after that time might be too late. > > > > > > > > > > > > > > > > > > The whole patch series can be found in one patch at: > > > > > > > > >     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz > > > > > > > > > > > > > > > > > > or in the git tree and branch at: > > > > > > > > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > > > > > > > linux-5.8.y > > > > > > > > > and the diffstat can be found below. > > > > > > > > > > > > > > > > > > thanks, > > > > > > > > > > > > > > > > > > greg k-h > > > > > > > > > > > > > > > > > > > > > > > > > Compiled and booted fine. wifi died: > > > > > > > > > > > > > > > > ath10k_pci 0000:02:00.0: could not init core (-110) > > > > > > > > ath10k_pci 0000:02:00.0: could not probe fw (-110) > > > > > > > > > > > > > > > > This is regression from 5.8.9 and 5.9-rc5 works just fine. > > > > > > > > > > > > > > > > I will try to bisect later this evening to see if I can isolate the > > > > > > > > commit. > > > > > > > > > > > > > > > > > > > > > > The following commit is what caused ath10k_pci driver problem > > > > > > > that killed wifi. > > > > > > > > > > > > > > Prateek Sood > > > > > > > firmware_loader: fix memory leak for paged buffer > > > > > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.8.y&id=ec0a59266c9c9f46037efd3dcc0323973e102271 > > > > > > > > > > > > Ugh, that's not good, is this also a problem in 5.9-rc5 as well? For > > > > > > reference, this is commit 4965b8cd1bc1 ("firmware_loader: fix memory > > > > > > leak for paged buffer") in Linus's tree. > > > > > > > > > > > > > > > > I am not seeing this on Linux 5.9-rc5 for sure. > > > > > > > > > > > And it should be showing up in 5.4.y at the moment too, as this patch is > > > > > > in that tree right now... > > > > > > > > > > > > > > > > I don't see this patch in 4.19.146-rc1 > > > > > > > > It's not there, it's in 5.4.66-rc1, which worked for you somehow, right? > > > > > > > > > Linus's tree works for with this patch in. I compared the two files > > > > > for differences in commit between Linus's tree and 5.8.10-rc1 > > > > > > > > > > Couldn't find anything obvious. > > > > > > > > Again, really odd... > > > > > > > > I don't have a problem dropping it, but I should drop it from both 5.4.y > > > > and 5.8.y, right? > > > > > > > > > > Sorry. Yes. Dropping from 5.8 and 5.4 would be great until we figure out > > > why this patch causes problems. > > > > > > I will continue debugging and let you know what I find. > > > > With this it boots and wifi is good for me. I am very puzzled by why > this made a difference to make sure I am not narrowing in on the wrong > patch. > > Compiled and booted on my test system. No dmesg regressions. > > Tested-by: Shuah Khan Great, thanks for testing them all and letting me know. greg k-h