From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3 v4] package/qt5/qt5webengine: fix ffmpeg/codec/alsa option handling for latest
Date: Thu, 17 Sep 2020 14:55:51 +0200 [thread overview]
Message-ID: <20200917145551.3f4a7187@windsurf.hq.k.grp> (raw)
In-Reply-To: <73c8adc83c7e856136f5eacd8aab44631b0a64cc.1600290685.git.yann.morin.1998@free.fr>
Hello,
On Wed, 16 Sep 2020 23:11:32 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
> index 9101f35937..5df6942977 100644
> --- a/package/qt5/qt5webengine/qt5webengine.mk
> +++ b/package/qt5/qt5webengine/qt5webengine.mk
> @@ -29,16 +29,16 @@ endif
>
> QT5WEBENGINE_DEPENDENCIES += host-libpng host-libnss libnss
>
> -QT5WEBENGINE_CONF_OPTS += WEBENGINE_CONFIG+=use_system_ffmpeg
> +QT5WEBENGINE_CONF_OPTS = -webengine-ffmpeg
>
> ifeq ($(BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS),y)
> -QT5WEBENGINE_CONF_OPTS += WEBENGINE_CONFIG+=use_proprietary_codecs
> +QT5WEBENGINE_CONF_OPTS += -webengine-proprietary-codecs
> endif
>
> ifeq ($(BR2_PACKAGE_QT5WEBENGINE_ALSA),y)
> QT5WEBENGINE_DEPENDENCIES += alsa-lib
> else
> -QT5WEBENGINE_CONF_OPTS += QT_CONFIG-=alsa
> +QT5WEBENGINE_CONF_OPTS += -no-webengine-alsa
> endif
In the original patch, there was a "--" that was added to separate
these webengine options from the main options. You have not kept that.
Are you sure this is OK ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-17 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 21:11 [Buildroot] [PATCH 0/3 v4] package/qt5/qt5webengine: fix options and dependencies (branch yem/qt5webengine-options) Yann E. MORIN
2020-09-16 21:11 ` [Buildroot] [PATCH 1/3 v4] package/qt5/qt5webengine: fix ffmpeg/codec/alsa option handling for latest Yann E. MORIN
2020-09-17 12:55 ` Thomas Petazzoni [this message]
2020-09-17 15:39 ` Yann E. MORIN
2020-09-17 17:15 ` Peter Seiderer
2020-09-17 19:23 ` Nathan Ford
2020-09-17 21:08 ` Yann E. MORIN
2020-09-16 21:11 ` [Buildroot] [PATCH 2/3 v4] package/qt5/qt5webengine: ffmpeg supports needs webp mux Yann E. MORIN
2020-09-16 21:11 ` [Buildroot] [PATCH 3/3 v4] package/qt5/qt5webengine: fix build dependencies for autodetected packages Yann E. MORIN
2020-09-17 18:51 ` Thomas Petazzoni
2020-09-17 19:22 ` Nathan Ford
2020-09-17 20:07 ` Thomas Petazzoni
[not found] ` <20200918223027.74a2ea7c@gmx.net>
2020-09-18 20:33 ` Peter Seiderer
2021-01-11 22:24 ` [Buildroot] [PATCH 0/3 v4] package/qt5/qt5webengine: fix options and dependencies (branch yem/qt5webengine-options) Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917145551.3f4a7187@windsurf.hq.k.grp \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.