All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Denys Dmytriyenko" <denis@denix.org>
To: Nathan Dunne <Nathan.Dunne@arm.com>
Cc: meta-arm@lists.yoctoproject.org, nd@arm.com
Subject: Re: [meta-arm] [PATCH] arm-bsp/u-boot: fix THISDIR name collision in u-boot_%.bbappend
Date: Thu, 17 Sep 2020 12:44:43 -0400	[thread overview]
Message-ID: <20200917164443.GA19155@denix.org> (raw)
In-Reply-To: <20200917095817.27331-1-Nathan.Dunne@arm.com>

On Thu, Sep 17, 2020 at 09:58:17AM +0000, Nathan Dunne wrote:
> Renamed ${THISDIR} user defined variable to ${THIS_DIR}, to prevent
> it from breaking ${THISDIR} macro in subsequent u-boot .bbappend files
> 
> Change-Id: I4473ee5c3ac5c0aea9310557294cc9757579bdf1
> Issue-Id: SCM-1302
> Signed-off-by: Nathan Dunne <Nathan.Dunne@arm.com>
> ---
>  meta-arm-bsp/recipes-bsp/u-boot/u-boot_%.bbappend | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arm-bsp/recipes-bsp/u-boot/u-boot_%.bbappend b/meta-arm-bsp/recipes-bsp/u-boot/u-boot_%.bbappend
> index bf57242..5fc3723 100644
> --- a/meta-arm-bsp/recipes-bsp/u-boot/u-boot_%.bbappend
> +++ b/meta-arm-bsp/recipes-bsp/u-boot/u-boot_%.bbappend
> @@ -1,7 +1,7 @@
>  # Machine specific u-boot
>  
> -THISDIR := "${THISDIR}"
> -FILESEXTRAPATHS_prepend = "${THISDIR}/files/:${THISDIR}/${BP}:"
> +THIS_DIR := "${THISDIR}"
> +FILESEXTRAPATHS_prepend = "${THIS_DIR}/files/:${THIS_DIR}/${BP}:"
>  FILESEXTRAPATHS_prepend_fvp-base := "${THISDIR}/files/fvp-common:"
>  FILESEXTRAPATHS_prepend_foundation-armv8 := "${THISDIR}/files/fvp-common:"

Why not make these 3 lines above that prepend to FILESEXTRAPATHS consistent?


>  
> -- 
> 2.17.1
> 

> 
> 
> 


  parent reply	other threads:[~2020-09-17 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  9:58 [PATCH] arm-bsp/u-boot: fix THISDIR name collision in u-boot_%.bbappend Nathan.Dunne
2020-09-17 10:05 ` Diego Sueiro
2020-09-17 16:44 ` Denys Dmytriyenko [this message]
2020-09-18  8:24   ` Nathan Dunne
2020-09-21 16:38 ` [meta-arm] " Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917164443.GA19155@denix.org \
    --to=denis@denix.org \
    --cc=Nathan.Dunne@arm.com \
    --cc=meta-arm@lists.yoctoproject.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.