From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A75C433E2 for ; Thu, 17 Sep 2020 18:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA19E221F1 for ; Thu, 17 Sep 2020 18:29:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="rn/0rGKk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726583AbgIQS2X (ORCPT ); Thu, 17 Sep 2020 14:28:23 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:38254 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbgIQSUx (ORCPT ); Thu, 17 Sep 2020 14:20:53 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HIDhkB169609; Thu, 17 Sep 2020 18:19:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=SwLi/6+yIemKmxVt8jY0w/5saPlf+DraCmAV7vNC3mk=; b=rn/0rGKk7hRH5Oz+NvkZ+9aL3QmCoRR+30c/FFMsk03I/tfw5IJ3hpLjS0PzVkRN2920 QUk+qdgp6i+T3b9vAeRG+TyzV8yYVrMFsw08kI7RAbLqH7mBJiAHSPXXKqnfOUPALcfk QhfXs3a9VqIDk2DXbQtKomawciQ3eRscx3hR2mULaynTp0/CjbxcBCMQSSwnwmLKF1/l yjZQAqES0am4LszjGQ5E7V3PXSx7IltfZJ3hLPL7icR4qgkvs4w9xkqcDL1Uvx9Ra0lI 9f8aK0LQcyQVpNxFzo5G+tVxDhH7zJ3+gT2SlOP27FtHkvLZs0xkUwSthjVY9CGoRc3G xA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 33gnrrb1aq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Sep 2020 18:19:00 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HIA6Ll055730; Thu, 17 Sep 2020 18:18:59 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 33khpnf13v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Sep 2020 18:18:59 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08HIIwlH030076; Thu, 17 Sep 2020 18:18:58 GMT Received: from localhost (/10.159.138.150) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 17 Sep 2020 18:18:57 +0000 Date: Thu, 17 Sep 2020 11:18:56 -0700 From: "Darrick J. Wong" To: xiakaixu1987@gmail.com Cc: linux-xfs@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH v2 5/7] xfs: remove the redundant crc feature check in xfs_attr3_rmt_verify Message-ID: <20200917181856.GL7955@magnolia> References: <1600342728-21149-1-git-send-email-kaixuxia@tencent.com> <1600342728-21149-6-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600342728-21149-6-git-send-email-kaixuxia@tencent.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=3 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 bulkscore=0 suspectscore=3 clxscore=1015 mlxlogscore=999 adultscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170136 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Sep 17, 2020 at 07:38:46PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > We already check whether the crc feature is enabled before calling > xfs_attr3_rmt_verify(), so remove the redundant feature check in that > function. > > Signed-off-by: Kaixu Xia Looks good, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_attr_remote.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr_remote.c b/fs/xfs/libxfs/xfs_attr_remote.c > index 3f80cede7406..48d8e9caf86f 100644 > --- a/fs/xfs/libxfs/xfs_attr_remote.c > +++ b/fs/xfs/libxfs/xfs_attr_remote.c > @@ -96,8 +96,6 @@ xfs_attr3_rmt_verify( > { > struct xfs_attr3_rmt_hdr *rmt = ptr; > > - if (!xfs_sb_version_hascrc(&mp->m_sb)) > - return __this_address; > if (!xfs_verify_magic(bp, rmt->rm_magic)) > return __this_address; > if (!uuid_equal(&rmt->rm_uuid, &mp->m_sb.sb_meta_uuid)) > -- > 2.20.0 >