From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A380C2BBD1 for ; Thu, 17 Sep 2020 18:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA62B2220A for ; Thu, 17 Sep 2020 18:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600367375; bh=JUONM1Y/eeGpl51Vy7G7yZa26OYQAx5a1o9bq3CQMpw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=H8qOidDNiZCAHIJyBwBtO/JEqwCahHyDxzvpckiGvNrcp1rmCf/nyB69zaP74MOGr 31kqpBNUa/5IlF3q5I7aeY965L7S2MTEOe07juXYJCSmaXVSsntBrelGM+WkzmTfX7 ZIjpaJLBQIPUNhvWqjWz8IeN+iByo6Q0XgNPrM2A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726538AbgIQS3d (ORCPT ); Thu, 17 Sep 2020 14:29:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:34944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbgIQS3R (ORCPT ); Thu, 17 Sep 2020 14:29:17 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08F01221EE; Thu, 17 Sep 2020 18:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600367356; bh=JUONM1Y/eeGpl51Vy7G7yZa26OYQAx5a1o9bq3CQMpw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xUKqpXTP9ybK4uH3Em2gjvhEntBMNyGg3lATYH0gO7ZGFVe0lda6RRJBgqPSDsMvL VYPDSOIpaYdOCXWBw41IDpEoDvKdMlXY0nML5TCKYBVEn7lzi9DffaPeXiL/2VqioC Cxpvnp/VOFg2AHtFxrn2iotfWztsmxmqROnT2DX4= Date: Thu, 17 Sep 2020 19:29:11 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich , Liam Girdwood , Mark Brown Subject: Re: [PATCH 30/30] iio: dac: ad7303: Complete 'struct ad7303_state' doc and reorder compiler attribute Message-ID: <20200917192911.786011e5@archlinux> In-Reply-To: <20200716135928.1456727-31-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-31-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:28 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vdd_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vref_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'lock' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7303_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Applied but with the ____cacheline_aligned bit dropped as we've fixed the kernel-doc script up to ignore that one. Thanks, Jonathan > --- > drivers/iio/dac/ad7303.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c > index 15af8a1cce3eb..05d8dc88d4fad 100644 > --- a/drivers/iio/dac/ad7303.c > +++ b/drivers/iio/dac/ad7303.c > @@ -29,6 +29,9 @@ > * @spi: the device for this driver instance > * @config: cached config register value > * @dac_cache: current DAC raw value (chip does not support readback) > + * @vdd_reg: reference to VDD regulator > + * @vref_reg: reference to VREF regulator > + * @lock: protect writes and cache updates > * @data: spi transfer buffer > */ > > @@ -45,7 +48,7 @@ struct ad7303_state { > * DMA (thus cache coherency maintenance) requires the > * transfer buffers to live in their own cache lines. > */ > - __be16 data ____cacheline_aligned; > + __be16 ____cacheline_aligned data; > }; > > static int ad7303_write(struct ad7303_state *st, unsigned int chan, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAA1C433E2 for ; Thu, 17 Sep 2020 18:30:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41A24206CA for ; Thu, 17 Sep 2020 18:30:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uL7RoPi3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xUKqpXTP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41A24206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=24Nx3jjwACz6tEEiYUWKCLP/Ekn2sbR7ex9GCNK607U=; b=uL7RoPi3kxsYT0blcaM7O3xmD QFhXbR3RKIkM7m6/DabZM8KRPlQ5ky66qBMX/myY803zR9hmsSdEwgVPPBc4GH42X7ZrncD10BOZd 7KGyOBJllArk6DpKlpKoWK2znvOkFs5XnxzAyz8uOYWb6um6207j2DOPYVv595RCoeb3zof+hnO5f 1IARNH7PyXoz3AMq8dhsfVxCqk0ARoUaDa7ZT9drauDWgjWL2aY7CnV9wO3+rcLp7HI2kUVrM/urs aFCF8yPKzG2BTRok+WG6BtVPdQilfoSneNxKCa5rZ+349qg8xTcpb7+lYXwHBgGAu9B9JcyD6vn2m 62EdgElHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyeo-0004YC-7X; Thu, 17 Sep 2020 18:29:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyel-0004Xd-8z for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 18:29:20 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08F01221EE; Thu, 17 Sep 2020 18:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600367356; bh=JUONM1Y/eeGpl51Vy7G7yZa26OYQAx5a1o9bq3CQMpw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xUKqpXTP9ybK4uH3Em2gjvhEntBMNyGg3lATYH0gO7ZGFVe0lda6RRJBgqPSDsMvL VYPDSOIpaYdOCXWBw41IDpEoDvKdMlXY0nML5TCKYBVEn7lzi9DffaPeXiL/2VqioC Cxpvnp/VOFg2AHtFxrn2iotfWztsmxmqROnT2DX4= Date: Thu, 17 Sep 2020 19:29:11 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 30/30] iio: dac: ad7303: Complete 'struct ad7303_state' doc and reorder compiler attribute Message-ID: <20200917192911.786011e5@archlinux> In-Reply-To: <20200716135928.1456727-31-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-31-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_142919_389124_67DE12EB X-CRM114-Status: GOOD ( 18.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:28 +0100 Lee Jones wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vdd_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'vref_reg' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member 'lock' not described in 'ad7303_state' > drivers/iio/dac/ad7303.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7303_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Applied but with the ____cacheline_aligned bit dropped as we've fixed the kernel-doc script up to ignore that one. Thanks, Jonathan > --- > drivers/iio/dac/ad7303.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c > index 15af8a1cce3eb..05d8dc88d4fad 100644 > --- a/drivers/iio/dac/ad7303.c > +++ b/drivers/iio/dac/ad7303.c > @@ -29,6 +29,9 @@ > * @spi: the device for this driver instance > * @config: cached config register value > * @dac_cache: current DAC raw value (chip does not support readback) > + * @vdd_reg: reference to VDD regulator > + * @vref_reg: reference to VREF regulator > + * @lock: protect writes and cache updates > * @data: spi transfer buffer > */ > > @@ -45,7 +48,7 @@ struct ad7303_state { > * DMA (thus cache coherency maintenance) requires the > * transfer buffers to live in their own cache lines. > */ > - __be16 data ____cacheline_aligned; > + __be16 ____cacheline_aligned data; > }; > > static int ad7303_write(struct ad7303_state *st, unsigned int chan, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel