From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B19CC43461 for ; Thu, 17 Sep 2020 18:31:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3132206B6 for ; Thu, 17 Sep 2020 18:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600367512; bh=Q73HHVkXX0eyc1PRGwGj8sWsl2DMp0buRksQmCBOIUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=wltxnNjFn5OWrzHYhTC2r12aVrMatUX/1ppmEftPy0I6Wt6XHT2DJTxEWbmD8sKCZ ln96fd/ti9+4ksLXcpgiNwcTzqBS6wuzWIHBGthLGOEubQJpsm/IDLfhOJXBfjSz5/ 2Le8PbZMRIOxzfUmJnGFRBieTC/xyEn7qcWjSqz8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726236AbgIQSbq (ORCPT ); Thu, 17 Sep 2020 14:31:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:36612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbgIQSbQ (ORCPT ); Thu, 17 Sep 2020 14:31:16 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 273E4206CA; Thu, 17 Sep 2020 18:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600367475; bh=Q73HHVkXX0eyc1PRGwGj8sWsl2DMp0buRksQmCBOIUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lu564qrl0xRU0l4WCe2vdI18v9kr4InHnYqafIY9G0KDzxs1hW820hYY1qio43yo0 5vxGRzmAR+DJUryRlYLZ9Nrt6loonMitvkhITPqDKV2jnKQDtZqJdURU8nXaYrXmWx 2YQ4k6lAQemYnct0XIjV7gOAsfef32kBkLvVuTcA= Date: Thu, 17 Sep 2020 19:31:10 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich , Liam Girdwood , Mark Brown Subject: Re: [PATCH 19/30] iio: dac: ad5064: Fix a few kerneldoc misdemeanours Message-ID: <20200917193110.3abb8530@archlinux> In-Reply-To: <20200716135928.1456727-20-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-20-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 14:59:17 +0100 Lee Jones wrote: > Misspelling, missing description and compiler attribute ordering. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5064.c:71: warning: bad line: internal vref. > drivers/iio/dac/ad5064.c:83: warning: Function parameter or member 'channels' not described in 'ad5064_chip_info' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member 'lock' not described in 'ad5064_state' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member '____cacheline_aligned' not described in 'ad5064_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Applied with the ___cacheline_aligned bit dropped as now kernel-doc won't complain about that. Thanks, Jonathan > --- > drivers/iio/dac/ad5064.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5064.c b/drivers/iio/dac/ad5064.c > index 303f6d1a5f311..d7109f8f52efa 100644 > --- a/drivers/iio/dac/ad5064.c > +++ b/drivers/iio/dac/ad5064.c > @@ -68,8 +68,8 @@ enum ad5064_regmap_type { > * struct ad5064_chip_info - chip specific information > * @shared_vref: whether the vref supply is shared between channels > * @internal_vref: internal reference voltage. 0 if the chip has no > - internal vref. > - * @channel: channel specification > + * internal vref. > + * @channels: channel specification > * @num_channels: number of channels > * @regmap_type: register map layout variant > */ > @@ -98,6 +98,7 @@ typedef int (*ad5064_write_func)(struct ad5064_state *st, unsigned int cmd, > * @use_internal_vref: set to true if the internal reference voltage should be > * used. > * @write: register write callback > + * @lock: maintain consistency between cached and dev state > * @data: i2c/spi transfer buffers > */ > > @@ -111,7 +112,6 @@ struct ad5064_state { > bool use_internal_vref; > > ad5064_write_func write; > - /* Lock used to maintain consistency between cached and dev state */ > struct mutex lock; > > /* > @@ -121,7 +121,7 @@ struct ad5064_state { > union { > u8 i2c[3]; > __be32 spi; > - } data ____cacheline_aligned; > + } ____cacheline_aligned data; > }; > > enum ad5064_type { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C80C433E2 for ; Thu, 17 Sep 2020 18:32:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E13E5206B6 for ; Thu, 17 Sep 2020 18:32:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iHyCkdbY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lu564qrl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E13E5206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vg05b1CCs/IKG6ofB7Fa27LgO11LOrvV83PQpz84TCo=; b=iHyCkdbYbaHJcdUs4Ih3q4Zcc k13dHcD/GStn8Qpx/JI+Tdn93ee93UXlZFtE0cM/pRArxyCfhjEWrYgpL/ZBPg4NUel0RBxHQzCr1 BUDOHJt6CH4gs37OBHXBK+0/m+UM+4eXnLwmZo8gaDcOei1I4eGYuxIU7PjVCDtRaOJ/PnIna+1gA mR8YIjaRNGvnoAtJ4nJWwndsR222nYE/VdvM61obzZKWC91GDrBjab6ibTxQ6nBwK3iN8L3dBQlqI +GysYFUW8rBbmMaPQ70oIHi9Xlpytj3mOfkzB7F1STWcH/LFZQY9qt+nbNV/pW/PBYB8RQW3xoB+V E4+neqHbQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIygh-0004wu-C3; Thu, 17 Sep 2020 18:31:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyge-0004wC-N7 for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 18:31:17 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 273E4206CA; Thu, 17 Sep 2020 18:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600367475; bh=Q73HHVkXX0eyc1PRGwGj8sWsl2DMp0buRksQmCBOIUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lu564qrl0xRU0l4WCe2vdI18v9kr4InHnYqafIY9G0KDzxs1hW820hYY1qio43yo0 5vxGRzmAR+DJUryRlYLZ9Nrt6loonMitvkhITPqDKV2jnKQDtZqJdURU8nXaYrXmWx 2YQ4k6lAQemYnct0XIjV7gOAsfef32kBkLvVuTcA= Date: Thu, 17 Sep 2020 19:31:10 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 19/30] iio: dac: ad5064: Fix a few kerneldoc misdemeanours Message-ID: <20200917193110.3abb8530@archlinux> In-Reply-To: <20200716135928.1456727-20-lee.jones@linaro.org> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-20-lee.jones@linaro.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_143116_828162_F3FE39B8 X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 16 Jul 2020 14:59:17 +0100 Lee Jones wrote: > Misspelling, missing description and compiler attribute ordering. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5064.c:71: warning: bad line: internal vref. > drivers/iio/dac/ad5064.c:83: warning: Function parameter or member 'channels' not described in 'ad5064_chip_info' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member 'lock' not described in 'ad5064_state' > drivers/iio/dac/ad5064.c:125: warning: Function parameter or member '____cacheline_aligned' not described in 'ad5064_state' > > Cc: Michael Hennerich > Cc: Liam Girdwood > Cc: Mark Brown > Signed-off-by: Lee Jones Applied with the ___cacheline_aligned bit dropped as now kernel-doc won't complain about that. Thanks, Jonathan > --- > drivers/iio/dac/ad5064.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5064.c b/drivers/iio/dac/ad5064.c > index 303f6d1a5f311..d7109f8f52efa 100644 > --- a/drivers/iio/dac/ad5064.c > +++ b/drivers/iio/dac/ad5064.c > @@ -68,8 +68,8 @@ enum ad5064_regmap_type { > * struct ad5064_chip_info - chip specific information > * @shared_vref: whether the vref supply is shared between channels > * @internal_vref: internal reference voltage. 0 if the chip has no > - internal vref. > - * @channel: channel specification > + * internal vref. > + * @channels: channel specification > * @num_channels: number of channels > * @regmap_type: register map layout variant > */ > @@ -98,6 +98,7 @@ typedef int (*ad5064_write_func)(struct ad5064_state *st, unsigned int cmd, > * @use_internal_vref: set to true if the internal reference voltage should be > * used. > * @write: register write callback > + * @lock: maintain consistency between cached and dev state > * @data: i2c/spi transfer buffers > */ > > @@ -111,7 +112,6 @@ struct ad5064_state { > bool use_internal_vref; > > ad5064_write_func write; > - /* Lock used to maintain consistency between cached and dev state */ > struct mutex lock; > > /* > @@ -121,7 +121,7 @@ struct ad5064_state { > union { > u8 i2c[3]; > __be32 spi; > - } data ____cacheline_aligned; > + } ____cacheline_aligned data; > }; > > enum ad5064_type { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel