From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 675B8C433E2 for ; Thu, 17 Sep 2020 18:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 296A4206B6 for ; Thu, 17 Sep 2020 18:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbgIQSeN (ORCPT ); Thu, 17 Sep 2020 14:34:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbgIQSdl (ORCPT ); Thu, 17 Sep 2020 14:33:41 -0400 Received: from saturn.retrosnub.co.uk (saturn.retrosnub.co.uk [IPv6:2a00:1098:86::1:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 884ADC06174A; Thu, 17 Sep 2020 11:33:38 -0700 (PDT) Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id C83FF9E022B; Thu, 17 Sep 2020 19:33:03 +0100 (BST) Date: Thu, 17 Sep 2020 19:33:02 +0100 From: Jonathan Cameron To: Lee Jones Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Michael Hennerich , Barry Song <21cnbao@gmail.com>, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH 12/30] iio: gyro: adis16080: Fix formatting issue and compiler attribute ordering Message-ID: <20200917193302.65e922c0@archlinux> In-Reply-To: <20200718155442.14c420db@archlinux> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-13-lee.jones@linaro.org> <20200718155442.14c420db@archlinux> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Jul 2020 15:54:42 +0100 Jonathan Cameron wrote: > On Thu, 16 Jul 2020 14:59:10 +0100 > Lee Jones wrote: > > > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > > gets confused if the variable does not follow the type/attribute > > definitions. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member 'lock' not described in 'adis16080_state' > > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'adis16080_state' > > > > Cc: Michael Hennerich > > Cc: Barry Song <21cnbao@gmail.com> > > Signed-off-by: Lee Jones > Hmm. You are going to have an awful lot of those ____cacheline_aligned ones. > > Might be worth thinking about whether we fix kernel-doc to cope with those. > > A quick grep suggests the vast majority of users of this have it after > the element name. > > @Jon Corbet : What do you think? Looks like there is special > handling already for ____cacheline_aligned_in_smp. Should we extend > that to this case? Applied with the ____cacheline_aligned bit dropped as Jon took the patch to stop kernel-doc complaining about this. thanks, Jonathan > > Jonathan > > > > > --- > > drivers/iio/gyro/adis16080.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/gyro/adis16080.c b/drivers/iio/gyro/adis16080.c > > index 1b84b8e112fe1..f38f9abcccbb5 100644 > > --- a/drivers/iio/gyro/adis16080.c > > +++ b/drivers/iio/gyro/adis16080.c > > @@ -38,14 +38,14 @@ struct adis16080_chip_info { > > * @us: actual spi_device to write data > > * @info: chip specific parameters > > * @buf: transmit or receive buffer > > - * @lock lock to protect buffer during reads > > + * @lock: lock to protect buffer during reads > > **/ > > struct adis16080_state { > > struct spi_device *us; > > const struct adis16080_chip_info *info; > > struct mutex lock; > > > > - __be16 buf ____cacheline_aligned; > > + __be16 ____cacheline_aligned buf; > > }; > > > > static int adis16080_read_sample(struct iio_dev *indio_dev, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AB1C433E2 for ; Thu, 17 Sep 2020 18:34:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 941FD206CA for ; Thu, 17 Sep 2020 18:34:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MjwGeiIZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 941FD206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jic23.retrosnub.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+cog7hvT8x/iXO8RTdCWiYrDB9jRZvN264rC9yLblSI=; b=MjwGeiIZq/TGiXNubUbrkDjJQ jZhKIvA+P8ul27G0MDlm4tFw+rykPDyvkcqfccPVEhqniMaMv4Q04eyagLV5tVccwHhICc6yFBRzt 9DZqVnMFOz99s1ZlWMIBu2RVpC7CyeEhz50O1AtOH0MzGob69+7VkvbzGAtafExJeVm8thBVeCJCO +633Pr+OWrqR9C8pzB9MftKTmImnhgqDYU/FCdBog401fnfb5Hznz62HHl9HjeZ1PKC0SeGwD5UKT koFvWbKCJ5zZuhMXCu6E3c59XNgdgM5ROQzIdRf2t1FxaswT6jclNa23+c6NN3goOZI7AVfroUD5b tDsh4MZ1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyiS-0005Lt-CB; Thu, 17 Sep 2020 18:33:08 +0000 Received: from saturn.retrosnub.co.uk ([46.235.226.198]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIyiQ-0005L3-2n for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 18:33:06 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id C83FF9E022B; Thu, 17 Sep 2020 19:33:03 +0100 (BST) Date: Thu, 17 Sep 2020 19:33:02 +0100 From: Jonathan Cameron To: Lee Jones Subject: Re: [PATCH 12/30] iio: gyro: adis16080: Fix formatting issue and compiler attribute ordering Message-ID: <20200917193302.65e922c0@archlinux> In-Reply-To: <20200718155442.14c420db@archlinux> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-13-lee.jones@linaro.org> <20200718155442.14c420db@archlinux> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_143306_253177_333A0C02 X-CRM114-Status: GOOD ( 21.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lars@metafoo.de, Michael Hennerich , Jonathan Corbet , linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 18 Jul 2020 15:54:42 +0100 Jonathan Cameron wrote: > On Thu, 16 Jul 2020 14:59:10 +0100 > Lee Jones wrote: > > > Kerneldoc expects attributes/parameters to be in '@*.: ' format and > > gets confused if the variable does not follow the type/attribute > > definitions. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member 'lock' not described in 'adis16080_state' > > drivers/iio/gyro/adis16080.c:49: warning: Function parameter or member '____cacheline_aligned' not described in 'adis16080_state' > > > > Cc: Michael Hennerich > > Cc: Barry Song <21cnbao@gmail.com> > > Signed-off-by: Lee Jones > Hmm. You are going to have an awful lot of those ____cacheline_aligned ones. > > Might be worth thinking about whether we fix kernel-doc to cope with those. > > A quick grep suggests the vast majority of users of this have it after > the element name. > > @Jon Corbet : What do you think? Looks like there is special > handling already for ____cacheline_aligned_in_smp. Should we extend > that to this case? Applied with the ____cacheline_aligned bit dropped as Jon took the patch to stop kernel-doc complaining about this. thanks, Jonathan > > Jonathan > > > > > --- > > drivers/iio/gyro/adis16080.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/gyro/adis16080.c b/drivers/iio/gyro/adis16080.c > > index 1b84b8e112fe1..f38f9abcccbb5 100644 > > --- a/drivers/iio/gyro/adis16080.c > > +++ b/drivers/iio/gyro/adis16080.c > > @@ -38,14 +38,14 @@ struct adis16080_chip_info { > > * @us: actual spi_device to write data > > * @info: chip specific parameters > > * @buf: transmit or receive buffer > > - * @lock lock to protect buffer during reads > > + * @lock: lock to protect buffer during reads > > **/ > > struct adis16080_state { > > struct spi_device *us; > > const struct adis16080_chip_info *info; > > struct mutex lock; > > > > - __be16 buf ____cacheline_aligned; > > + __be16 ____cacheline_aligned buf; > > }; > > > > static int adis16080_read_sample(struct iio_dev *indio_dev, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel