From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13456C43464 for ; Fri, 18 Sep 2020 00:32:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B81D62083B for ; Fri, 18 Sep 2020 00:32:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RYw8dtrc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgIRAcX (ORCPT ); Thu, 17 Sep 2020 20:32:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgIRAcX (ORCPT ); Thu, 17 Sep 2020 20:32:23 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 080E9C06174A for ; Thu, 17 Sep 2020 17:32:22 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id bd2so2034881plb.7 for ; Thu, 17 Sep 2020 17:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1/kfi2E3nenb9HO+wEapXw+2tJYGOOUMEBKUiJkUM4w=; b=RYw8dtrcrNqqjNgOEQE6G8Nf94ysTiU53kwId9MA9TBwyEx3E6KnyUEEp9tuOrRiEL uxIN8Oo5kOy9lc9yFnyHJAaUyeSrs6h+ffyjOvWSr6V4Yx/7uNqkemQv7ueLmeKf9LhS gEqLLYlHfcGFys/RM2P4ecG3yMbkQwL2KF/eivThbtdQZ19zvnkh+a0Ol9x6td+rZRbh +6gPz/lwuTCn2L4emyW7IquA92sg/Ah+RQs0jtEtAk8VgXDLP9z6QVGA3UoghYdzTp9Z HbZlnGKZLZUM//mD8PtP5Pbf7EmoVRb35l9Ore3gLQXM5s3Xa6mjYV0wbnKvkIFhhVaN nvsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1/kfi2E3nenb9HO+wEapXw+2tJYGOOUMEBKUiJkUM4w=; b=ggLKUGfcupL+06uXwe/dcbZdG4iecW5DgiC4yNstYTLKF0juHX+5rud8HIMAp+WKGR y7t/PRGT7wKTo/O27ogh2E0VrRz4RmCFYVhPSFIlHRwk6ipX/d0MIpTqJ2Le9a37oa9s /Wi1GkE2vmVJjJ/mhLLjK/aE9VsUbZkrH169OfvsAgzTuxG0uoITr2LbNHDF2LqW6bfe Zbp3QVkxdnnTh4woEUHUiCkvFvNdBCzqFzNLpxCkAC2PisPgwfaLBU7DdGgs/Cbh6d9W kLVSsfBfhqINvJ2Z+dClvFW1Fa/7SNArDBkdpQx66/6NCkkWWBHeWSsJj7jtJl6+yHbK uClQ== X-Gm-Message-State: AOAM533C7239AaYbZjSkvW/tdif+WT7ls4CjJtNxGGHO5bZqXtqLo8ff a5B9O75SLfJmLLgrfuxM5fA= X-Google-Smtp-Source: ABdhPJwuNjsTejgWhMBUP5Bw+QzqBxqdPHyPl4gno5AOB06+jdW06Ehf61wM9opeMP8ZF2WdFB0Glw== X-Received: by 2002:a17:902:aa91:b029:d1:f8be:ac74 with SMTP id d17-20020a170902aa91b02900d1f8beac74mr5467178plr.39.1600389142139; Thu, 17 Sep 2020 17:32:22 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id d128sm872680pfc.8.2020.09.17.17.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 17:32:20 -0700 (PDT) Date: Fri, 18 Sep 2020 09:32:19 +0900 From: Sergey Senozhatsky To: Marc Zyngier Cc: Leo Yan , Sergey Senozhatsky , Arnaldo Carvalho de Melo , Mark Rutland , Peter Zijlstra , Will Deacon , John Garry , Mathieu Poirier , Namhyung Kim , Suleiman Souhlal , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 Message-ID: <20200918003219.GC3049@jagdpanzerIV.localdomain> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917100950.GC12548@leoy-ThinkPad-X240s> <20200917101219.GD12548@leoy-ThinkPad-X240s> <652f10660f09bd608b825233713f775a@kernel.org> <20200917114231.GE12548@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/09/17 12:53), Marc Zyngier wrote: > Feel free to add a *new* tracepoint instead. Wouldn't we want a whole bunch of new tracepoints in this case? (almost all of the existing ones with the extra vcpu_id field). Right now we have 3 types of events: - events with no vcpu at all // nil - events with vcpu_pc // "0x%016lx", __entry->vcpu_pc - events with (void *)vcpu // "vcpu: %p", __entry->vcpu It might be helpful if we could filter out events by vcpu_id. But this, basically, doubles the number of events in the ringbuffer. -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD20C43464 for ; Fri, 18 Sep 2020 00:33:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 468D62083B for ; Fri, 18 Sep 2020 00:33:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a4Qalg9F"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RYw8dtrc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 468D62083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3MaTZSf1KUUMhtoePCXMGx0hk2DZHyndaHm8IK95Dv8=; b=a4Qalg9FyRLG6xQ8LVzpFPD6H 3V1q7G0ehPzNnpVwIjPZw1kKbsVLQgFP1lq1MYhdLwofeFIyhN2WvnDzsn1a/KIZC+kIHRvv1tRlN cF1NRjvJYfg7TJ2cfK8g+8EFG/UNX8+SVER1ksGh1o9jVIibOeMmAPiYOrIrqJRl2w3tdPvEY1Vsx +3Xeo/4WrUHys8QIdb7DN+bPUNLlZucabbTwCH8DPBltHIjBtPPMed+LwunJB8ZjpLICeTdVzQxEr qyIQEg5tCq17wU2Vw3xt1tdeoVlGuEydNUiTzUzXWGqNzjqDngC+HQJ1m0Cxb14Y92H0wYey28BUV EmJIXl9WA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ4KB-0004OX-Bx; Fri, 18 Sep 2020 00:32:27 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ4K8-0004Ng-7U for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 00:32:25 +0000 Received: by mail-pj1-x1032.google.com with SMTP id mm21so2199029pjb.4 for ; Thu, 17 Sep 2020 17:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1/kfi2E3nenb9HO+wEapXw+2tJYGOOUMEBKUiJkUM4w=; b=RYw8dtrcrNqqjNgOEQE6G8Nf94ysTiU53kwId9MA9TBwyEx3E6KnyUEEp9tuOrRiEL uxIN8Oo5kOy9lc9yFnyHJAaUyeSrs6h+ffyjOvWSr6V4Yx/7uNqkemQv7ueLmeKf9LhS gEqLLYlHfcGFys/RM2P4ecG3yMbkQwL2KF/eivThbtdQZ19zvnkh+a0Ol9x6td+rZRbh +6gPz/lwuTCn2L4emyW7IquA92sg/Ah+RQs0jtEtAk8VgXDLP9z6QVGA3UoghYdzTp9Z HbZlnGKZLZUM//mD8PtP5Pbf7EmoVRb35l9Ore3gLQXM5s3Xa6mjYV0wbnKvkIFhhVaN nvsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1/kfi2E3nenb9HO+wEapXw+2tJYGOOUMEBKUiJkUM4w=; b=cBBGajI8h0AR9N4i0fp/vbir+b01N1HEkrJB/8qoGYTgBp1Xkkl8yF3nwkGGo0AzpQ tmUB5AAV/fKMUPg5r8xXItBPG4Lo4ZXXYS1LsF1QjnQXKPbxgj26HIpR728QVLHvJtls eD/b0L7+Zg//1ktz/Cq2cwkuWXSKMISS1E1X4qNXf2ZWGXsKtWoFizW//5WCtd4dkv8B RwQeZYBqiXvOqUShJHcu35QYHMKVQEvixu3B0OQx6NahaOps+uS3B+yf+9nOOoIJ/VNs gPuuNAuR/8Vsa2uNeEeb/HWo5tzeSRqPnuTyFmuDnohrn001HFIBzWr6yVy45KAgUcqo fgLQ== X-Gm-Message-State: AOAM5330uM+pVue7rmPI3peqQ6HVjByxvtAd9vmtXWBE0mZNssvPDKT8 549a5Fbj6Cf5uY5k0x9cbCY= X-Google-Smtp-Source: ABdhPJwuNjsTejgWhMBUP5Bw+QzqBxqdPHyPl4gno5AOB06+jdW06Ehf61wM9opeMP8ZF2WdFB0Glw== X-Received: by 2002:a17:902:aa91:b029:d1:f8be:ac74 with SMTP id d17-20020a170902aa91b02900d1f8beac74mr5467178plr.39.1600389142139; Thu, 17 Sep 2020 17:32:22 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id d128sm872680pfc.8.2020.09.17.17.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 17:32:20 -0700 (PDT) Date: Fri, 18 Sep 2020 09:32:19 +0900 From: Sergey Senozhatsky To: Marc Zyngier Subject: Re: [PATCHv3] perf kvm: add kvm-stat for arm64 Message-ID: <20200918003219.GC3049@jagdpanzerIV.localdomain> References: <20200917003645.689665-1-sergey.senozhatsky@gmail.com> <20200917100950.GC12548@leoy-ThinkPad-X240s> <20200917101219.GD12548@leoy-ThinkPad-X240s> <652f10660f09bd608b825233713f775a@kernel.org> <20200917114231.GE12548@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_203224_363408_9672A404 X-CRM114-Status: GOOD ( 10.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suleiman Souhlal , Mathieu Poirier , Peter Zijlstra , John Garry , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Sergey Senozhatsky , Leo Yan , Namhyung Kim , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On (20/09/17 12:53), Marc Zyngier wrote: > Feel free to add a *new* tracepoint instead. Wouldn't we want a whole bunch of new tracepoints in this case? (almost all of the existing ones with the extra vcpu_id field). Right now we have 3 types of events: - events with no vcpu at all // nil - events with vcpu_pc // "0x%016lx", __entry->vcpu_pc - events with (void *)vcpu // "vcpu: %p", __entry->vcpu It might be helpful if we could filter out events by vcpu_id. But this, basically, doubles the number of events in the ringbuffer. -ss _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel