From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CAF3C43464 for ; Fri, 18 Sep 2020 02:21:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DA412311C for ; Fri, 18 Sep 2020 02:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395688; bh=zmCezSv8mK+yb4xuSGtAO17x+Idcop8nimvbwBBa0Lo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WCzMCBiBkQ88Cone/0S0819On/YOTb9TomKvB6OyyefmOgIdmAJMl1gIaQ08UChoV ukc4Y3xak9fnqd4rmY5YsRZYievyZVjfC2YgKPlrzXhWma+p86fHDvmq8AVpC0+Oe0 eJfMy2XhLadnMzibK5k7slosEmk71varkdizvVEQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgIRCUx (ORCPT ); Thu, 17 Sep 2020 22:20:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:48150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729221AbgIRCR2 (ORCPT ); Thu, 17 Sep 2020 22:17:28 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E6B123888; Fri, 18 Sep 2020 02:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600395447; bh=zmCezSv8mK+yb4xuSGtAO17x+Idcop8nimvbwBBa0Lo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MbHACLkhnCQXBcrxkWDdvyKz+cy1aKYOCImwklZqQfqHGz4KBGrG5mLnSiIafY6Jg 26Q7AIvTlRkyKipOHgE4d4qFceEVEYTz+xxAdrPRJeZNbs+Zfr2wT0tnQxB4z/AagK 4zkUb4iBPYvZKYYNxmybdNq/3ZVih3O1SgncIFWY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Chancellor , Nick Desaulniers , Steven Rostedt , Sasha Levin Subject: [PATCH AUTOSEL 4.4 35/64] tracing: Use address-of operator on section symbols Date: Thu, 17 Sep 2020 22:16:14 -0400 Message-Id: <20200918021643.2067895-35-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200918021643.2067895-1-sashal@kernel.org> References: <20200918021643.2067895-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor [ Upstream commit bf2cbe044da275021b2de5917240411a19e5c50d ] Clang warns: ../kernel/trace/trace.c:9335:33: warning: array comparison always evaluates to true [-Wtautological-compare] if (__stop___trace_bprintk_fmt != __start___trace_bprintk_fmt) ^ 1 warning generated. These are not true arrays, they are linker defined symbols, which are just addresses. Using the address of operator silences the warning and does not change the runtime result of the check (tested with some print statements compiled in with clang + ld.lld and gcc + ld.bfd in QEMU). Link: http://lkml.kernel.org/r/20200220051011.26113-1-natechancellor@gmail.com Link: https://github.com/ClangBuiltLinux/linux/issues/893 Suggested-by: Nick Desaulniers Signed-off-by: Nathan Chancellor Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Sasha Levin --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 17ea5f9d36b48..e4a0c0308b507 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -7263,7 +7263,7 @@ __init static int tracer_alloc_buffers(void) goto out_free_buffer_mask; /* Only allocate trace_printk buffers if a trace_printk exists */ - if (__stop___trace_bprintk_fmt != __start___trace_bprintk_fmt) + if (&__stop___trace_bprintk_fmt != &__start___trace_bprintk_fmt) /* Must be called before global_trace.buffer is allocated */ trace_printk_init_buffers(); -- 2.25.1