From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73E0BC43463 for ; Fri, 18 Sep 2020 05:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1674720771 for ; Fri, 18 Sep 2020 05:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbgIRFKe (ORCPT ); Fri, 18 Sep 2020 01:10:34 -0400 Received: from verein.lst.de ([213.95.11.211]:59111 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgIRFKe (ORCPT ); Fri, 18 Sep 2020 01:10:34 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9FD6A68B02; Fri, 18 Sep 2020 07:10:30 +0200 (CEST) Date: Fri, 18 Sep 2020 07:10:30 +0200 From: Christoph Hellwig To: Russell King - ARM Linux admin Cc: Christoph Hellwig , Aaro Koskinen , Tony Lindgren , Robin Murphy , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 3/4] ARM/dma-mapping: don't handle NULL devices in dma-direct.h Message-ID: <20200918051030.GA21261@lst.de> References: <20200917173229.3311382-1-hch@lst.de> <20200917173229.3311382-4-hch@lst.de> <20200917185009.GB1559@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917185009.GB1559@shell.armlinux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 07:50:10PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Sep 17, 2020 at 07:32:28PM +0200, Christoph Hellwig wrote: > > The DMA API removed support for not passing in a device a long time > > ago, so remove the NULL checks. > > What happens with ISA devices? For actual drivers they've been switched to struct isa_driver, which provides a struct device. For some of the special case like the arch/arm/kernel/dma-isa.c we now use static struct device instances. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8EFC43466 for ; Fri, 18 Sep 2020 05:10:40 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56D7F20771 for ; Fri, 18 Sep 2020 05:10:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56D7F20771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D1C0F87587; Fri, 18 Sep 2020 05:10:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j0IlMG1iYSox; Fri, 18 Sep 2020 05:10:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 100B986110; Fri, 18 Sep 2020 05:10:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DB0B1C0888; Fri, 18 Sep 2020 05:10:37 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 70E30C0051 for ; Fri, 18 Sep 2020 05:10:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 625A6204CE for ; Fri, 18 Sep 2020 05:10:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JITxJq36QF5I for ; Fri, 18 Sep 2020 05:10:35 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by silver.osuosl.org (Postfix) with ESMTPS id ECF7C20432 for ; Fri, 18 Sep 2020 05:10:34 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9FD6A68B02; Fri, 18 Sep 2020 07:10:30 +0200 (CEST) Date: Fri, 18 Sep 2020 07:10:30 +0200 From: Christoph Hellwig To: Russell King - ARM Linux admin Subject: Re: [PATCH 3/4] ARM/dma-mapping: don't handle NULL devices in dma-direct.h Message-ID: <20200918051030.GA21261@lst.de> References: <20200917173229.3311382-1-hch@lst.de> <20200917173229.3311382-4-hch@lst.de> <20200917185009.GB1559@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917185009.GB1559@shell.armlinux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Aaro Koskinen , Tony Lindgren , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-omap@vger.kernel.org, Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Sep 17, 2020 at 07:50:10PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Sep 17, 2020 at 07:32:28PM +0200, Christoph Hellwig wrote: > > The DMA API removed support for not passing in a device a long time > > ago, so remove the NULL checks. > > What happens with ISA devices? For actual drivers they've been switched to struct isa_driver, which provides a struct device. For some of the special case like the arch/arm/kernel/dma-isa.c we now use static struct device instances. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C60C43463 for ; Fri, 18 Sep 2020 05:12:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 756C721D20 for ; Fri, 18 Sep 2020 05:12:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0ZhDbZ/d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 756C721D20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZPmq6FW14vB0AiHjq0qaBS6CNumkMLFPpYl96+4f2+g=; b=0ZhDbZ/dKJtVc+cEbxvi1+CB1 oc2Y1P2JBBo1GKLqE0Nf2GYsl0amPoIhFVlSXGlT7T0xomhQRjU9aF9Wlz55JsYWoBTs1wrDGoxSJ dkGCEkt6spxD9nZYDPpEqdfxrWJ4rG/fln4zsmT9J7F2tAlqfeFGpixHgv+VavaOuBvvxNdMgkjXp KZZhbeXhnJaJ7ngz3umz1TawAHoSlqAYuAoUBlEd3h8Qu0Zykyfsek1aXtIJaqIV3vo15vfheukjR 3w8TwnYS4FETAtuK8M76UEv/e4Djy0VhydQwMCGD5hM7zyOsKNaCl7egNkglQTflq07wDd3KUyREX Nc6pPUOHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ8fN-0008OM-Rl; Fri, 18 Sep 2020 05:10:37 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ8fJ-0008NQ-OB for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 05:10:34 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 9FD6A68B02; Fri, 18 Sep 2020 07:10:30 +0200 (CEST) Date: Fri, 18 Sep 2020 07:10:30 +0200 From: Christoph Hellwig To: Russell King - ARM Linux admin Subject: Re: [PATCH 3/4] ARM/dma-mapping: don't handle NULL devices in dma-direct.h Message-ID: <20200918051030.GA21261@lst.de> References: <20200917173229.3311382-1-hch@lst.de> <20200917173229.3311382-4-hch@lst.de> <20200917185009.GB1559@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917185009.GB1559@shell.armlinux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_011033_941721_563291AF X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aaro Koskinen , Tony Lindgren , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-omap@vger.kernel.org, Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2020 at 07:50:10PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Sep 17, 2020 at 07:32:28PM +0200, Christoph Hellwig wrote: > > The DMA API removed support for not passing in a device a long time > > ago, so remove the NULL checks. > > What happens with ISA devices? For actual drivers they've been switched to struct isa_driver, which provides a struct device. For some of the special case like the arch/arm/kernel/dma-isa.c we now use static struct device instances. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel