From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E26AC43465 for ; Fri, 18 Sep 2020 10:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DDB021D24 for ; Fri, 18 Sep 2020 10:47:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GCp5nQJs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726154AbgIRKrA (ORCPT ); Fri, 18 Sep 2020 06:47:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbgIRKq7 (ORCPT ); Fri, 18 Sep 2020 06:46:59 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68CE6C06174A for ; Fri, 18 Sep 2020 03:46:59 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id b79so5059087wmb.4 for ; Fri, 18 Sep 2020 03:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QHJwfG6F4o4CDJIq3QihHGujfsirLPtmR49z41IlzGM=; b=GCp5nQJsngEU7CqhOSgeVeimfPACWUqBt1LffHhGAhS/1zxnqeAVa4HyswDnKVafjc LcOsFs75LdO+ayoBH4Cqlnez9CdpfLecVbqD3pYkANMG1cMxdHTsby2uZGVXIoeaDEAR UKBLLX5PxKq4MDMK7Pb5LqCTmkDbQq0O+DFCJLod0K9Pgj8Hx0/SeGS/gsZEMYghV8mL WjmHa2CguvnM78D7wz6RaDxOV4leyY4jtiNB4qrTNsermGjvXFBXEZlUaqzuFnsD2BTd 4pZnPDJuKvk409QUo110TgepQoGFwW76wa5Ox2yAPwKlzdhnKEIp74z0oga2K1h4+3w2 yMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QHJwfG6F4o4CDJIq3QihHGujfsirLPtmR49z41IlzGM=; b=sX7/G/BNjIH7GNya4qDwuVE7yYh6j8oRJPOkCwHzmtOy/JwcI5eU5rtW5hHBK30P1T i/T/jU23dCjLDxJJ8Mq8mON5naFnOl2NwMAPuRVlCS3ZRMYmwP+lx+MRixMs939hzGAf 6HGvFiDv9L8NF3Me4Qg712l8CzEGja0G60Kj+wuoDHP+V2E/XFl6snjFFJqDcgQDAmsJ MyfdTyQV+wiTvW+aNTd+KUDRLUu6lpyG79ySuqrIKHXg8H8cTrf915SoZxvRNDE6q7WU dr2hAokqj3pWPoS7ABUKOmSv9LL89Cn/QfAuejmqWctyq78j5vfX6MenjCXfh/rOYN80 uQzQ== X-Gm-Message-State: AOAM531zcqI3Qtt6G1ucTyQ3DM+YsleePaYaI8mdmezHCOrS450EKEDY yg1VYEyEWJ5Vmb6oVogXuJvghQ== X-Google-Smtp-Source: ABdhPJyAec62/MhHDgU9436e4r2tCBgX1RyhPIH/sMguzyT2/d+Y8t/P8XtIMeWU0KmORGk45uH90w== X-Received: by 2002:a1c:7e15:: with SMTP id z21mr14738241wmc.21.1600426016909; Fri, 18 Sep 2020 03:46:56 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id u17sm4317615wmm.4.2020.09.18.03.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 03:46:56 -0700 (PDT) Date: Fri, 18 Sep 2020 12:46:50 +0200 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 33/37] kasan, arm64: implement HW_TAGS runtime Message-ID: <20200918104650.GA2384246@elver.google.com> References: <74133d1a57c47cb8fec791dd5d1e6417b0579fc3.1600204505.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74133d1a57c47cb8fec791dd5d1e6417b0579fc3.1600204505.git.andreyknvl@google.com> User-Agent: Mutt/1.14.4 (2020-06-18) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: [...] > arch/arm64/include/asm/memory.h | 4 +- > arch/arm64/kernel/setup.c | 1 - > include/linux/kasan.h | 6 +-- > include/linux/mm.h | 2 +- > include/linux/page-flags-layout.h | 2 +- > mm/kasan/Makefile | 5 ++ > mm/kasan/common.c | 14 +++--- > mm/kasan/kasan.h | 17 +++++-- > mm/kasan/report_tags_hw.c | 47 +++++++++++++++++++ > mm/kasan/report_tags_sw.c | 2 +- > mm/kasan/shadow.c | 2 +- > mm/kasan/tags_hw.c | 78 +++++++++++++++++++++++++++++++ > mm/kasan/tags_sw.c | 2 +- > 13 files changed, 162 insertions(+), 20 deletions(-) > create mode 100644 mm/kasan/report_tags_hw.c > create mode 100644 mm/kasan/tags_hw.c [...] > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index 77c4c9bad1b8..5985be8af2c6 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -358,7 +358,6 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > smp_init_cpus(); > smp_build_mpidr_hash(); > > - /* Init percpu seeds for random tags after cpus are set up. */ Why was the comment removed and not updated? > kasan_init_tags(); > > #ifdef CONFIG_ARM64_SW_TTBR0_PAN From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0045BC43464 for ; Fri, 18 Sep 2020 10:48:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1DC421D24 for ; Fri, 18 Sep 2020 10:48:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SSpiN2Kd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="GCp5nQJs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1DC421D24 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zYWq7TF2pq4IPsFtWQ/8xUD6tgIaLZmJtlczxqoEVQI=; b=SSpiN2KdDP9cK3QQssNWLCabA Fk5fKPT7gS+oya4qSaXHU26jnxUiACQO83vC3faoAKfduD4rXvQ6xO9Rpe+FCB+5ty49Qd+VZ5PpF 2Z8L9Fckhn+L6CXZZaHwFe9x+4GtZOauXRXzvE4W2/rycsZ6CuhkMN4sFn3KVtpeRiUyZPk8GdPbp vujzFPEZDvAkOjYINPfus348BE9VjqRbCPXH2rDc6HnX50TwOelCsMTm0P6UX7d6fdb9UtREB9cAV qrAryQ8N/1DNhQhOawOnDbpGYVJ3j0J71AZtAvw2sDmdFDpF7fc9MegThUlcQfX+0Sf+RlygfFAn0 O9DAgHIPw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJDuw-000524-QI; Fri, 18 Sep 2020 10:47:02 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJDut-00050V-TC for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 10:47:01 +0000 Received: by mail-wm1-x343.google.com with SMTP id w2so4865119wmi.1 for ; Fri, 18 Sep 2020 03:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QHJwfG6F4o4CDJIq3QihHGujfsirLPtmR49z41IlzGM=; b=GCp5nQJsngEU7CqhOSgeVeimfPACWUqBt1LffHhGAhS/1zxnqeAVa4HyswDnKVafjc LcOsFs75LdO+ayoBH4Cqlnez9CdpfLecVbqD3pYkANMG1cMxdHTsby2uZGVXIoeaDEAR UKBLLX5PxKq4MDMK7Pb5LqCTmkDbQq0O+DFCJLod0K9Pgj8Hx0/SeGS/gsZEMYghV8mL WjmHa2CguvnM78D7wz6RaDxOV4leyY4jtiNB4qrTNsermGjvXFBXEZlUaqzuFnsD2BTd 4pZnPDJuKvk409QUo110TgepQoGFwW76wa5Ox2yAPwKlzdhnKEIp74z0oga2K1h4+3w2 yMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QHJwfG6F4o4CDJIq3QihHGujfsirLPtmR49z41IlzGM=; b=WnytOdDNd3Q65A3Jy05PL8EDk94L8TTI/pqnEdgPQAdZedg6c5P8Vll6Pv2lZLuY31 I7pDmofNeT6cE4BnJg8dOwfGSM2sGf/hf1MjwY3vuTexC2csvlnhN/2jWvFbWMYIyvsy +MQnOahH06YReiZLDrdAJ+Zsckjtg+gcqFN7lo4xZAGae75NXMXgtijN+nifi+GvJDSF KwH+cMqXBwR5zJJQD4jhdBpnYPo/q26/wGssD7R2vMxO0sz5qiQo9TBI9K6eTEe8NBEW NPpb1XPZTi5SfVtj8VE1VRsTvfBLc2mdUnxjImCL1p9v2ttoME107wZMwf7MU6VZts1P b2+A== X-Gm-Message-State: AOAM532rQxdQnCQlqXplqTx0wbHiFOhDq7zyohJqu4e8C5X/JsO+c/ey svl57qAPyG6I5XUJvLSVOpv1ZA== X-Google-Smtp-Source: ABdhPJyAec62/MhHDgU9436e4r2tCBgX1RyhPIH/sMguzyT2/d+Y8t/P8XtIMeWU0KmORGk45uH90w== X-Received: by 2002:a1c:7e15:: with SMTP id z21mr14738241wmc.21.1600426016909; Fri, 18 Sep 2020 03:46:56 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id u17sm4317615wmm.4.2020.09.18.03.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 03:46:56 -0700 (PDT) Date: Fri, 18 Sep 2020 12:46:50 +0200 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v2 33/37] kasan, arm64: implement HW_TAGS runtime Message-ID: <20200918104650.GA2384246@elver.google.com> References: <74133d1a57c47cb8fec791dd5d1e6417b0579fc3.1600204505.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <74133d1a57c47cb8fec791dd5d1e6417b0579fc3.1600204505.git.andreyknvl@google.com> User-Agent: Mutt/1.14.4 (2020-06-18) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_064659_998180_DB7ABE9C X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: [...] > arch/arm64/include/asm/memory.h | 4 +- > arch/arm64/kernel/setup.c | 1 - > include/linux/kasan.h | 6 +-- > include/linux/mm.h | 2 +- > include/linux/page-flags-layout.h | 2 +- > mm/kasan/Makefile | 5 ++ > mm/kasan/common.c | 14 +++--- > mm/kasan/kasan.h | 17 +++++-- > mm/kasan/report_tags_hw.c | 47 +++++++++++++++++++ > mm/kasan/report_tags_sw.c | 2 +- > mm/kasan/shadow.c | 2 +- > mm/kasan/tags_hw.c | 78 +++++++++++++++++++++++++++++++ > mm/kasan/tags_sw.c | 2 +- > 13 files changed, 162 insertions(+), 20 deletions(-) > create mode 100644 mm/kasan/report_tags_hw.c > create mode 100644 mm/kasan/tags_hw.c [...] > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index 77c4c9bad1b8..5985be8af2c6 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -358,7 +358,6 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > smp_init_cpus(); > smp_build_mpidr_hash(); > > - /* Init percpu seeds for random tags after cpus are set up. */ Why was the comment removed and not updated? > kasan_init_tags(); > > #ifdef CONFIG_ARM64_SW_TTBR0_PAN _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel