All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
@ 2020-09-19  7:12 ` Jing Xiangfeng
  0 siblings, 0 replies; 9+ messages in thread
From: Jing Xiangfeng @ 2020-09-19  7:12 UTC (permalink / raw)
  To: paulus, mpe, benh; +Cc: kvm-ppc, linuxppc-dev, linux-kernel, jingxiangfeng

The variable ret is being initialized with '-ENOMEM' that is meaningless.
So remove it.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
index 1a529df0ab44..b277a75cd1be 100644
--- a/arch/powerpc/kvm/book3s_64_vio.c
+++ b/arch/powerpc/kvm/book3s_64_vio.c
@@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
 	struct kvmppc_spapr_tce_table *siter;
 	struct mm_struct *mm = kvm->mm;
 	unsigned long npages, size = args->size;
-	int ret = -ENOMEM;
+	int ret;
 
 	if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
 		(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
@ 2020-09-19  7:12 ` Jing Xiangfeng
  0 siblings, 0 replies; 9+ messages in thread
From: Jing Xiangfeng @ 2020-09-19  7:12 UTC (permalink / raw)
  To: paulus, mpe, benh; +Cc: linuxppc-dev, linux-kernel, kvm-ppc, jingxiangfeng

The variable ret is being initialized with '-ENOMEM' that is meaningless.
So remove it.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
index 1a529df0ab44..b277a75cd1be 100644
--- a/arch/powerpc/kvm/book3s_64_vio.c
+++ b/arch/powerpc/kvm/book3s_64_vio.c
@@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
 	struct kvmppc_spapr_tce_table *siter;
 	struct mm_struct *mm = kvm->mm;
 	unsigned long npages, size = args->size;
-	int ret = -ENOMEM;
+	int ret;
 
 	if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
 		(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
@ 2020-09-19  7:12 ` Jing Xiangfeng
  0 siblings, 0 replies; 9+ messages in thread
From: Jing Xiangfeng @ 2020-09-19  7:12 UTC (permalink / raw)
  To: paulus, mpe, benh; +Cc: kvm-ppc, linuxppc-dev, linux-kernel, jingxiangfeng

The variable ret is being initialized with '-ENOMEM' that is meaningless.
So remove it.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 arch/powerpc/kvm/book3s_64_vio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
index 1a529df0ab44..b277a75cd1be 100644
--- a/arch/powerpc/kvm/book3s_64_vio.c
+++ b/arch/powerpc/kvm/book3s_64_vio.c
@@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
 	struct kvmppc_spapr_tce_table *siter;
 	struct mm_struct *mm = kvm->mm;
 	unsigned long npages, size = args->size;
-	int ret = -ENOMEM;
+	int ret;
 
 	if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
 		(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
  2020-09-19  7:12 ` Jing Xiangfeng
  (?)
@ 2020-09-21 13:43   ` Fabiano Rosas
  -1 siblings, 0 replies; 9+ messages in thread
From: Fabiano Rosas @ 2020-09-21 13:43 UTC (permalink / raw)
  To: Jing Xiangfeng, paulus, mpe, benh
  Cc: kvm-ppc, linuxppc-dev, linux-kernel, jingxiangfeng

Jing Xiangfeng <jingxiangfeng@huawei.com> writes:

> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Reviewed-by: Fabiano Rosas <farosas@linux.ibm.com>

> ---
>  arch/powerpc/kvm/book3s_64_vio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
> index 1a529df0ab44..b277a75cd1be 100644
> --- a/arch/powerpc/kvm/book3s_64_vio.c
> +++ b/arch/powerpc/kvm/book3s_64_vio.c
> @@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
>  	struct kvmppc_spapr_tce_table *siter;
>  	struct mm_struct *mm = kvm->mm;
>  	unsigned long npages, size = args->size;
> -	int ret = -ENOMEM;
> +	int ret;
>
>  	if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
>  		(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
@ 2020-09-21 13:43   ` Fabiano Rosas
  0 siblings, 0 replies; 9+ messages in thread
From: Fabiano Rosas @ 2020-09-21 13:43 UTC (permalink / raw)
  To: Jing Xiangfeng, paulus, mpe, benh
  Cc: linuxppc-dev, linux-kernel, kvm-ppc, jingxiangfeng

Jing Xiangfeng <jingxiangfeng@huawei.com> writes:

> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Reviewed-by: Fabiano Rosas <farosas@linux.ibm.com>

> ---
>  arch/powerpc/kvm/book3s_64_vio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
> index 1a529df0ab44..b277a75cd1be 100644
> --- a/arch/powerpc/kvm/book3s_64_vio.c
> +++ b/arch/powerpc/kvm/book3s_64_vio.c
> @@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
>  	struct kvmppc_spapr_tce_table *siter;
>  	struct mm_struct *mm = kvm->mm;
>  	unsigned long npages, size = args->size;
> -	int ret = -ENOMEM;
> +	int ret;
>
>  	if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
>  		(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
@ 2020-09-21 13:43   ` Fabiano Rosas
  0 siblings, 0 replies; 9+ messages in thread
From: Fabiano Rosas @ 2020-09-21 13:43 UTC (permalink / raw)
  To: Jing Xiangfeng, paulus, mpe, benh
  Cc: kvm-ppc, linuxppc-dev, linux-kernel, jingxiangfeng

Jing Xiangfeng <jingxiangfeng@huawei.com> writes:

> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Reviewed-by: Fabiano Rosas <farosas@linux.ibm.com>

> ---
>  arch/powerpc/kvm/book3s_64_vio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
> index 1a529df0ab44..b277a75cd1be 100644
> --- a/arch/powerpc/kvm/book3s_64_vio.c
> +++ b/arch/powerpc/kvm/book3s_64_vio.c
> @@ -283,7 +283,7 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
>  	struct kvmppc_spapr_tce_table *siter;
>  	struct mm_struct *mm = kvm->mm;
>  	unsigned long npages, size = args->size;
> -	int ret = -ENOMEM;
> +	int ret;
>
>  	if (!args->size || args->page_shift < 12 || args->page_shift > 34 ||
>  		(args->offset + args->size > (ULLONG_MAX >> args->page_shift)))

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
  2020-09-19  7:12 ` Jing Xiangfeng
  (?)
@ 2020-09-23  0:08   ` Paul Mackerras
  -1 siblings, 0 replies; 9+ messages in thread
From: Paul Mackerras @ 2020-09-23  0:08 UTC (permalink / raw)
  To: Jing Xiangfeng; +Cc: mpe, benh, kvm-ppc, linuxppc-dev, linux-kernel

On Sat, Sep 19, 2020 at 03:12:30PM +0800, Jing Xiangfeng wrote:
> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Thanks, applied.

Paul.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
@ 2020-09-23  0:08   ` Paul Mackerras
  0 siblings, 0 replies; 9+ messages in thread
From: Paul Mackerras @ 2020-09-23  0:08 UTC (permalink / raw)
  To: Jing Xiangfeng; +Cc: linuxppc-dev, linux-kernel, kvm-ppc

On Sat, Sep 19, 2020 at 03:12:30PM +0800, Jing Xiangfeng wrote:
> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Thanks, applied.

Paul.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret
@ 2020-09-23  0:08   ` Paul Mackerras
  0 siblings, 0 replies; 9+ messages in thread
From: Paul Mackerras @ 2020-09-23  0:08 UTC (permalink / raw)
  To: Jing Xiangfeng; +Cc: mpe, benh, kvm-ppc, linuxppc-dev, linux-kernel

On Sat, Sep 19, 2020 at 03:12:30PM +0800, Jing Xiangfeng wrote:
> The variable ret is being initialized with '-ENOMEM' that is meaningless.
> So remove it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Thanks, applied.

Paul.

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-09-23  0:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-19  7:12 [PATCH] KVM: PPC: Book3S: Remove redundant initialization of variable ret Jing Xiangfeng
2020-09-19  7:12 ` Jing Xiangfeng
2020-09-19  7:12 ` Jing Xiangfeng
2020-09-21 13:43 ` Fabiano Rosas
2020-09-21 13:43   ` Fabiano Rosas
2020-09-21 13:43   ` Fabiano Rosas
2020-09-23  0:08 ` Paul Mackerras
2020-09-23  0:08   ` Paul Mackerras
2020-09-23  0:08   ` Paul Mackerras

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.