All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: linux-leds@vger.kernel.org
Cc: "Pavel Machek" <pavel@ucw.cz>, "Dan Murphy" <dmurphy@ti.com>,
	"Marek Behún" <marek.behun@nic.cz>, NeilBrown <neilb@suse.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"H . Nikolaus Schaller" <hns@goldelico.com>
Subject: [PATCH leds + devicetree 05/13] leds: tca6507: do not set GPIO names
Date: Sun, 20 Sep 2020 00:15:40 +0200	[thread overview]
Message-ID: <20200919221548.29984-6-marek.behun@nic.cz> (raw)
In-Reply-To: <20200919221548.29984-1-marek.behun@nic.cz>

Do not set GPIO names. Let gpiolib determine GPIO names from the DT
property `gpio-line-names`.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: NeilBrown <neilb@suse.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: H. Nikolaus Schaller <hns@goldelico.com>
---
 drivers/leds/leds-tca6507.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index 3e01fe2510f7c..58dcbddfa0b27 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -197,7 +197,6 @@ struct tca6507_chip {
 	} leds[NUM_LEDS];
 #ifdef CONFIG_GPIOLIB
 	struct gpio_chip		gpio;
-	const char			*gpio_name[NUM_LEDS];
 	int				gpio_map[NUM_LEDS];
 #endif
 };
@@ -647,7 +646,6 @@ static int tca6507_probe_gpios(struct i2c_client *client,
 	for (i = 0; i < NUM_LEDS; i++)
 		if (pdata->leds.leds[i].name && pdata->leds.leds[i].flags) {
 			/* Configure as a gpio */
-			tca->gpio_name[gpios] = pdata->leds.leds[i].name;
 			tca->gpio_map[gpios] = i;
 			gpios++;
 		}
@@ -656,7 +654,6 @@ static int tca6507_probe_gpios(struct i2c_client *client,
 		return 0;
 
 	tca->gpio.label = "gpio-tca6507";
-	tca->gpio.names = tca->gpio_name;
 	tca->gpio.ngpio = gpios;
 	tca->gpio.base = pdata->gpio_base;
 	tca->gpio.owner = THIS_MODULE;
-- 
2.26.2


  parent reply	other threads:[~2020-09-19 22:15 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 22:15 [PATCH leds + devicetree 00/13] leds: tca6507 cleanup Marek Behún
2020-09-19 22:15 ` [PATCH leds + devicetree 01/13] leds: tca6507: Absorb platform data Marek Behún
2020-09-20 17:09   ` H. Nikolaus Schaller
2020-09-29 13:18   ` Linus Walleij
2020-09-19 22:15 ` [PATCH leds + devicetree 02/13] leds: tca6507: use fwnode API instead of OF Marek Behún
2020-09-19 22:31   ` Marek Behun
     [not found]   ` <BD25CCC6-343D-4624-9718-276B3C7C6510@goldelico.com>
2020-09-20 17:35     ` Marek Behun
2020-09-20 17:39       ` Marek Behun
2020-09-20 18:09         ` H. Nikolaus Schaller
2020-09-22 19:29           ` H. Nikolaus Schaller
2020-09-24 12:14             ` Pavel Machek
2020-09-19 22:15 ` [PATCH leds + devicetree 03/13] dt-bindings: leds: tca6507: convert to YAML Marek Behún
2020-09-29 16:56   ` Rob Herring
2020-09-30 16:59     ` Pavel Machek
2020-09-19 22:15 ` [PATCH leds + devicetree 04/13] ARM: dts: omap3: gta04: rename LED controlled subnodes Marek Behún
2020-09-30 17:00   ` Pavel Machek
2020-09-19 22:15 ` Marek Behún [this message]
2020-09-19 22:15 ` [PATCH leds + devicetree 06/13] leds: tca6507: cosmetic change: use helper variable Marek Behún
2020-09-30 17:01   ` Pavel Machek
2020-09-19 22:15 ` [PATCH leds + devicetree 07/13] leds: tca6507: register LEDs and GPIOs immediately after parsing Marek Behún
2020-09-19 22:15 ` [PATCH leds + devicetree 08/13] leds: tca6507: remove binding comment Marek Behún
2020-09-19 22:15 ` [PATCH leds + devicetree 09/13] leds: tca6507: use devres for LED and gpiochip registration Marek Behún
2020-09-19 22:15 ` [PATCH leds + devicetree 10/13] leds: tca6507: let gpiolib set gpiochip's of_node Marek Behún
2020-09-19 22:15 ` [PATCH leds + devicetree 11/13] leds: tca6507: fail on reg value conflict Marek Behún
2020-09-30 17:01   ` Pavel Machek
2020-09-19 22:15 ` [PATCH leds + devicetree 12/13] leds: tca6507: set registers to zero before LEDs/GPIOs registration Marek Behún
2020-09-19 22:15 ` [PATCH leds + devicetree 13/13] leds: tca6507: use struct led_init_data when registering Marek Behún
2020-09-25  6:49   ` Jacek Anaszewski
2020-09-25 14:36     ` Marek Behun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200919221548.29984-6-marek.behun@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=dmurphy@ti.com \
    --cc=hns@goldelico.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.