From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CB0C43465 for ; Mon, 21 Sep 2020 02:09:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49E122076B for ; Mon, 21 Sep 2020 02:09:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726428AbgIUCJh (ORCPT ); Sun, 20 Sep 2020 22:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbgIUCJh (ORCPT ); Sun, 20 Sep 2020 22:09:37 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 213EBC061755; Sun, 20 Sep 2020 19:09:37 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 519C013D74AB2; Sun, 20 Sep 2020 18:52:49 -0700 (PDT) Date: Sun, 20 Sep 2020 19:09:36 -0700 (PDT) Message-Id: <20200920.190936.692148593394247602.davem@davemloft.net> To: Julia.Lawall@inria.fr Cc: santosh.shilimkar@oracle.com, kernel-janitors@vger.kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/14] RDS: drop double zeroing From: David Miller In-Reply-To: <1600601186-7420-8-git-send-email-Julia.Lawall@inria.fr> References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> <1600601186-7420-8-git-send-email-Julia.Lawall@inria.fr> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Sun, 20 Sep 2020 18:52:49 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Julia Lawall Date: Sun, 20 Sep 2020 13:26:19 +0200 > sg_init_table zeroes its first argument, so the allocation of that argument > doesn't have to. > > the semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x,n,flags; > @@ > > x = > - kcalloc > + kmalloc_array > (n,sizeof(*x),flags) > ... > sg_init_table(x,n) > // > > Signed-off-by: Julia Lawall Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Mon, 21 Sep 2020 02:09:36 +0000 Subject: Re: [PATCH 07/14] RDS: drop double zeroing Message-Id: <20200920.190936.692148593394247602.davem@davemloft.net> List-Id: References: <1600601186-7420-1-git-send-email-Julia.Lawall@inria.fr> <1600601186-7420-8-git-send-email-Julia.Lawall@inria.fr> In-Reply-To: <1600601186-7420-8-git-send-email-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia.Lawall@inria.fr Cc: santosh.shilimkar@oracle.com, kernel-janitors@vger.kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org From: Julia Lawall Date: Sun, 20 Sep 2020 13:26:19 +0200 > sg_init_table zeroes its first argument, so the allocation of that argument > doesn't have to. > > the semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x,n,flags; > @@ > > x = > - kcalloc > + kmalloc_array > (n,sizeof(*x),flags) > ... > sg_init_table(x,n) > // > > Signed-off-by: Julia Lawall Applied.