From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D790CC43464 for ; Mon, 21 Sep 2020 07:35:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 358A622574 for ; Mon, 21 Sep 2020 07:35:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 358A622574 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5BC956E1A2; Mon, 21 Sep 2020 07:34:51 +0000 (UTC) X-Greylist: delayed 1055 seconds by postgrey-1.36 at gabe; Sun, 20 Sep 2020 02:17:26 UTC Received: from r3-25.sinamail.sina.com.cn (r3-25.sinamail.sina.com.cn [202.108.3.25]) by gabe.freedesktop.org (Postfix) with SMTP id 078FB6E090 for ; Sun, 20 Sep 2020 02:17:25 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([222.131.67.153]) by sina.com with ESMTP id 5F66BBB10001C927; Sun, 20 Sep 2020 10:17:22 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 99065454919473 From: Hillf Danton To: Rob Clark Subject: Re: [PATCH 3/3] drm: Add a client-cap to set scheduling mode Date: Sun, 20 Sep 2020 10:17:11 +0800 Message-Id: <20200920021711.9180-1-hdanton@sina.com> In-Reply-To: <20200919193727.2093945-4-robdclark@gmail.com> References: <20200919193727.2093945-1-robdclark@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 21 Sep 2020 07:34:44 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Hillf Danton , Peter Zijlstra , linux-arm-msm@vger.kernel.org, LKML , timmurray@google.com, David Airlie , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Tejun Heo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 19 Sep 2020 12:37:26 -0700 Rob Clark wrote: > +/** > + * drm_crtc_set_sched_mode: > + * @dev: DRM device > + * @mode: one of DRM_CLIENT_CAP_SCHED_x > + * > + * Set the scheduling mode for per-CRTC kthread workers. This controls > + * whether nonblocking atomic commits will run with SCHED_NORMAL or > + * SCHED_FIFO (rt) priority. > + */ > +void drm_crtc_set_sched_mode(struct drm_device *dev, int mode) > +{ > + struct drm_crtc *crtc; > + > + drm_for_each_crtc(crtc, dev) { > + switch (mode) { > + case DRM_CLIENT_CAP_SCHED_NORMAL: > + /* zero is default nice value for kthreads: */ > + sched_set_normal(crtc->worker->task, 0); > + break; > + case DRM_CLIENT_CAP_SCHED_FIFO: > + sched_set_fifo(crtc->worker->task); > + break; Better if they are done in kernel/kthread.c wrt FIFO worker. Off-topic: if that's fine, what's preventing you from doing the same in kernel/workqueue.c for the workqueus you create manually? _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel