From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8762AC43463 for ; Mon, 21 Sep 2020 06:50:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 485BE2084C for ; Mon, 21 Sep 2020 06:50:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbgIUGuC (ORCPT ); Mon, 21 Sep 2020 02:50:02 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:49368 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbgIUGuC (ORCPT ); Mon, 21 Sep 2020 02:50:02 -0400 Received: from dread.disaster.area (pa49-195-191-192.pa.nsw.optusnet.com.au [49.195.191.192]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 5F957826276; Mon, 21 Sep 2020 16:50:00 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1kKFeB-0006jb-F8; Mon, 21 Sep 2020 16:49:59 +1000 Date: Mon, 21 Sep 2020 16:49:59 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v3 3/2] xfs: don't release log intent items when recovery fails Message-ID: <20200921064959.GM12131@dread.disaster.area> References: <160031332353.3624373.16349101558356065522.stgit@magnolia> <20200918021702.GV7955@magnolia> <20200918021940.GW7955@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200918021940.GW7955@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=DKXxHBFb c=1 sm=1 tr=0 cx=a_idp_d a=vvDRHhr1aDYKXl+H6jx2TA==:117 a=vvDRHhr1aDYKXl+H6jx2TA==:17 a=kj9zAlcOel0A:10 a=reM5J-MqmosA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=_E9kGMUcFyByM8kbvLEA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Sep 17, 2020 at 07:19:40PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Nowadays, log recovery will call ->release on the recovered intent items > if recovery fails. Therefore, it's redundant to release them from > inside the ->recover functions when they're about to return an error. > > Signed-off-by: Darrick J. Wong > --- > v3: fix subject line > v2: log recovery frees unfinished intent items on failure, so remove > release calls > --- > fs/xfs/xfs_bmap_item.c | 12 ++---------- > fs/xfs/xfs_extfree_item.c | 8 +------- > fs/xfs/xfs_refcount_item.c | 8 +------- > fs/xfs/xfs_rmap_item.c | 8 +------- > 4 files changed, 5 insertions(+), 31 deletions(-) looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com