From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB14C43464 for ; Mon, 21 Sep 2020 09:12:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8810020773 for ; Mon, 21 Sep 2020 09:12:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AsxFkS/h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8810020773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKHrv-000592-Hb for qemu-devel@archiver.kernel.org; Mon, 21 Sep 2020 05:12:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKHqW-0004J3-0e for qemu-devel@nongnu.org; Mon, 21 Sep 2020 05:10:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKHqU-0007as-7I for qemu-devel@nongnu.org; Mon, 21 Sep 2020 05:10:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600679449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mmz1buBQ+LQ6S/L28zcq+Pfxcxn99IXVH24Dn4zPQxE=; b=AsxFkS/hgf57OrT4+ivzMCXFn3l2EVzcV2FGQ/jp5APWfIolYMvhkIxAIjHtBBcu4Ezcxe Q5EjJJr7Xb1aLshEipqpsT4xOretclPo2EDZHqEAAPLDGRc3IIPWINmI16V1bNmlGn8vfC B2sraJI5edBrbHFEELvqn7QrrJJsiYg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-YeZ0otIlPCOOoKYKW7IAGA-1; Mon, 21 Sep 2020 05:10:47 -0400 X-MC-Unique: YeZ0otIlPCOOoKYKW7IAGA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 418AB6414B; Mon, 21 Sep 2020 09:10:46 +0000 (UTC) Received: from work-vm (ovpn-114-207.ams2.redhat.com [10.36.114.207]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 070553782; Mon, 21 Sep 2020 09:10:37 +0000 (UTC) Date: Mon, 21 Sep 2020 10:10:34 +0100 From: "Dr. David Alan Gilbert" To: Stefan Hajnoczi Subject: Re: [PATCH] virtiofsd: document cache=auto default Message-ID: <20200921091034.GC3221@work-vm> References: <20200916112250.760245-1-stefanha@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200916112250.760245-1-stefanha@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/21 01:43:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.501, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, "Harry G. Coin" , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Stefan Hajnoczi (stefanha@redhat.com) wrote: > From: "Harry G. Coin" > > The virtiofsd --help output documents the cache=auto default value but > the man page does not. Fix this. > > Signed-off-by: Harry G. Coin > Signed-off-by: Stefan Hajnoczi Reviewed-by: Dr. David Alan Gilbert Thanks, I'll add it to the next pull. Dave > --- > docs/tools/virtiofsd.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst > index e33c81ed41..352a29ce3c 100644 > --- a/docs/tools/virtiofsd.rst > +++ b/docs/tools/virtiofsd.rst > @@ -103,6 +103,7 @@ Options > forbids the FUSE client from caching to achieve best coherency at the cost of > performance. ``auto`` acts similar to NFS with a 1 second metadata cache > timeout. ``always`` sets a long cache lifetime at the expense of coherency. > + The default is ``auto``. > > Examples > -------- > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 21 Sep 2020 10:10:34 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20200921091034.GC3221@work-vm> References: <20200916112250.760245-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916112250.760245-1-stefanha@redhat.com> Subject: Re: [Virtio-fs] [PATCH] virtiofsd: document cache=auto default List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org * Stefan Hajnoczi (stefanha@redhat.com) wrote: > From: "Harry G. Coin" > > The virtiofsd --help output documents the cache=auto default value but > the man page does not. Fix this. > > Signed-off-by: Harry G. Coin > Signed-off-by: Stefan Hajnoczi Reviewed-by: Dr. David Alan Gilbert Thanks, I'll add it to the next pull. Dave > --- > docs/tools/virtiofsd.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst > index e33c81ed41..352a29ce3c 100644 > --- a/docs/tools/virtiofsd.rst > +++ b/docs/tools/virtiofsd.rst > @@ -103,6 +103,7 @@ Options > forbids the FUSE client from caching to achieve best coherency at the cost of > performance. ``auto`` acts similar to NFS with a 1 second metadata cache > timeout. ``always`` sets a long cache lifetime at the expense of coherency. > + The default is ``auto``. > > Examples > -------- > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK