From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C1CC43463 for ; Mon, 21 Sep 2020 09:39:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86E8F2158C for ; Mon, 21 Sep 2020 09:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600681148; bh=FB9gmrtsPTmm2+oEdcUPVmACiV0h7uL+URx6rj0YMDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NVW7j+yLHZIHgcm4JJF6TUZ3NZyE303b8Q+bGGFtFy8Yt8ZYPTvk8rs07zdUGk9WI EYN+kbrZzHGUMGKuLnRPu+1z600aEnlumgQVBIm3gSRI9oLDoi0G4q4pwBIrcUHSjU NLJfbl0y+/rduBdsEbL7rfHCusxBld8BBp4s92YU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbgIUJjI (ORCPT ); Mon, 21 Sep 2020 05:39:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:59828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726474AbgIUJjH (ORCPT ); Mon, 21 Sep 2020 05:39:07 -0400 Received: from localhost (p5486cf2a.dip0.t-ipconnect.de [84.134.207.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C1002151B; Mon, 21 Sep 2020 09:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600681146; bh=FB9gmrtsPTmm2+oEdcUPVmACiV0h7uL+URx6rj0YMDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHc0Uz13XkSIy8AQVkBJwIgP1suUUXe1ytVxn32kA4FSnYQsTT6Wd6ETrayDF2SRU SR4bHvmrRyEeqcwU/6AilZkh3q7XHaa6EcLzGv8nSrMOZjqL0d3UFLls2S9GQBUHxj mhPOhzl3Txg0ze3J34vdfwUFjohjmipI0AEbOO0s= Date: Mon, 21 Sep 2020 11:39:03 +0200 From: Wolfram Sang To: "Mukesh, Savaliya" Cc: Barry Song , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, Gregory CLEMENT , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , Akash Asthana , Andy Gross , Bjorn Andersson Subject: Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ Message-ID: <20200921093903.GI1840@ninjato> References: <20200909041001.5612-1-song.bao.hua@hisilicon.com> <268c12c2-c72d-809c-9ecc-520ef274c1c3@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LYw3s/afESlflPpp" Content-Disposition: inline In-Reply-To: <268c12c2-c72d-809c-9ecc-520ef274c1c3@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --LYw3s/afESlflPpp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 10, 2020 at 11:48:02PM +0530, Mukesh, Savaliya wrote: >=20 > On 9/9/2020 9:40 AM, Barry Song wrote: > > The code has been in a irq-disabled context since it is hard IRQ. There > > is no necessity to do it again. > >=20 > > Cc: Gregory CLEMENT > > Cc: "Andreas F=C3=A4rber" > > Cc: Manivannan Sadhasivam > > Cc: Akash Asthana > > Cc: Mukesh Savaliya > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Signed-off-by: Barry Song > > --- > Reviewed-by: Mukesh Kumar Savaliya Thanks! Did you review the whole patch or only the qcom-geni part? (and please don't include the full message when you only reply to a part of it). --LYw3s/afESlflPpp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl9odLMACgkQFA3kzBSg KbYMgRAAr7VDQjXeRo9RUQBho8zeCTQYGoeDV/CgZsNbMfA1PTDQ8cCDs5zSNLV6 6BY6597BhKIXrjuiV/5ROCW+VKNbvhVl73KQfeGPlY9JSoR+al93Xijb4YneFjjK x7GH9p/Tx9O+Y50LHQOAG5xuLLNurSjKlAXSpI4anZwt0BYP9lqoYl20sUZ10MdY LnYT9jgJyc1ImQVoCKBwEkUzglvcHuyZUl7fsI3VFSSAZAc9mayMfrvOKgTgJD9H jAoXhU0xIg+bBZI/kdnj0W6S+/AUU9XJJ3bHwdlGZGtpQ9G3wABIpo5GPPXDNAMU Hc6LXEAaHLWRgkA76Btia7At3UXhIng+fb6MXXdiNq2n7Q66CLEFMUua3Wm1f+86 h13gCbSsz9Yw80JKw1QFSMBzHcXYSpp4hYXJxqtqaThgSfK5htfB93W7zSn0EP1A 8G3BYvYd3JoxQXs6GZRNlAYYvJSGlZ9a/fp9bCMHY5WorxGrOSVBqiOTPTVHeLt9 ewli/CRZhKYgXGgS/Z9gyme5sHrqWlKvtAxKa8ZeO4eMsYKGGFv2WxJAHMJRaONr Ui/PNlY0fHvQwIap3VdBS4wSB5O9M7nv+lFxYo6lEX6hkhOXy9uh6r5sehh475Ho vb2QhGQDxOIEa3HhmOHdQ9DYHentKi16gQRyN2coQUr9r16wWiM= =JACI -----END PGP SIGNATURE----- --LYw3s/afESlflPpp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C067C43463 for ; Mon, 21 Sep 2020 09:40:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBBEA2151B for ; Mon, 21 Sep 2020 09:40:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KE0L33Um"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cHc0Uz13" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBBEA2151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lCaXCSovoD2pTa4YtRQwyEXoMwvAWZrJUm/mLq9qsC0=; b=KE0L33UmqVW3h/LZzoT5p7bDu EmoYn8eyGywa1e/49L6gmUvpjoqmA/lWU4ZiTGukXcS5G/m1BFe5k3zrICCCmHUm8/gr/zRxdZtWT t1X+6ccxk80awnFProO7v4GYcdiFZXc+ydmaZFwmp3rAgX3FHiLMwzqfkFNPC7EHHALFg+pEiHNSA BJF6alPA5XPx4Yc8ccf8UFKPjWeCfYvcgzh0O/u9h7zC7XuneR4WheLKn9DI2ilbr0xgbR/6354OF RqEInDcLX67WAdAfHJmw6zCb9EJ6saRxtQlHm3H/H/Ub77Du1abEkQ5AFr3mY3aSZSrlh1DaF9gzj T0ImGX7Cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKIHu-00010C-Ho; Mon, 21 Sep 2020 09:39:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKIHs-0000zh-45 for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 09:39:08 +0000 Received: from localhost (p5486cf2a.dip0.t-ipconnect.de [84.134.207.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C1002151B; Mon, 21 Sep 2020 09:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600681146; bh=FB9gmrtsPTmm2+oEdcUPVmACiV0h7uL+URx6rj0YMDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHc0Uz13XkSIy8AQVkBJwIgP1suUUXe1ytVxn32kA4FSnYQsTT6Wd6ETrayDF2SRU SR4bHvmrRyEeqcwU/6AilZkh3q7XHaa6EcLzGv8nSrMOZjqL0d3UFLls2S9GQBUHxj mhPOhzl3Txg0ze3J34vdfwUFjohjmipI0AEbOO0s= Date: Mon, 21 Sep 2020 11:39:03 +0200 From: Wolfram Sang To: "Mukesh, Savaliya" Subject: Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ Message-ID: <20200921093903.GI1840@ninjato> References: <20200909041001.5612-1-song.bao.hua@hisilicon.com> <268c12c2-c72d-809c-9ecc-520ef274c1c3@codeaurora.org> MIME-Version: 1.0 In-Reply-To: <268c12c2-c72d-809c-9ecc-520ef274c1c3@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_053908_245086_FD8D023D X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Gregory CLEMENT , linuxarm@huawei.com, Bjorn Andersson , Akash Asthana , Andy Gross , linux-i2c@vger.kernel.org, Manivannan Sadhasivam , Andreas =?utf-8?Q?F=C3=A4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8373546646066812692==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8373546646066812692== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LYw3s/afESlflPpp" Content-Disposition: inline --LYw3s/afESlflPpp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 10, 2020 at 11:48:02PM +0530, Mukesh, Savaliya wrote: >=20 > On 9/9/2020 9:40 AM, Barry Song wrote: > > The code has been in a irq-disabled context since it is hard IRQ. There > > is no necessity to do it again. > >=20 > > Cc: Gregory CLEMENT > > Cc: "Andreas F=C3=A4rber" > > Cc: Manivannan Sadhasivam > > Cc: Akash Asthana > > Cc: Mukesh Savaliya > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Signed-off-by: Barry Song > > --- > Reviewed-by: Mukesh Kumar Savaliya Thanks! Did you review the whole patch or only the qcom-geni part? (and please don't include the full message when you only reply to a part of it). --LYw3s/afESlflPpp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl9odLMACgkQFA3kzBSg KbYMgRAAr7VDQjXeRo9RUQBho8zeCTQYGoeDV/CgZsNbMfA1PTDQ8cCDs5zSNLV6 6BY6597BhKIXrjuiV/5ROCW+VKNbvhVl73KQfeGPlY9JSoR+al93Xijb4YneFjjK x7GH9p/Tx9O+Y50LHQOAG5xuLLNurSjKlAXSpI4anZwt0BYP9lqoYl20sUZ10MdY LnYT9jgJyc1ImQVoCKBwEkUzglvcHuyZUl7fsI3VFSSAZAc9mayMfrvOKgTgJD9H jAoXhU0xIg+bBZI/kdnj0W6S+/AUU9XJJ3bHwdlGZGtpQ9G3wABIpo5GPPXDNAMU Hc6LXEAaHLWRgkA76Btia7At3UXhIng+fb6MXXdiNq2n7Q66CLEFMUua3Wm1f+86 h13gCbSsz9Yw80JKw1QFSMBzHcXYSpp4hYXJxqtqaThgSfK5htfB93W7zSn0EP1A 8G3BYvYd3JoxQXs6GZRNlAYYvJSGlZ9a/fp9bCMHY5WorxGrOSVBqiOTPTVHeLt9 ewli/CRZhKYgXGgS/Z9gyme5sHrqWlKvtAxKa8ZeO4eMsYKGGFv2WxJAHMJRaONr Ui/PNlY0fHvQwIap3VdBS4wSB5O9M7nv+lFxYo6lEX6hkhOXy9uh6r5sehh475Ho vb2QhGQDxOIEa3HhmOHdQ9DYHentKi16gQRyN2coQUr9r16wWiM= =JACI -----END PGP SIGNATURE----- --LYw3s/afESlflPpp-- --===============8373546646066812692== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8373546646066812692==--