From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: vijayakannan.ayyathurai@intel.com, thierry.reding@gmail.com,
robh+dt@kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org,
wan.ahmad.zainie.wan.mohamad@intel.com, mgross@linux.intel.com,
lakshmi.bai.raja.subramanian@intel.com
Subject: Re: [PATCH v7 2/2] dt-bindings: pwm: keembay: Add bindings for Intel Keem Bay PWM
Date: Mon, 21 Sep 2020 13:37:56 +0300 [thread overview]
Message-ID: <20200921103756.GP3956970@smile.fi.intel.com> (raw)
In-Reply-To: <20200921084401.gtesjzentxrly47c@pengutronix.de>
On Mon, Sep 21, 2020 at 10:44:01AM +0200, Uwe Kleine-König wrote:
> On Thu, Sep 10, 2020 at 12:27:19AM +0800, vijayakannan.ayyathurai@intel.com wrote:
> > From: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
> >
> > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC.
> >
> > Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com>
> > Signed-off-by: Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> nitpick: Your S-o-b should always be last. This way it becomes clear who
> added the other tags.
I think it should reflect chronological order. If SoB has been given before
e.g. Ack then SoB should be followed by Ack and not other way around.
But it's my interpretation of the chapter 12. Actually it doesn't say anything
about placement (ordering) of Ack.
So, formally the above follows the letter of law.
What did you have in mind when commenting that? Perhaps I missed documentation.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-21 10:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 16:27 [PATCH v7 0/2] Add PWM support for Intel Keem Bay SoC vijayakannan.ayyathurai
2020-09-09 16:27 ` [PATCH v7 1/2] pwm: Add PWM driver for Intel Keem Bay vijayakannan.ayyathurai
2020-09-21 8:34 ` Uwe Kleine-König
2020-09-09 16:27 ` [PATCH v7 2/2] dt-bindings: pwm: keembay: Add bindings for Intel Keem Bay PWM vijayakannan.ayyathurai
2020-09-21 8:44 ` Uwe Kleine-König
2020-09-21 10:37 ` Andy Shevchenko [this message]
2020-09-22 6:34 ` Uwe Kleine-König
2020-09-22 8:55 ` Andy Shevchenko
2020-09-17 20:59 ` [PATCH v7 0/2] Add PWM support for Intel Keem Bay SoC mark gross
2020-09-18 6:49 ` Ayyathurai, Vijayakannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921103756.GP3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-pwm@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vijayakannan.ayyathurai@intel.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.