From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kKJwY-0000xN-CS for mharc-grub-devel@gnu.org; Mon, 21 Sep 2020 07:25:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKJwX-0000xH-Fa for grub-devel@gnu.org; Mon, 21 Sep 2020 07:25:13 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33158) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKJwV-0008UY-MI for grub-devel@gnu.org; Mon, 21 Sep 2020 07:25:13 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08LBOb7i090162; Mon, 21 Sep 2020 11:25:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=7wv0rhZwFFjMj8E6WNur4l90UX4D7FFdMvGoQOmT0IQ=; b=Fm34Oq9uwpEYOOlG9vicGOeEzCIZ22/TgCVnM3f1JY8i0LN0+TKM529YAeL/czmW+wu6 QBhodDg3Hs+1LzBD4dtHClVhsLYfeRyeAGhOFUQknczYCZV0oasBU9H7QoVO3EiLb3Mc 1PkrxepM/aa8zSMO+EBVEgjhWPtrdFNws05EKW0FZxeJW5s5j5oULjydPxvfyoMfdEdk wBsxvqc6W4yn9YfUBhuadXtFaP0OPHo8m75IZiS7ExOJQxoiNhS1Gw1Z6ecrsUB/nsYR xdze52U97qaJWW70D7yZlU+zbeEChMXWJY2aRGsA7UAc2DNItjTwvnQ+OG5G3F+sAzhI kA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 33ndnu4swx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Sep 2020 11:25:04 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08LBJnMJ069432; Mon, 21 Sep 2020 11:25:04 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 33nuw0jggv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Sep 2020 11:25:03 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08LBP2oR007084; Mon, 21 Sep 2020 11:25:02 GMT Received: from tomti.i.net-space.pl (/10.175.223.167) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 Sep 2020 04:25:02 -0700 Date: Mon, 21 Sep 2020 13:24:56 +0200 From: Daniel Kiper To: Glenn Washburn Cc: Patrick Steinhardt , grub-devel@gnu.org, Denis GNUtoo Carikli Subject: Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages Message-ID: <20200921112456.av75jpdetd6xrhp2@tomti.i.net-space.pl> References: <20200908125833.veiqznw47a23dxc5@tomti.i.net-space.pl> <82757e18-992e-4bfd-a5a0-ac96e5a497ed@efficientek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82757e18-992e-4bfd-a5a0-ac96e5a497ed@efficientek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009210084 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009210085 Received-SPF: pass client-ip=156.151.31.85; envelope-from=daniel.kiper@oracle.com; helo=userp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/21 07:25:10 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -58 X-Spam_score: -5.9 X-Spam_bar: ----- X-Spam_report: (-5.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 11:25:13 -0000 On Mon, Sep 21, 2020 at 06:45:04AM +0000, Glenn Washburn wrote: > Sep 8, 2020 6:58:48 AM Daniel Kiper : > > On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: > >> From: Glenn Washburn > > > > It seems to me this patch should be split into two and and begs for > > commit message improvement. In general it would be nice to know why > > we need these fixes. > > This patch is doing two things, fixing a bug and making the code more > understandable. My original patch just fixed the bug, then Patrick > suggested making it more readable. I can split it into two patches. That will be perfect! Daniel