From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kKJzF-0001dB-P6 for mharc-grub-devel@gnu.org; Mon, 21 Sep 2020 07:28:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKJzD-0001cu-Jx for grub-devel@gnu.org; Mon, 21 Sep 2020 07:27:59 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:51180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKJzB-0000UU-S2 for grub-devel@gnu.org; Mon, 21 Sep 2020 07:27:59 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08LBO0Bd145770; Mon, 21 Sep 2020 11:27:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=soGwKtbX3JDsE0By1q6HkoJo40MiZx8IXLgCP+MLmRI=; b=JDBNGts/Zq+jggnKtnValw+8oS7kwwwd71E+DHLt9fwXPBGRK1augHyAIdNP22UQkSXi f73wSQlLZguc6tWGBR3lOwW3njaVuojOeKdhlogAz3lZvOW9fqzJexpMCnoIPLhDp64B Ljx1FqWNw3IudkuKGd1Clg+2WqzV9AxRlzvTQ2WP34qARde4mTb5UP8iTtq6a610WpA5 rplq6JKwrX39MKaucByb0bJJHiqJCH4QoEIaP7lpxxNGM1OiMG9cibiaLf75T4c+APcm 2zBv+9O9LINOV6uNJgvPShS3KC3AzS5pSf7QHWnU4lKhdOXkO3y5Eehip3eWwtZfnegb UQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 33n9dqw3c8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Sep 2020 11:27:53 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08LBKHVY025769; Mon, 21 Sep 2020 11:25:52 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 33nujkj2cw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Sep 2020 11:25:52 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08LBPpdd007429; Mon, 21 Sep 2020 11:25:51 GMT Received: from tomti.i.net-space.pl (/10.175.223.167) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 21 Sep 2020 04:25:50 -0700 Date: Mon, 21 Sep 2020 13:25:46 +0200 From: Daniel Kiper To: Glenn Washburn Cc: Patrick Steinhardt , grub-devel@gnu.org, Denis GNUtoo Carikli Subject: Re: [PATCH v3 6/9] cryptodisk: Unregister cryptomount command when removing module Message-ID: <20200921112546.44jlhc36sumywqum@tomti.i.net-space.pl> References: <7ef38470b44756db74928b0ade215b566503ef0f.1599492346.git.ps@pks.im> <20200908132803.47zheuofojcvpc6u@tomti.i.net-space.pl> <8cd30ba6-53d2-43f9-afff-90caa0f1c690@efficientek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8cd30ba6-53d2-43f9-afff-90caa0f1c690@efficientek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009210084 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 phishscore=0 priorityscore=1501 malwarescore=0 mlxscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009210085 Received-SPF: pass client-ip=156.151.31.86; envelope-from=daniel.kiper@oracle.com; helo=userp2130.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/21 07:23:16 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -58 X-Spam_score: -5.9 X-Spam_bar: ----- X-Spam_report: (-5.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 11:27:59 -0000 On Mon, Sep 21, 2020 at 06:45:57AM +0000, Glenn Washburn wrote: > Sep 8, 2020 7:28:13 AM Daniel Kiper : > > On Mon, Sep 07, 2020 at 05:27:55PM +0200, Patrick Steinhardt wrote: > >> From: Glenn Washburn > >> > >> Signed-off-by: Glenn Washburn > >> Reviewed-by: Patrick Steinhardt > >> --- > >> grub-core/disk/cryptodisk.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c > >> index 1897acc4b..b2c6e9a7d 100644 > >> --- a/grub-core/disk/cryptodisk.c > >> +++ b/grub-core/disk/cryptodisk.c > >> @@ -1311,5 +1311,6 @@ GRUB_MOD_FINI (cryptodisk) > >> { > >> grub_disk_dev_unregister (&grub_cryptodisk_dev); > >> cryptodisk_cleanup (); > > > > I am OK with this patch but I realized that cryptodisk_cleanup() body is > > commented out, So, could you add another patch which drops > > cryptodisk_cleanup() entirely from the GRUB code? Or make it work as it > > supposed to work. Maybe the latter is better... > > > > Daniel > > > > I can look in to this when I get to the other changes. OK... Daniel