From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45FFEC43463 for ; Mon, 21 Sep 2020 12:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A271207BC for ; Mon, 21 Sep 2020 12:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbgIUMlK (ORCPT ); Mon, 21 Sep 2020 08:41:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47220 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbgIUMlK (ORCPT ); Mon, 21 Sep 2020 08:41:10 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kKL7x-00Fakz-KH; Mon, 21 Sep 2020 14:41:05 +0200 Date: Mon, 21 Sep 2020 14:41:05 +0200 From: Andrew Lunn To: Vasundhara Volam Cc: mkubecek@suse.cz, davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, michael.chan@broadcom.com, edwin.peer@broadcom.com, andrew.gospodarek@broadcom.com Subject: Re: [PATCH ethtool] bnxt: Add Broadcom driver support. Message-ID: <20200921124105.GD3702050@lunn.ch> References: <1600670391-5533-1-git-send-email-vasundhara-v.volam@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600670391-5533-1-git-send-email-vasundhara-v.volam@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +struct bnxt_pcie_stat { > + const char *name; > + u16 offset; > + u8 size; > + const char *format; > +}; > + > +static const struct bnxt_pcie_stat bnxt_pcie_stats[] = { > + { .name = "PL Signal integrity errors ", .offset = 0, .size = 4, .format = "%lld" }, > + { .name = "DL Signal integrity errors ", .offset = 4, .size = 4, .format = "%lld" }, > + { .name = "TLP Signal integrity errors ", .offset = 8, .size = 4, .format = "%lld" }, These look like statistics. Could they be part of ethtool -S Andrew