From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B48C43465 for ; Mon, 21 Sep 2020 16:34:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EBD023976 for ; Mon, 21 Sep 2020 16:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706065; bh=zPaXF53HJOhCMm4iH+1r//KMldENlKCw7dZCzzwKWwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hErlVsID+sZ114VzXCBa5xO5jbILpuUoV1Vo9Qto0RUWgE3bkNHdZz9n6P3TEUUNL bt5urYChDHpO5qoAKcAXtIPXcRrATwiIN13cGcAuYKReTwCtbLrrvdjcBot3YoZ7ZS PKyfmPEaE/CFS+HhzaJYqafXFIVdGJ7MmWiFGaf8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbgIUQeN (ORCPT ); Mon, 21 Sep 2020 12:34:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:60240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728667AbgIUQdt (ORCPT ); Mon, 21 Sep 2020 12:33:49 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C759423976; Mon, 21 Sep 2020 16:33:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706029; bh=zPaXF53HJOhCMm4iH+1r//KMldENlKCw7dZCzzwKWwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=go9Qr9TUpWAyec1mTmXG83Ysx2aUUHk7M9xDh898azvRt+PfpT0u35B1F1ytAS3zb nAFub8dlO6rKhtRu/m36b+OaXIWkOe432aJqFQJ91hX9fpCf4gtFSInMcfgTLeoldf lbTiWotlIXIWEQbgOZERZWN4gw4EYqaURKnomMPg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Martin Schiller , Xie He , Krzysztof Halasa , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 12/70] drivers/net/wan/hdlc_cisco: Add hard_header_len Date: Mon, 21 Sep 2020 18:27:12 +0200 Message-Id: <20200921162035.688353468@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921162035.136047591@linuxfoundation.org> References: <20200921162035.136047591@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie He [ Upstream commit 1a545ebe380bf4c1433e3c136e35a77764fda5ad ] This driver didn't set hard_header_len. This patch sets hard_header_len for it according to its header_ops->create function. This driver's header_ops->create function (cisco_hard_header) creates a header of (struct hdlc_header), so hard_header_len should be set to sizeof(struct hdlc_header). Cc: Martin Schiller Signed-off-by: Xie He Acked-by: Krzysztof Halasa Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/wan/hdlc_cisco.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c index a408abc25512a..7f99fb666f196 100644 --- a/drivers/net/wan/hdlc_cisco.c +++ b/drivers/net/wan/hdlc_cisco.c @@ -377,6 +377,7 @@ static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr) memcpy(&state(hdlc)->settings, &new_settings, size); spin_lock_init(&state(hdlc)->lock); dev->header_ops = &cisco_header_ops; + dev->hard_header_len = sizeof(struct hdlc_header); dev->type = ARPHRD_CISCO; call_netdevice_notifiers(NETDEV_POST_TYPE_CHANGE, dev); netif_dormant_on(dev); -- 2.25.1