From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A89C43465 for ; Mon, 21 Sep 2020 16:35:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2F2B23730 for ; Mon, 21 Sep 2020 16:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706150; bh=zolZwzTxEfBeTWyu+h7YHfETfQ/DiytX4nDIsqj6itw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pP1DwmX99VxkBi0yvHOV4oVyFv+ixWdrM1WvuYi5x7dLl1CpwBvCXBBl+rDbUKKej L0+GVVfqE/P0tJ6yg/4Mx5LkJwxF/b+2BYw/iMDX059PZ9vTGhdz8LLWoPubCPtwtM pHx/46AJOGSmqa1VpoZbbbBAEMJwgksxPy98CCuk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728901AbgIUQfs (ORCPT ); Mon, 21 Sep 2020 12:35:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:35130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728532AbgIUQfm (ORCPT ); Mon, 21 Sep 2020 12:35:42 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9890F23730; Mon, 21 Sep 2020 16:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600706142; bh=zolZwzTxEfBeTWyu+h7YHfETfQ/DiytX4nDIsqj6itw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1PdFIUW+GURyOY/T2mS3JxFHTNcb1hhuxHUaeuUVXkCZKxIxTL4zxXV2CVWfokIdg 3yCg4eiolhu6WxnfrCwWmddkm+esi5mEP9RIhNI3RCt8nStlbQidyyrKIverBCW1LJ mNfOMrfvVoePJlHjshIRUZjRbD+uHdmui5JrJbG0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurent Pinchart , Randy Dunlap , Sasha Levin Subject: [PATCH 4.9 54/70] rapidio: Replace select DMAENGINES with depends on Date: Mon, 21 Sep 2020 18:27:54 +0200 Message-Id: <20200921162037.601946943@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921162035.136047591@linuxfoundation.org> References: <20200921162035.136047591@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurent Pinchart [ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ] Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap Signed-off-by: Sasha Levin --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index d6d2f20c45977..21df2816def76 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -25,7 +25,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data -- 2.25.1