All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Pedersen <thomas@adapt-ip.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Thomas Pedersen <thomas@adapt-ip.com>
Subject: [PATCH v4 06/17] cfg80211: parse S1G Operation element for BSS channel
Date: Mon, 21 Sep 2020 19:28:07 -0700	[thread overview]
Message-ID: <20200922022818.15855-7-thomas@adapt-ip.com> (raw)
In-Reply-To: <20200922022818.15855-1-thomas@adapt-ip.com>

Extract the BSS primary channel from the S1G Operation
element.

Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>

---

v4:
 - add protection against strange IEs in S1G (Johannes)
---
 net/wireless/scan.c | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index b4c85e8f2107..38dabe33a4c5 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1315,18 +1315,34 @@ cfg80211_get_bss_channel(struct wiphy *wiphy, const u8 *ie, size_t ielen,
 	int channel_number = -1;
 	struct ieee80211_channel *alt_channel;
 
+
+	if (channel->band == NL80211_BAND_S1GHZ) {
+		tmp = cfg80211_find_ie(WLAN_EID_S1G_OPERATION, ie, ielen);
+		if (tmp && tmp[1] >= sizeof(struct ieee80211_s1g_oper_ie)) {
+			struct ieee80211_s1g_oper_ie *s1gop = (void *)(tmp + 2);
+
+			channel_number = s1gop->primary_ch;
+		}
+
+		/* even if we didn't try to use the one frame came in on */
+		goto found_channel;
+	}
+
 	tmp = cfg80211_find_ie(WLAN_EID_DS_PARAMS, ie, ielen);
 	if (tmp && tmp[1] == 1) {
 		channel_number = tmp[2];
-	} else {
-		tmp = cfg80211_find_ie(WLAN_EID_HT_OPERATION, ie, ielen);
-		if (tmp && tmp[1] >= sizeof(struct ieee80211_ht_operation)) {
-			struct ieee80211_ht_operation *htop = (void *)(tmp + 2);
+		goto found_channel;
+	}
 
-			channel_number = htop->primary_chan;
-		}
+	tmp = cfg80211_find_ie(WLAN_EID_HT_OPERATION, ie, ielen);
+	if (tmp && tmp[1] >= sizeof(struct ieee80211_ht_operation)) {
+		struct ieee80211_ht_operation *htop = (void *)(tmp + 2);
+
+		channel_number = htop->primary_chan;
+		goto found_channel;
 	}
 
+found_channel:
 	if (channel_number < 0) {
 		/* No channel information in frame payload */
 		return channel;
-- 
2.20.1


  parent reply	other threads:[~2020-09-22  5:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  2:28 [PATCH v4 00/17] add support for S1G association Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 01/17] {cfg,mac}80211: get correct default channel width for S1G Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 02/17] mac80211: s1g: choose scanning width based on frequency Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 03/17] nl80211: support S1G capabilities Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 04/17] mac80211: support S1G STA capabilities Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 05/17] cfg80211: convert S1G beacon to scan results Thomas Pedersen
2020-09-22  2:28 ` Thomas Pedersen [this message]
2020-09-22  2:28 ` [PATCH v4 07/17] mac80211: " Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 08/17] cfg80211: handle Association Response from S1G STA Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 09/17] mac80211: encode listen interval for S1G Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 10/17] mac80211: don't calculate duration " Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 11/17] mac80211: handle S1G low rates Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 12/17] mac80211: avoid rate init for S1G band Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 13/17] mac80211: receive and process S1G beacons Thomas Pedersen
2020-12-08  7:44   ` Wen Gong
2020-12-08  7:44     ` Wen Gong
2020-12-08  7:44     ` Wen Gong
2020-12-08 18:19     ` Thomas Pedersen
2020-12-08 18:19       ` Thomas Pedersen
2020-12-08 18:19       ` Thomas Pedersen
2020-12-09  2:48       ` Wen Gong
2020-12-09  2:48         ` Wen Gong
2020-12-09  2:48         ` Wen Gong
2020-09-22  2:28 ` [PATCH v4 14/17] mac80211: support S1G association Thomas Pedersen
2020-09-28 12:17   ` Johannes Berg
2020-09-29 17:07     ` Thomas Pedersen
2020-11-23  8:38   ` Wen Gong
2020-11-23  8:39     ` Wen Gong
2020-11-23  8:39       ` Wen Gong
2020-11-23  8:39       ` Wen Gong
2020-11-23 18:40     ` Thomas Pedersen
2020-11-24  3:59       ` Wen Gong
2020-11-24  7:04         ` Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 15/17] nl80211: include frequency offset in survey info Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 16/17] mac80211_hwsim: fix TSF timestamp write to S1G beacon Thomas Pedersen
2020-09-22  2:28 ` [PATCH v4 17/17] mac80211_hwsim: indicate support for S1G Thomas Pedersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922022818.15855-7-thomas@adapt-ip.com \
    --to=thomas@adapt-ip.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.