From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2527C2D0E2 for ; Tue, 22 Sep 2020 06:34:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A67D6239A1 for ; Tue, 22 Sep 2020 06:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728484AbgIVGeK (ORCPT ); Tue, 22 Sep 2020 02:34:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbgIVGeK (ORCPT ); Tue, 22 Sep 2020 02:34:10 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05E18C061755 for ; Mon, 21 Sep 2020 23:34:10 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKbsM-0006DQ-J4; Tue, 22 Sep 2020 08:34:06 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1kKbsK-000454-3O; Tue, 22 Sep 2020 08:34:04 +0200 Date: Tue, 22 Sep 2020 08:34:03 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Andy Shevchenko Cc: vijayakannan.ayyathurai@intel.com, thierry.reding@gmail.com, robh+dt@kernel.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, wan.ahmad.zainie.wan.mohamad@intel.com, mgross@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com Subject: Re: [PATCH v7 2/2] dt-bindings: pwm: keembay: Add bindings for Intel Keem Bay PWM Message-ID: <20200922063403.5sm6fk7qopggoitc@pengutronix.de> References: <20200909162719.7585-1-vijayakannan.ayyathurai@intel.com> <20200909162719.7585-3-vijayakannan.ayyathurai@intel.com> <20200921084401.gtesjzentxrly47c@pengutronix.de> <20200921103756.GP3956970@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3riy4hp7mq7zkjls" Content-Disposition: inline In-Reply-To: <20200921103756.GP3956970@smile.fi.intel.com> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --3riy4hp7mq7zkjls Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Andy, On Mon, Sep 21, 2020 at 01:37:56PM +0300, Andy Shevchenko wrote: > On Mon, Sep 21, 2020 at 10:44:01AM +0200, Uwe Kleine-K=F6nig wrote: > > On Thu, Sep 10, 2020 at 12:27:19AM +0800, vijayakannan.ayyathurai@intel= =2Ecom wrote: > > > From: Vijayakannan Ayyathurai > > >=20 > > > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC. > > >=20 > > > Signed-off-by: Vineetha G. Jaya Kumaran > > > Signed-off-by: Vijayakannan Ayyathurai > > > Reviewed-by: Rob Herring > > > Acked-by: Uwe Kleine-K=F6nig > >=20 > > nitpick: Your S-o-b should always be last. This way it becomes clear who > > added the other tags. >=20 > I think it should reflect chronological order. If SoB has been given befo= re > e.g. Ack then SoB should be followed by Ack and not other way around. This is how I interpret the rules even though I admit it is not formalized explicitly. The idea is just what I wrote, when the patch ends up in git with: Signed-off-by: Vineetha G. Jaya Kumaran Signed-off-by: Vijayakannan Ayyathurai Reviewed-by: Rob Herring Acked-by: Uwe Kleine-K=F6nig Signed-off-by: Peter Maintainer I'd expect that is was Peter M. who added Rob's and my tag, while when it is Signed-off-by: Vineetha G. Jaya Kumaran Reviewed-by: Rob Herring Acked-by: Uwe Kleine-K=F6nig Signed-off-by: Vijayakannan Ayyathurai Signed-off-by: Peter Maintainer it was Vijayakannan who added them. IMHO this makes sense as Vijayakannan modified the commit log and then it is usual to add the signature at the end. In my eyes this is more sensible than the date order, but it seems this is subjective. I'm aware that most people don't care; and I don't care enough to argue this case any further. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --3riy4hp7mq7zkjls Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl9pmtgACgkQwfwUeK3K 7AljeAf/TACR7/NNqYto9dvZocCa4ZRdCBGdD/55DvvBeu9xw3qjAxti/3BC+ecE 9mMMEDSVN04aKFjkjybb0PqK0rAOMbTWDn7XvzAhkqH30s63PWgtJjqFUqwGRbK5 ecG9fUXmVat6fvH27LW6sD53FSfVWBLEPE5kgqte2bKmwu+12ll2seb+e3uooupL /aWodx2FAFX7GMABbHWzTHQ17bGs+Is8wJm04IqEX4h4h2luC/DgXwnIRQdgl3o7 mFI8xHY098pxG7S9VaoGXCANraja4VKeiFWsue6//t7YakFI9UqcNaAQjUbawVNI igP/VSVSA5CFj+2Czu3kaQ9caemMCg== =DzkG -----END PGP SIGNATURE----- --3riy4hp7mq7zkjls--