All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Rik van Riel <riel@surriel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-team@fb.com, niketa@fb.com, sjenning@redhat.com,
	ddstreet@ieee.org, konrad.wilk@oracle.com, hannes@cmpxchg.org
Subject: Re: [PATCH 0/2] mm,swap: skip swap readahead for instant IO (like zswap)
Date: Tue, 22 Sep 2020 10:12:50 -0700	[thread overview]
Message-ID: <20200922101250.527d9e676fefbb4c8d0cd5b9@linux-foundation.org> (raw)
In-Reply-To: <20200922020148.3261797-1-riel@surriel.com>

On Mon, 21 Sep 2020 22:01:46 -0400 Rik van Riel <riel@surriel.com> wrote:

> Both with frontswap/zswap, and with some extremely fast IO devices,
> swap IO will be done before the "asynchronous" swap_readpage() call
> has returned.
> 
> In that case, doing swap readahead only wastes memory, increases
> latency, and increases the chances of needing to evict something more
> useful from memory. In that case, just skip swap readahead.

Any quantitative testing results?

  parent reply	other threads:[~2020-09-22 17:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  2:01 [PATCH 0/2] mm,swap: skip swap readahead for instant IO (like zswap) Rik van Riel
2020-09-22  2:01 ` [PATCH 1/2] mm,swap: extract swap single page readahead into its own function Rik van Riel
2020-09-23  6:32   ` Christoph Hellwig
2020-09-23  8:02     ` Hillf Danton
2020-09-22  2:01 ` [PATCH 2/2] mm,swap: skip swap readahead if page was obtained instantaneously Rik van Riel
2020-09-22  3:13   ` huang ying
2020-09-22  3:13     ` huang ying
2020-09-22 11:33     ` Rik van Riel
2020-09-22 11:33       ` Rik van Riel
2020-09-23  6:35   ` Christoph Hellwig
2020-09-22 17:12 ` Andrew Morton [this message]
2020-10-05 17:32   ` [PATCH 0/2] mm,swap: skip swap readahead for instant IO (like zswap) Rik van Riel
2020-10-05 17:32     ` Rik van Riel
2020-10-09 14:38     ` Rik van Riel
2020-10-09 14:38       ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922101250.527d9e676fefbb4c8d0cd5b9@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ddstreet@ieee.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=niketa@fb.com \
    --cc=riel@surriel.com \
    --cc=sjenning@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.