From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org,
Vladimir Murzin <vladimir.murzin@arm.com>
Subject: Re: [PATCH v1 1/3] dmaengine: dmatest: Fix regression when run command on misconfigured channel
Date: Tue, 22 Sep 2020 14:55:49 +0300 [thread overview]
Message-ID: <20200922115549.GQ3956970@smile.fi.intel.com> (raw)
In-Reply-To: <20200922114722.GO3956970@smile.fi.intel.com>
On Tue, Sep 22, 2020 at 02:47:22PM +0300, Andy Shevchenko wrote:
> On Thu, Sep 17, 2020 at 04:00:34PM +0530, Vinod Koul wrote:
> > On 16-09-20, 16:34, Andy Shevchenko wrote:
> > > From: Vladimir Murzin <vladimir.murzin@arm.com>
> > > Andy reported that commit 6b41030fdc79 ("dmaengine: dmatest:
> > > Restore default for channel") broke his scripts for the case
> > > where "busy" channel is used for configuration with expectation
> > > that run command would do nothing (and return 0). Instead,
> > > behavior was (unintentionally) changed to treat such case as
> > > under-configuration and progress with defaults, i.e. run command
> > > would start a test with default setting for channel (which would
> > > use all channels).
> >
> > but a mis-configured channel returning success and doing nothing does
> > not look as a good behaviour, I agree it broke Andy's script but the
> > behaviour was not good to start with ;)
>
> Which used to be a previous behaviour. I don't understand what should I do here
> as after this patch (and even after the initial multi-channel support patch)
> the behaviour is like you desire.
Okay, I have dropped the part '(and return 0)' to avoid ambiguity.
> > > Restore original behavior with tracking status of channel setter
> > > so we can distinguish between misconfigured and under-configured
> > > cases in run command and act accordingly.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-09-22 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 13:34 [PATCH v1 1/3] dmaengine: dmatest: Fix regression when run command on misconfigured channel Andy Shevchenko
2020-09-16 13:34 ` [PATCH v1 2/3] dmaengine: dmatest: Check list for emptiness before access its last entry Andy Shevchenko
2020-09-16 13:34 ` [PATCH v1 3/3] dmaengine: dmatest: Return boolean result directly in filter() Andy Shevchenko
2020-09-17 9:39 ` Peter Ujfalusi
2020-09-22 11:51 ` Andy Shevchenko
2020-09-17 10:30 ` [PATCH v1 1/3] dmaengine: dmatest: Fix regression when run command on misconfigured channel Vinod Koul
2020-09-22 11:47 ` Andy Shevchenko
2020-09-22 11:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922115549.GQ3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.