From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF22C4363D for ; Tue, 22 Sep 2020 13:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2DF8207C3 for ; Tue, 22 Sep 2020 13:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PYf/fhqf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbgIVNaw (ORCPT ); Tue, 22 Sep 2020 09:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbgIVNau (ORCPT ); Tue, 22 Sep 2020 09:30:50 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AEEBC0613CF for ; Tue, 22 Sep 2020 06:30:48 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id mm21so1492694pjb.4 for ; Tue, 22 Sep 2020 06:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1GHsfdPCR77ri55Z/gkRdzdu2BS26mtnO9jUw29WWuE=; b=PYf/fhqfKIr6N01I/QicRO2GByFEnNq9jt9OCDmvovRoGtA21PFmvL1UrQDXIaLlGc OPfYG/GNe7vdUQoRz0jksfygEUI9Y/h1ES0m4BbqBXMDQZLEDpUsrGlR6ZlHWXz5ZTHi LYd08Bz20EFeN7KakVAJq7NCP4lJtYWTUBr/nAgViUZP4zcM//wBoJvwrv27kx+pk/MJ 95SDelKum1aG4OtwmRNWOaIRarAYQZDQPDkrH4KToFNIn/IKZQc6o4BYcFrmmwevyDIV r3qcMBBGkGodo9hLt5arLKbHW0jFcW8lj702BpEnsH9Ij1X0FzccPgIjJ7Z7SDtABfu7 Vm/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1GHsfdPCR77ri55Z/gkRdzdu2BS26mtnO9jUw29WWuE=; b=FHZFJ9atz32AwcS10Y6xi6/2YaNIBdCHOyWCdZX72CiJa18FdDtPEQtHoPSl8d23w9 Cno1T3GDFvtvx8Uygu8Qfslya0XYXH8ZF3iFrrHvrglBmXk8+4xypJwtSeEGJnwvAFhu uhyejQF3e7HZqzgtzh9WPU79QvD9ST5j/VWAGzRlMotAxqzH/g9MSdfjc5fd5RvqdGPl KmOLxBsdCA6IKfpi512SUXFohy2Glx6sh2674usTuDez0QuQgaFiGKpzpIAYtKfSt5ih Yd4bX1QxyY63dBFdPdbp3CM2mhGsBRhn29if1lcoB16BITTcbQYE2kEpIkbZnxwIbHUr SvnQ== X-Gm-Message-State: AOAM531JJ77ILJvNZya31Nf9wXzuPI4gQc/jAyjILA4f3j6+G1e7hXCN EQw3zRq9wgHatEztxE43Axc7Uw== X-Google-Smtp-Source: ABdhPJzGpdDqF3aGCyYvVXJBfOFTTLMhvvAsovlgQEUN+xFaLn/zEmPC0jrtohf9XFdx+z/wp3wonA== X-Received: by 2002:a17:90a:6903:: with SMTP id r3mr3607219pjj.169.1600781447856; Tue, 22 Sep 2020 06:30:47 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id ep4sm2480648pjb.39.2020.09.22.06.30.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Sep 2020 06:30:47 -0700 (PDT) Date: Tue, 22 Sep 2020 19:00:37 +0530 From: Viresh Kumar To: Qinglang Miao Cc: Viresh Kumar , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] pinctrl: spear: simplify the return expression of tvc_connect() Message-ID: <20200922133037.cehknuxert4hdsaw@vireshk-i7> References: <20200921131058.92941-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921131058.92941-1-miaoqinglang@huawei.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 21-09-20, 21:10, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- > drivers/pinctrl/spear/pinctrl-spear320.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/spear/pinctrl-spear320.c b/drivers/pinctrl/spear/pinctrl-spear320.c > index 99c10fc3d..e629e3035 100644 > --- a/drivers/pinctrl/spear/pinctrl-spear320.c > +++ b/drivers/pinctrl/spear/pinctrl-spear320.c > @@ -3418,8 +3418,6 @@ static const struct of_device_id spear320_pinctrl_of_match[] = { > > static int spear320_pinctrl_probe(struct platform_device *pdev) > { > - int ret; > - > spear3xx_machdata.groups = spear320_pingroups; > spear3xx_machdata.ngroups = ARRAY_SIZE(spear320_pingroups); > spear3xx_machdata.functions = spear320_functions; > @@ -3433,11 +3431,7 @@ static int spear320_pinctrl_probe(struct platform_device *pdev) > pmx_init_gpio_pingroup_addr(spear3xx_machdata.gpio_pingroups, > spear3xx_machdata.ngpio_pingroups, PMX_CONFIG_REG); > > - ret = spear_pinctrl_probe(pdev, &spear3xx_machdata); > - if (ret) > - return ret; > - > - return 0; > + return spear_pinctrl_probe(pdev, &spear3xx_machdata); > } > > static struct platform_driver spear320_pinctrl_driver = { Acked-by: Viresh Kumar -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC817C2D0E2 for ; Tue, 22 Sep 2020 13:32:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90F78207C3 for ; Tue, 22 Sep 2020 13:32:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="toCtrnW2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PYf/fhqf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90F78207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pE9GRS7+5JOw3e8X7ORXfGCS8HQI+iuZb04NYYX81dE=; b=toCtrnW2bORU5CYVZt/CYKLrh orUGpA2Kd7z4X60PhkAzEFbc9sbUjDSlmjjB8r0JRniTDI1gspL3ghp7gltVU2UB5AwThQymDRWCy VKgElfY/fsQgiHDmluWnb0O0zS/nmF7aI5ecEFolM1Ov8F6l48eYaygS1AvQ0SqbGv09NDeNo8tHR TwBSXD15kasX3JhzYhfITuAgGPHwgoClJ09VswxrT2oKs8dhfEJSAyIKd4XhVIq81+rxi/dk8PV+l Ee6K6gaa5a6gDQ4p5aX0/AsI2cETWEEQfxMRlnJ0iNECUFQr+LSX9UxONfNABoULBfvu7mFGPZL47 SRG/iYLOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKiNk-000716-6T; Tue, 22 Sep 2020 13:30:56 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKiNe-00070K-2o for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 13:30:52 +0000 Received: by mail-pj1-x1044.google.com with SMTP id q4so1489218pjh.5 for ; Tue, 22 Sep 2020 06:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1GHsfdPCR77ri55Z/gkRdzdu2BS26mtnO9jUw29WWuE=; b=PYf/fhqfKIr6N01I/QicRO2GByFEnNq9jt9OCDmvovRoGtA21PFmvL1UrQDXIaLlGc OPfYG/GNe7vdUQoRz0jksfygEUI9Y/h1ES0m4BbqBXMDQZLEDpUsrGlR6ZlHWXz5ZTHi LYd08Bz20EFeN7KakVAJq7NCP4lJtYWTUBr/nAgViUZP4zcM//wBoJvwrv27kx+pk/MJ 95SDelKum1aG4OtwmRNWOaIRarAYQZDQPDkrH4KToFNIn/IKZQc6o4BYcFrmmwevyDIV r3qcMBBGkGodo9hLt5arLKbHW0jFcW8lj702BpEnsH9Ij1X0FzccPgIjJ7Z7SDtABfu7 Vm/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1GHsfdPCR77ri55Z/gkRdzdu2BS26mtnO9jUw29WWuE=; b=sMO+dig317MHCJWHWOXBSE+lyTYafLDeskzjQphW/cThDbfx7ORfuAgAsrvGMwuKez LBI4Te9v8tQobi6q1qopaqaC3Q3AEgZ6cCFBKYG0ksg6KbLOiybuCGWBxs2txnON6xF3 dQDGZo+9EUC+XLJVBvH7ir2qFKizMJKSRLgV4vaottglQL48utonZTZNeYZhRMt2YghC cvVpWB3ueKxS2j7ACH7fDo77X9XCFE+QOl4QDzio8bFiO6DQtHL+mUNC6WWU/1/oTZvT ygFoJbg9k5vbsux2Qsg3/l9RD5D8NuDQvmXPfteRiWx0qiVX0gOUiH8tDn93S1rA7eNc awmg== X-Gm-Message-State: AOAM530dm1CHMm+nZs9+ttl6iggm/WcgC5eim3yH5Mw5fXFRNDBgdVwN Il1PKy+8vt6blRYASX8FyxROl1ZB1Au3Hg== X-Google-Smtp-Source: ABdhPJzGpdDqF3aGCyYvVXJBfOFTTLMhvvAsovlgQEUN+xFaLn/zEmPC0jrtohf9XFdx+z/wp3wonA== X-Received: by 2002:a17:90a:6903:: with SMTP id r3mr3607219pjj.169.1600781447856; Tue, 22 Sep 2020 06:30:47 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id ep4sm2480648pjb.39.2020.09.22.06.30.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Sep 2020 06:30:47 -0700 (PDT) Date: Tue, 22 Sep 2020 19:00:37 +0530 From: Viresh Kumar To: Qinglang Miao Subject: Re: [PATCH -next] pinctrl: spear: simplify the return expression of tvc_connect() Message-ID: <20200922133037.cehknuxert4hdsaw@vireshk-i7> References: <20200921131058.92941-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200921131058.92941-1-miaoqinglang@huawei.com> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_093051_963730_82E3C60B X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-09-20, 21:10, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- > drivers/pinctrl/spear/pinctrl-spear320.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/spear/pinctrl-spear320.c b/drivers/pinctrl/spear/pinctrl-spear320.c > index 99c10fc3d..e629e3035 100644 > --- a/drivers/pinctrl/spear/pinctrl-spear320.c > +++ b/drivers/pinctrl/spear/pinctrl-spear320.c > @@ -3418,8 +3418,6 @@ static const struct of_device_id spear320_pinctrl_of_match[] = { > > static int spear320_pinctrl_probe(struct platform_device *pdev) > { > - int ret; > - > spear3xx_machdata.groups = spear320_pingroups; > spear3xx_machdata.ngroups = ARRAY_SIZE(spear320_pingroups); > spear3xx_machdata.functions = spear320_functions; > @@ -3433,11 +3431,7 @@ static int spear320_pinctrl_probe(struct platform_device *pdev) > pmx_init_gpio_pingroup_addr(spear3xx_machdata.gpio_pingroups, > spear3xx_machdata.ngpio_pingroups, PMX_CONFIG_REG); > > - ret = spear_pinctrl_probe(pdev, &spear3xx_machdata); > - if (ret) > - return ret; > - > - return 0; > + return spear_pinctrl_probe(pdev, &spear3xx_machdata); > } > > static struct platform_driver spear320_pinctrl_driver = { Acked-by: Viresh Kumar -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel