From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA2BDC4363D for ; Thu, 24 Sep 2020 01:01:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8F5B2223E for ; Thu, 24 Sep 2020 01:01:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbgIXBBl (ORCPT ); Wed, 23 Sep 2020 21:01:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbgIXBBl (ORCPT ); Wed, 23 Sep 2020 21:01:41 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91ED5C0613CE for ; Wed, 23 Sep 2020 18:01:41 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D5B70125EFA9F; Wed, 23 Sep 2020 17:44:53 -0700 (PDT) Date: Wed, 23 Sep 2020 18:01:40 -0700 (PDT) Message-Id: <20200923.180140.957870805702877808.davem@davemloft.net> To: hauke@hauke-m.de Cc: kuba@kernel.org, netdev@vger.kernel.org, martin.blumenstingl@googlemail.com Subject: Re: [PATCH v2] net: lantiq: Add locking for TX DMA channel From: David Miller In-Reply-To: <20200922214112.19591-1-hauke@hauke-m.de> References: <20200922214112.19591-1-hauke@hauke-m.de> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 23 Sep 2020 17:44:54 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hauke Mehrtens Date: Tue, 22 Sep 2020 23:41:12 +0200 > The TX DMA channel data is accessed by the xrx200_start_xmit() and the > xrx200_tx_housekeeping() function from different threads. Make sure the > accesses are synchronized by acquiring the netif_tx_lock() in the > xrx200_tx_housekeeping() function too. This lock is acquired by the > kernel before calling xrx200_start_xmit(). > > Signed-off-by: Hauke Mehrtens Applied, but... You posted this really fast after my feedback, so I have to ask if you actually functionally tested this patch?