Re: [PATCH v8 3/7] usb/hcd-xhci: Split pci wrapper for xhci base model

From: Gerd Hoffmann <kraxel@redhat.com>
To: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Cc: "Francisco Eduardo Iglesias" <figlesia@xilinx.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Vikram Garhwal" <fnuv@xilinx.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-devel@nongnu.org, "Sai Pavan Boddu" <saipava@xilinx.com>,
	"Edgar Iglesias" <edgari@xilinx.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"'Marc-André Lureau'" <marcandre.lureau@redhat.com>,
	"Ying Fang" <fangying1@huawei.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Paul Zimmerman" <pauldzim@gmail.com>,
	"'Philippe Mathieu-Daudé'" <philmd@redhat.com>
Subject: Re: [PATCH v8 3/7] usb/hcd-xhci: Split pci wrapper for xhci base model
Date: Wed, 23 Sep 2020 12:14:28 +0200	[thread overview]
Message-ID: <20200923101428.zilaxig5yi5u45rn@sirius.home.kraxel.org> (raw)
In-Reply-To: <1600780837-8231-4-git-send-email-sai.pavan.boddu@xilinx.com>

  Hi,

> This patch sets the base to use xhci as sysbus model, for which pci
> specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment
> msi/msix interrupts handling is moved under XHCIPCIState. Made required
> changes for qemu-xhci-nec.

Progress.  vmstate loads fine ;)

Does not work though.  usb-tablet stops working after migration :(

> @@ -3561,11 +3458,7 @@ static int usb_xhci_post_load(void *opaque, int version_id)
>      }
>  
>      for (intr = 0; intr < xhci->numintrs; intr++) {
> -        if (xhci->intr[intr].msix_used) {
> -            msix_vector_use(pci_dev, intr);
> -        } else {
> -            msix_vector_unuse(pci_dev, intr);
> -        }
> +        xhci_intr_update(xhci, intr);
>      }
>  
>      return 0;

I suspect this is the problem.  I guess we should add
usb_xhci_post_load_pci + usb_xhci_post_load_sysbus and move irq handling
to these functions.

take care,
  Gerd