From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEFDC2D0A8 for ; Wed, 23 Sep 2020 22:48:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A571214F1 for ; Wed, 23 Sep 2020 22:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600901329; bh=5tw0nXmsDP0NkQXvrbQ0j9R/hmeShcu2Ue7agG3AUWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=y29eISDsC6SdrHcXAEv6qKszPAZSPm3aBRYNVgVvcpX1iavVXk20p3H7QdyA+28Tj ePh6G7j+jJA4fsWcYXhfT3Y3uunbdT3c15M0bZugRBc+YvOA6L7F8sW5qo3Cy+VHRS 2AwdZWspUwVWeDJSZT256O7fLsdqo4b1eFHfMpho= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726846AbgIWWss (ORCPT ); Wed, 23 Sep 2020 18:48:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:46192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbgIWWso (ORCPT ); Wed, 23 Sep 2020 18:48:44 -0400 Received: from sx1.mtl.com (c-24-6-56-119.hsd1.ca.comcast.net [24.6.56.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2C092311E; Wed, 23 Sep 2020 22:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600901324; bh=5tw0nXmsDP0NkQXvrbQ0j9R/hmeShcu2Ue7agG3AUWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xNv+i0AZ/j/FoRy32Dm9mPvDmJ+2ngQ1VUYHscDoKMdg9mPmU1NegOax+6TaJW37W 5bc39bSb4r31aWHhJylGwL29OQq3lQCk/i3u7vqt6M2NVAeAUmd1wSGvqHqGPXwlLm eMWOs1YokudFqBvJZp8r2ll5b6NjnQByKGpOv1T4= From: saeed@kernel.org To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Denis Efremov , Saeed Mahameed Subject: [net-next V2 13/15] net/mlx5e: Use kfree() to free fd->g in accel_fs_tcp_create_groups() Date: Wed, 23 Sep 2020 15:48:22 -0700 Message-Id: <20200923224824.67340-14-saeed@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200923224824.67340-1-saeed@kernel.org> References: <20200923224824.67340-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Denis Efremov Memory ft->g in accel_fs_tcp_create_groups() is allocaed with kcalloc(). It's excessive to free ft->g with kvfree(). Use kfree() instead. Signed-off-by: Denis Efremov Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c index 4cdd9eac647d..97f1594cee11 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c @@ -191,7 +191,7 @@ static int accel_fs_tcp_create_groups(struct mlx5e_flow_table *ft, ft->g = kcalloc(MLX5E_ACCEL_FS_TCP_NUM_GROUPS, sizeof(*ft->g), GFP_KERNEL); in = kvzalloc(inlen, GFP_KERNEL); if (!in || !ft->g) { - kvfree(ft->g); + kfree(ft->g); kvfree(in); return -ENOMEM; } -- 2.26.2