From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E4BC4363D for ; Thu, 24 Sep 2020 10:46:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F24EE2396E for ; Thu, 24 Sep 2020 10:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F24EE2396E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E16489C1C; Thu, 24 Sep 2020 10:46:24 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 267A989C1C for ; Thu, 24 Sep 2020 10:46:23 +0000 (UTC) IronPort-SDR: pY8/KtDJ4f2t5L2tmlkNMrBRQEPEbO6QbBxJgQoKn8EHKIsyzsp6I9G2asD2W7U/iVGRNqDrBk fMIyJAD9BsUg== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="148818183" X-IronPort-AV: E=Sophos;i="5.77,297,1596524400"; d="scan'208";a="148818183" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 03:46:22 -0700 IronPort-SDR: xJ51sOD/hLiHm16yBxG/2S+Uk6xQIyFAwPdcGQycgujImwTNQfgpi+RBP0jgRgZwyQl3w1BR9J SsqcHXdFnd8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,297,1596524400"; d="scan'208";a="339003798" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga008.jf.intel.com with SMTP; 24 Sep 2020 03:46:20 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 24 Sep 2020 13:46:19 +0300 Date: Thu, 24 Sep 2020 13:46:19 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Srivatsa, Anusha" Message-ID: <20200924104619.GG6112@intel.com> References: <20200716172106.2656-1-ville.syrjala@linux.intel.com> <20200716172106.2656-5-ville.syrjala@linux.intel.com> <5eaf7a6e770841e1abac61b686acdde8@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5eaf7a6e770841e1abac61b686acdde8@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 04/14] drm/i915: Add SKL GT1.5 PCI IDs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Sep 24, 2020 at 12:37:47AM +0000, Srivatsa, Anusha wrote: > = > = > > -----Original Message----- > > From: Intel-gfx On Behalf Of = Ville > > Syrjala > > Sent: Thursday, July 16, 2020 10:21 AM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 04/14] drm/i915: Add SKL GT1.5 PCI IDs > > = > > From: Alexei Podtelezhnikov > > = > > Add three new devices 0x1913, 0x1915, and 0x1917 also known as > > iSKLULTGT15, iSKLULXGT15, and iSKLDTGT15. > > = > > Signed-off-by: Alexei Podtelezhnikov > > [vsyrjala: Split separate changes into separate patchs, > > Sort the IDs] > The above comment appears in every patch. If this is v2 of the patches th= en it goes right after the commit message as: > = > V2: Split separate changes into separate patches, sort the IDs (Ville) No. I use the [vsyrjala: blah] notation to indicate I modified the original patch which was authored by someone else. > = > > Signed-off-by: Ville Syrj=E4l=E4 > The code changes itself look good. > = > Reviewed-by: Anusha Srivatsa > = > > --- > > include/drm/i915_pciids.h | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > = > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index > > 9df3697f074d..c906088ccffe 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -329,17 +329,20 @@ > > INTEL_VGA_DEVICE(0x22b3, info) > > = > > #define INTEL_SKL_ULT_GT1_IDS(info) \ > > - INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */ > > + INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \ > > + INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */ > > = > > #define INTEL_SKL_ULX_GT1_IDS(info) \ > > - INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */ > > + INTEL_VGA_DEVICE(0x190E, info), /* ULX GT1 */ \ > > + INTEL_VGA_DEVICE(0x1915, info) /* ULX GT1.5 */ > > = > > #define INTEL_SKL_GT1_IDS(info) \ > > INTEL_SKL_ULT_GT1_IDS(info), \ > > INTEL_SKL_ULX_GT1_IDS(info), \ > > INTEL_VGA_DEVICE(0x1902, info), /* DT GT1 */ \ > > INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \ > > - INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */ > > + INTEL_VGA_DEVICE(0x190A, info), /* SRV GT1 */ \ > > + INTEL_VGA_DEVICE(0x1917, info) /* DT GT1.5 */ > > = > > #define INTEL_SKL_ULT_GT2_IDS(info) \ > > INTEL_VGA_DEVICE(0x1916, info), /* ULT GT2 */ \ > > -- > > 2.26.2 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx