From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 119C2C4363D for ; Thu, 24 Sep 2020 10:50:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC1BF206B8 for ; Thu, 24 Sep 2020 10:50:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC1BF206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A02D6E1E8; Thu, 24 Sep 2020 10:50:37 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61FC86E1E8 for ; Thu, 24 Sep 2020 10:50:36 +0000 (UTC) IronPort-SDR: buJDxViL87wr0ewtmdAdDhl5ILfMj0OkZKiFjZURmBgrwr8nwx/jEJbNVdQFEkfoXoTQE7jbbj 8gBzwZ1QpX1g== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="225307371" X-IronPort-AV: E=Sophos;i="5.77,297,1596524400"; d="scan'208";a="225307371" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 03:50:35 -0700 IronPort-SDR: SQCHBq6HjjA4D51DtTRJ1sG5aoUP8OJaJfryViKbhLiuwYyXQue4FMuWRJdGLx7L5+I0SANoWt SUD6BbBIdmLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,297,1596524400"; d="scan'208";a="413287963" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga001.fm.intel.com with SMTP; 24 Sep 2020 03:50:33 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 24 Sep 2020 13:50:32 +0300 Date: Thu, 24 Sep 2020 13:50:32 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Srivatsa, Anusha" Message-ID: <20200924105032.GH6112@intel.com> References: <20200716172106.2656-1-ville.syrjala@linux.intel.com> <20200716172106.2656-9-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 08/14] drm/i915: Sort SKL PCI IDs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Sep 24, 2020 at 12:49:13AM +0000, Srivatsa, Anusha wrote: > = > = > > -----Original Message----- > > From: Intel-gfx On Behalf Of = Ville > > Syrjala > > Sent: Thursday, July 16, 2020 10:21 AM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 08/14] drm/i915: Sort SKL PCI IDs > > = > > From: Ville Syrj=E4l=E4 > > = > > Sort the SKL PCI IDs numerically. Some order seems better than > > randomness. > = > There are 2 patches - patch 2 and 3 in the series that are reclassifying = some PCI IDs and there is patch 4 that adds a missing ID. All of those wit= h this patch can be combined to a single patch OR patch 2, 3 and 4 can be s= quashed as one solitary patch. The original patch from Alexei was a single patch. I split it up for a reason; easier to revert things if/when necessary, and it's also easier to review. If your commit message is of the form "do A and B" it's generally a good indication that it should be split into two patches. > = > Anusha = > > Cc: Alexei Podtelezhnikov > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > include/drm/i915_pciids.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > = > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index > > 4870c3c9f9b2..5185ac789038 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -340,8 +340,8 @@ > > INTEL_SKL_ULT_GT1_IDS(info), \ > > INTEL_SKL_ULX_GT1_IDS(info), \ > > INTEL_VGA_DEVICE(0x1902, info), /* DT GT1 */ \ > > - INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \ > > INTEL_VGA_DEVICE(0x190A, info), /* SRV GT1 */ \ > > + INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \ > > INTEL_VGA_DEVICE(0x1917, info) /* DT GT1.5 */ > > = > > #define INTEL_SKL_ULT_GT2_IDS(info) \ > > @@ -355,8 +355,8 @@ > > INTEL_SKL_ULT_GT2_IDS(info), \ > > INTEL_SKL_ULX_GT2_IDS(info), \ > > INTEL_VGA_DEVICE(0x1912, info), /* DT GT2 */ \ > > - INTEL_VGA_DEVICE(0x191B, info), /* Halo GT2 */ \ > > INTEL_VGA_DEVICE(0x191A, info), /* SRV GT2 */ \ > > + INTEL_VGA_DEVICE(0x191B, info), /* Halo GT2 */ \ > > INTEL_VGA_DEVICE(0x191D, info) /* WKS GT2 */ > > = > > #define INTEL_SKL_ULT_GT3_IDS(info) \ > > @@ -372,9 +372,9 @@ > > = > > #define INTEL_SKL_GT4_IDS(info) \ > > INTEL_VGA_DEVICE(0x1932, info), /* DT GT4 */ \ > > + INTEL_VGA_DEVICE(0x193A, info), /* SRV GT4e */ \ > > INTEL_VGA_DEVICE(0x193B, info), /* Halo GT4e */ \ > > - INTEL_VGA_DEVICE(0x193D, info), /* WKS GT4e */ \ > > - INTEL_VGA_DEVICE(0x193A, info) /* SRV GT4e */ > > + INTEL_VGA_DEVICE(0x193D, info) /* WKS GT4e */ > > = > > #define INTEL_SKL_IDS(info) \ > > INTEL_SKL_GT1_IDS(info), \ > > -- > > 2.26.2 > > = > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx