All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: fam@euphon.net, kwolf@redhat.com, ehabkost@redhat.com,
	qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
	crosa@redhat.com, den@openvz.org
Subject: Re: [PATCH v8 0/7] coroutines: generate wrapper code
Date: Thu, 24 Sep 2020 13:16:20 +0100	[thread overview]
Message-ID: <20200924121620.GA62770@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200915164411.20590-1-vsementsov@virtuozzo.com>

[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]

On Tue, Sep 15, 2020 at 07:44:04PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> The aim of the series is to reduce code-duplication and writing
> parameters structure-packing by hand around coroutine function wrappers.
> 
> Benefits:
>  - no code duplication
>  - less indirection
> 
> v8:
> 04: - rebase on meson build
>         - script interface is changed to satisfy meson custom_target
>     - rename script s/coroutine-wrapper.py/block-coroutine-wrapper.py/
>     - add docs/devel/block-coroutine-wrapper.rst
> 
> Vladimir Sementsov-Ogievskiy (7):
>   block: return error-code from bdrv_invalidate_cache
>   block/io: refactor coroutine wrappers
>   block: declare some coroutine functions in block/coroutines.h
>   scripts: add block-coroutine-wrapper.py
>   block: generate coroutine-wrapper code
>   block: drop bdrv_prwv
>   block/io: refactor save/load vmstate
> 
>  docs/devel/block-coroutine-wrapper.rst |  54 ++++
>  block/block-gen.h                      |  49 ++++
>  block/coroutines.h                     |  65 +++++
>  include/block/block.h                  |  34 ++-
>  block.c                                |  97 ++-----
>  block/io.c                             | 336 ++++---------------------
>  tests/test-bdrv-drain.c                |   2 +-
>  block/meson.build                      |   8 +
>  scripts/block-coroutine-wrapper.py     | 187 ++++++++++++++
>  9 files changed, 451 insertions(+), 381 deletions(-)
>  create mode 100644 docs/devel/block-coroutine-wrapper.rst
>  create mode 100644 block/block-gen.h
>  create mode 100644 block/coroutines.h
>  create mode 100755 scripts/block-coroutine-wrapper.py

Please send a v9 and I'll merge it.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2020-09-24 12:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 16:44 [PATCH v8 0/7] coroutines: generate wrapper code Vladimir Sementsov-Ogievskiy
2020-09-15 16:44 ` [PATCH v8 1/7] block: return error-code from bdrv_invalidate_cache Vladimir Sementsov-Ogievskiy
2020-09-24  8:26   ` Philippe Mathieu-Daudé
2020-09-24 11:19   ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 2/7] block/io: refactor coroutine wrappers Vladimir Sementsov-Ogievskiy
2020-09-23 19:41   ` Eric Blake
2020-09-24  8:27   ` Philippe Mathieu-Daudé
2020-09-24 11:24   ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 3/7] block: declare some coroutine functions in block/coroutines.h Vladimir Sementsov-Ogievskiy
2020-09-23 21:47   ` Eric Blake
2020-09-24  8:34   ` Philippe Mathieu-Daudé
2020-09-24 11:25   ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py Vladimir Sementsov-Ogievskiy
2020-09-15 20:02   ` Vladimir Sementsov-Ogievskiy
2020-09-24  0:00     ` Eric Blake
2020-09-24  1:20       ` Eric Blake
2020-09-24  7:08         ` Vladimir Sementsov-Ogievskiy
2020-09-24  6:59       ` Vladimir Sementsov-Ogievskiy
2020-09-24 16:20       ` John Snow
2020-09-24  0:18   ` Eric Blake
2020-09-24  7:08     ` Vladimir Sementsov-Ogievskiy
2020-09-24 11:40   ` Stefan Hajnoczi
2020-09-24 17:56   ` Eric Blake
2020-09-24 18:52     ` Vladimir Sementsov-Ogievskiy
2020-09-15 16:44 ` [PATCH v8 5/7] block: generate coroutine-wrapper code Vladimir Sementsov-Ogievskiy
2020-09-24 12:14   ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 6/7] block: drop bdrv_prwv Vladimir Sementsov-Ogievskiy
2020-09-24  8:31   ` Philippe Mathieu-Daudé
2020-09-24 12:15   ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 7/7] block/io: refactor save/load vmstate Vladimir Sementsov-Ogievskiy
2020-09-23 20:10   ` Eric Blake
2020-09-24  7:20     ` Vladimir Sementsov-Ogievskiy
2020-09-24 12:16   ` Stefan Hajnoczi
2020-09-24 12:16 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924121620.GA62770@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=crosa@redhat.com \
    --cc=den@openvz.org \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.