From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396B0C2D0E2 for ; Thu, 24 Sep 2020 13:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7A72238E3 for ; Thu, 24 Sep 2020 13:37:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wR16WBUv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbgIXNhe (ORCPT ); Thu, 24 Sep 2020 09:37:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728000AbgIXNhd (ORCPT ); Thu, 24 Sep 2020 09:37:33 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5016BC0613D3 for ; Thu, 24 Sep 2020 06:37:33 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id e2so3649525wme.1 for ; Thu, 24 Sep 2020 06:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tnbVYVydzTndZjHx54L+pKVp5ROdQOJCG9ZC1h7UrbQ=; b=wR16WBUvPW96FpFtNzjiQzudOIawwDkmbPXXQ2ZfBCOvV+OQ0LL26RP3gMyMs3Ulik rAT4HnKQy0XijG3Ov8PnZ3IzN02enYl40WUrUr7LPjbUu1wcViOPWbIsHZCq6B4mco+l Zqk79ET7GhMre4uK959OlDNxJ31fRHLVICBfdmn9nQT2Ra4UDMhfNdeAI28pV+LJFH8g 6+iADeDCPC55ZtVpJBALUHviKDXjKW93owC3+D32VYsjTdL2ictDyLVs12o+e0pr3mFU 0+LLcBsUQlhVJW5gTocCENwGrZM5hCURgpLMU2Zw06tVErESPgv6t8/qvuyLXhF9Mnnf 6s1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tnbVYVydzTndZjHx54L+pKVp5ROdQOJCG9ZC1h7UrbQ=; b=Rx6tM13GRH8WAI7RZjK5AzSI7cerUOrojeHCnjEkamG1IMqgGO2RSwdCyv5aLVx9J2 vWlfdT8wG3iOpPeglOLpVtL8wJ9Kd9CvjfN/OcPXRFku2Hd91O1cuWqnp9aztfTG0OVC JVP4Su9Q8JkFslig9NE1vOix6wdZWW/y2hkWMhE4PeGwXPin/HSVKbGXJlkKa2pmpbB/ 199fgXetSGIO6jynxNOznrGt/Ad1f/16uN4fOScLrrn7+oPj8EuNsE1VLxloOb1FjOgM S+tP1n6uqMVUd3EPk6mDnP//ePkTUXPdo4XU1+6qYR2Ks4Hx15hb0WFyDZfUMciWz9t3 4LQQ== X-Gm-Message-State: AOAM531JEcVhEywkhKA+Chkxgo83/9h+nLk7n7XG+OFbJd7QZP9VYlo9 hByZwLHnIcWW9mQP3HGOTiOU+Q== X-Google-Smtp-Source: ABdhPJyeiAxCwP3APzpEwu31OqsdL0w0TL03OQ5W9+90C2WYE080DSWXdPSO/EIHJ4vPJaAwLMSNIA== X-Received: by 2002:a1c:19c1:: with SMTP id 184mr5103148wmz.114.1600954651863; Thu, 24 Sep 2020 06:37:31 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id o15sm3423479wmh.29.2020.09.24.06.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 06:37:31 -0700 (PDT) Date: Thu, 24 Sep 2020 14:37:27 +0100 From: Quentin Perret To: Ionela Voinescu Cc: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org, dietmar.eggemann@arm.com, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] condition EAS enablement on FI support Message-ID: <20200924133727.GB3920949@google.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924123937.20938-1-ionela.voinescu@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 24 Sep 2020 at 13:39:34 (+0100), Ionela Voinescu wrote: > Given the maturity gained by cpufreq-based Frequency Invariance (FI) > support following the patches at [1], this series conditions Energy > Aware Scheduling (EAS) enablement on a frequency invariant system. > > Currently, EAS can be enabled on a system without FI support, leading > to incorrect (energy-wise) task placements. As no warning is emitted, > it could take some debugging effort to track the behavior back to the > lack of FI support; this series changes that by disabling EAS > (and advertising it) when FI support is missing. > > The series is structured as follows: > - 1/3 - create function that can rebuild the scheduling and EAS' > performance domains if EAS' initial conditions change > - 2/3 - condition EAS enablement on FI support > - 3/3 - arm64: rebuild scheduling and performance domains in the > case of late, counter-driven FI initialisation. I'm still reading through this, but shouldn't patch 2 and 3 be swapped? Otherwise we have a weird state at patch 2 where EAS will fail to start (IIUC), which might not be ideal for bisection. Thoughts? Cheers, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A69C4363D for ; Thu, 24 Sep 2020 13:38:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C480238E3 for ; Thu, 24 Sep 2020 13:38:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2GzGorfv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="wR16WBUv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C480238E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WUch80OncZyTM0FhWSWMbKdjAT2HhV6q5SPoKe+cvkM=; b=2GzGorfvnI42cju9eu7LJNKeY 6YXAcD9ok3temexAiEi3Bt8PosJAzQUvxZBeyGac/mJhpaHF5Q2K8nWXRkz5GZpczCwget+WneWqW vEGYqfPhxLQnNIDJKDsDn/menWZ4hRJvPbdqBsavHKZfTsLyYt00bzCxqJsA8KeUVFzt8/UAWBwh3 eRCvk2g8kW56pPsevmwZRvWHtNVhdMMyz0BPl7sDePUEJ7r75Vgns0pYERMvyHfJHJHkgxbGYih4S 9kSEC5TijcsFhSli0Zwk0AvmSVbPXD19giUvA+J0xq9pjDtRcIUaOiFbAx79CX++0Jm7IBQ1nU2g4 vDYlFYX4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLRRI-0005j2-0V; Thu, 24 Sep 2020 13:37:36 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLRRE-0005gV-UE for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 13:37:33 +0000 Received: by mail-wm1-x344.google.com with SMTP id e17so3585520wme.0 for ; Thu, 24 Sep 2020 06:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tnbVYVydzTndZjHx54L+pKVp5ROdQOJCG9ZC1h7UrbQ=; b=wR16WBUvPW96FpFtNzjiQzudOIawwDkmbPXXQ2ZfBCOvV+OQ0LL26RP3gMyMs3Ulik rAT4HnKQy0XijG3Ov8PnZ3IzN02enYl40WUrUr7LPjbUu1wcViOPWbIsHZCq6B4mco+l Zqk79ET7GhMre4uK959OlDNxJ31fRHLVICBfdmn9nQT2Ra4UDMhfNdeAI28pV+LJFH8g 6+iADeDCPC55ZtVpJBALUHviKDXjKW93owC3+D32VYsjTdL2ictDyLVs12o+e0pr3mFU 0+LLcBsUQlhVJW5gTocCENwGrZM5hCURgpLMU2Zw06tVErESPgv6t8/qvuyLXhF9Mnnf 6s1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tnbVYVydzTndZjHx54L+pKVp5ROdQOJCG9ZC1h7UrbQ=; b=ng1+aOJHoYrUmGTwjwvdgWJ33z8ze4YXYmWQkzi/QylJxWRTLsPYXNJ+BzFOd2vNKZ 9vswUrsf9wh/An4swEsiaW/ToOqlkaEqz2xLvTlCKIzGfGFy4tQfqe8s6keuqK3VeYr5 wqhZDTXdlaGRyIV23ZzdiSGKuRWEKt63Ux0RDfM5XIYEyAxFdW3PnWn/LnvT7hfm4u0a 7xiJdzWnj4JSUXdYwUl6redG9unCorSXO2QF5/MToQ3DrXKGkzaPTaXMfkXtlp2q4cde J1aHMIo+n4eTpCf5ezZ5RFFansiKgvp2JrJWcL5Y2EiPfFTKLVb4++4PBIXdTHlSDv4J lHXQ== X-Gm-Message-State: AOAM530fcC/buBXKPFRn1kcMVBRCgLlYCaG8tgd2hg6g/qJo8fjNUfdx KS5ZsCV5uQAQdcnwzPWN38c3pA== X-Google-Smtp-Source: ABdhPJyeiAxCwP3APzpEwu31OqsdL0w0TL03OQ5W9+90C2WYE080DSWXdPSO/EIHJ4vPJaAwLMSNIA== X-Received: by 2002:a1c:19c1:: with SMTP id 184mr5103148wmz.114.1600954651863; Thu, 24 Sep 2020 06:37:31 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id o15sm3423479wmh.29.2020.09.24.06.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 06:37:31 -0700 (PDT) Date: Thu, 24 Sep 2020 14:37:27 +0100 From: Quentin Perret To: Ionela Voinescu Subject: Re: [PATCH 0/3] condition EAS enablement on FI support Message-ID: <20200924133727.GB3920949@google.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924123937.20938-1-ionela.voinescu@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_093733_042442_1195AEDB X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, valentin.schneider@arm.com, mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 24 Sep 2020 at 13:39:34 (+0100), Ionela Voinescu wrote: > Given the maturity gained by cpufreq-based Frequency Invariance (FI) > support following the patches at [1], this series conditions Energy > Aware Scheduling (EAS) enablement on a frequency invariant system. > > Currently, EAS can be enabled on a system without FI support, leading > to incorrect (energy-wise) task placements. As no warning is emitted, > it could take some debugging effort to track the behavior back to the > lack of FI support; this series changes that by disabling EAS > (and advertising it) when FI support is missing. > > The series is structured as follows: > - 1/3 - create function that can rebuild the scheduling and EAS' > performance domains if EAS' initial conditions change > - 2/3 - condition EAS enablement on FI support > - 3/3 - arm64: rebuild scheduling and performance domains in the > case of late, counter-driven FI initialisation. I'm still reading through this, but shouldn't patch 2 and 3 be swapped? Otherwise we have a weird state at patch 2 where EAS will fail to start (IIUC), which might not be ideal for bisection. Thoughts? Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel