From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE46C4363D for ; Thu, 24 Sep 2020 21:08:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF1A222208 for ; Thu, 24 Sep 2020 21:08:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LssSV5X+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF1A222208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLYTV-0001ZK-Sk for qemu-devel@archiver.kernel.org; Thu, 24 Sep 2020 17:08:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLYGK-0001vJ-1L for qemu-devel@nongnu.org; Thu, 24 Sep 2020 16:54:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLYGH-0000Nd-Dk for qemu-devel@nongnu.org; Thu, 24 Sep 2020 16:54:43 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600980879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q2wjEJ2KwcznfmnW/clMqdKGZDM3G6j3aUlvpxzufNY=; b=LssSV5X+u5RnmsOXHWOxXf3aVL5t6AjWYEMxARkTtCSXpxcElgxrd7Jvsu55waX9dQ3Qha S0lQzrpxQzgidExuuSwxzP/+TISsGSpB4lIwdpYihWgPmpEDOyMEf4yPM+3VjzHbAg12cH 2TgyZ20hpyjMJotBE89MmbJZYYwZ9YI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-AuiCbiM4M4aZcWuDjxTuAQ-1; Thu, 24 Sep 2020 16:54:37 -0400 X-MC-Unique: AuiCbiM4M4aZcWuDjxTuAQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37690100746C; Thu, 24 Sep 2020 20:54:36 +0000 (UTC) Received: from localhost (unknown [10.10.67.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id C397F5C1C7; Thu, 24 Sep 2020 20:54:35 +0000 (UTC) Date: Thu, 24 Sep 2020 16:54:34 -0400 From: Eduardo Habkost To: John Snow Subject: Re: [PATCH v2 35/38] qapi/types.py: remove one-letter variables Message-ID: <20200924205434.GJ3717385@habkost.net> References: <20200922210101.4081073-1-jsnow@redhat.com> <20200922210101.4081073-36-jsnow@redhat.com> <20200923191436.GX3312949@habkost.net> <8d128d28-1d18-406a-2bf2-5bc64a6b8cff@redhat.com> MIME-Version: 1.0 In-Reply-To: <8d128d28-1d18-406a-2bf2-5bc64a6b8cff@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 01:10:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org, Michael Roth , Markus Armbruster , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 23, 2020 at 06:11:01PM -0400, John Snow wrote: > On 9/23/20 3:14 PM, Eduardo Habkost wrote: > > I'm not sure I like this weird expression, but I believe asking > > for a 120-patch cleanup series to be respun because of a tiny > > style issue would be counterproductive, so: > > > > Reviewed-by: Eduardo Habkost > > I was trying to reduce the indent level to accommodate the longer names, but > python ternaries *are* pretty weird. > > It'd be nice to enforce always having a variants object instead (even if > it's empty!) and then add __bool__ and __iter__ methods to > QAPISchemaVariants such that you could always do: > > "if variants" > > or > > "for variant in variants" > > but we're not there just yet... should I just put it back the way it was, > with the deep nesting? I don't have a strong opinion. I got used to it after seeing the same pattern being used a few times. -- Eduardo