From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ethan Zhao <haifeng.zhao@intel.com>
Cc: bhelgaas@google.com, oohall@gmail.com, ruscur@russell.cc,
lukas@wunner.de, stuart.w.hayes@gmail.com, mr.nuke.me@gmail.com,
mika.westerberg@linux.intel.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, pei.p.jia@intel.com
Subject: Re: [PATCH 3/5] PCI/ERR: get device before call device driver to avoid null pointer reference
Date: Fri, 25 Sep 2020 15:35:15 +0300 [thread overview]
Message-ID: <20200925123515.GF3956970@smile.fi.intel.com> (raw)
In-Reply-To: <20200925023423.42675-4-haifeng.zhao@intel.com>
On Thu, Sep 24, 2020 at 10:34:21PM -0400, Ethan Zhao wrote:
> During DPC error injection test we found there is race condition between
> pciehp and DPC driver, null pointer reference caused panic as following
null -> NULL
>
> # setpci -s 64:02.0 0x196.w=000a
> // 64:02.0 is rootport has DPC capability
> # setpci -s 65:00.0 0x04.w=0544
> // 65:00.0 is NVMe SSD populated in above port
> # mount /dev/nvme0n1p1 nvme
>
> (tested on stable 5.8 & ICX platform)
>
> Buffer I/O error on dev nvme0n1p1, logical block 468843328,
> async page read
> BUG: kernel NULL pointer dereference, address: 0000000000000050
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
Same comment about Oops.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-25 16:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 2:34 [PATCH 0/5] Fix DPC hotplug race and enhance error hanlding Ethan Zhao
2020-09-25 2:34 ` [PATCH 4/5] PCI: only return true when dev io state is really changed Ethan Zhao
2020-09-25 12:38 ` Andy Shevchenko
2020-09-27 1:28 ` Zhao, Haifeng
2020-09-25 13:56 ` Alex G.
2020-09-25 2:34 ` [PATCH 5/5] PCI/ERR: don't mix io state not changed and no driver together Ethan Zhao
[not found] ` <20200925023423.42675-2-haifeng.zhao@intel.com>
2020-09-25 12:24 ` [PATCH 1/5] PCI: define a function to check and wait till port finish DPC handling Andy Shevchenko
2020-09-27 1:53 ` Zhao, Haifeng
[not found] ` <20200925023423.42675-3-haifeng.zhao@intel.com>
2020-09-25 12:32 ` [PATCH 2/5] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC Andy Shevchenko
2020-09-27 1:50 ` Zhao, Haifeng
[not found] ` <20200925023423.42675-4-haifeng.zhao@intel.com>
2020-09-25 12:35 ` Andy Shevchenko [this message]
2020-09-29 2:35 ` [PATCH 3/5] PCI/ERR: get device before call device driver to avoid null pointer reference Ethan Zhao
2020-09-29 8:51 ` Andy Shevchenko
2020-09-29 9:38 ` Ethan Zhao
2020-09-29 10:48 ` Andy Shevchenko
2020-09-30 2:07 ` Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925123515.GF3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=haifeng.zhao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=oohall@gmail.com \
--cc=pei.p.jia@intel.com \
--cc=ruscur@russell.cc \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.