From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F77C4727D for ; Fri, 25 Sep 2020 12:50:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D5B2221EC for ; Fri, 25 Sep 2020 12:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601038207; bh=NhpIewdbB6dTcGTnzngNuWEry/2rpOB3dqNt5H+a6ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0bNlKQECg9zopDuOEdgUkUbdOhOH7d7UugqQboZ8W/csQw0+gfUsIQB8xLxtnDPM9 t2/lqqsIiUjuj0zzlqGO1zbFvDVlPJXqrrhjmXE2jEa+8lZip4XfRx3ibLCkdyYX71 ciZeGlPOpYiUJME0yt0YWhNb6tKqGtEfKUQ0YsgU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729015AbgIYMuG (ORCPT ); Fri, 25 Sep 2020 08:50:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:53920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729008AbgIYMuE (ORCPT ); Fri, 25 Sep 2020 08:50:04 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D000322B2D; Fri, 25 Sep 2020 12:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601038204; bh=NhpIewdbB6dTcGTnzngNuWEry/2rpOB3dqNt5H+a6ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wXB/Ld++FPdSs1gSb0SVZcnI5uHkLwvNYcyVtu2JlY5aVFiThKDalxCSWNkTL7FjT ypSFHDRjnZwfmyewY115L+ZE+09cZqGoIxcRuQq3RdYsZFYAjMwWPOlmSnX68h5JUu V8FT4kPlPhaYJx0YXGZMAt7FE3UcAMDrzMmzDNsI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 5.8 02/56] ibmvnic: add missing parenthesis in do_reset() Date: Fri, 25 Sep 2020 14:47:52 +0200 Message-Id: <20200925124728.188605829@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200925124727.878494124@linuxfoundation.org> References: <20200925124727.878494124@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski [ Upstream commit 8ae4dff882eb879c17bf46574201bd37fc6bc8b5 ] Indentation and logic clearly show that this code is missing parenthesis. Fixes: 9f1345737790 ("ibmvnic fix NULL tx_pools and rx_tools issue at do_reset") Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmvnic.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index d3a774331afc7..1b702a43a5d01 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -2032,16 +2032,18 @@ static int do_reset(struct ibmvnic_adapter *adapter, } else { rc = reset_tx_pools(adapter); - if (rc) + if (rc) { netdev_dbg(adapter->netdev, "reset tx pools failed (%d)\n", rc); goto out; + } rc = reset_rx_pools(adapter); - if (rc) + if (rc) { netdev_dbg(adapter->netdev, "reset rx pools failed (%d)\n", rc); goto out; + } } ibmvnic_disable_irqs(adapter); } -- 2.25.1