From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD18C4727D for ; Fri, 25 Sep 2020 13:59:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E775B23600 for ; Fri, 25 Sep 2020 13:59:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="u8161EQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbgIYN7G (ORCPT ); Fri, 25 Sep 2020 09:59:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728451AbgIYN7G (ORCPT ); Fri, 25 Sep 2020 09:59:06 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC4EDC0613CE for ; Fri, 25 Sep 2020 06:59:05 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id t10so3763393wrv.1 for ; Fri, 25 Sep 2020 06:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mlSpbnI9f91cxfpqsFRezlZGD6ngDghBIQQyjrFOHMY=; b=u8161EQlqviptebdc4sX9yDB4kT7ymxUhWkQcFpEHwyZT6vrFqFy8yaU3NouV/ZI6u kwGEMGNAtiOeIrIUjRzcZgYv0SV9wqorMIDtTbmQ+Ur7A0Uv5KbrTVSZa07Of4UQagqF bT337pyYRI1ftEOCTLXLh/Lf1l0cIZFj09KTdTZ+5/3/fSptrdnIjNYweW1q8eOrnXM7 sSHa4seYHBxhWKmV1i/U35X9dvHuC5k+Wpu50EI/ii3W/yjC0dbAsMINsgSlcGGfPRXx IUMktXSjeQqM5ly8OPPSW4RonTJO1/1+JoBsyLhhUmEjo8Y+USZqMojlVxrhqksWuE/m OCwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mlSpbnI9f91cxfpqsFRezlZGD6ngDghBIQQyjrFOHMY=; b=jWS1nLDffg8aTB2/LCdPFILA9Q8VSDZSS7XuTnVVTXTiBGn6vozaYiDtf/+I2jILu6 TYXsSBsXZAcjru/kBWuy2+YRslDR4fbWYvAmqO4raxXlRChGv3CFHnrUSPSWv80zI5BL 0HeHw0ozptai8KwbStYXN8uUrqZLYOnx0XjHiiCNzVLObtGORMxKn93pYW59l6Oy4mzS Iv1NYP5ElFU3UfMzsYOJJTpN7RkaW79Bs2YLSire7qbn132t07RA5AFXhpS4QUYr2eTb ym3GoboRn1UvJNuLCEZExaSlZIvnHykp835lmhAwOPT+Da60PowTD28Jtynys+VjGIjw 8HaA== X-Gm-Message-State: AOAM531z3uZnFpRdg0sUmL4e43G316BfgPCgZ/MK82GPBZhyAoltHqDF bxMOuY4QWnc1JbYthBn7wt7ipw== X-Google-Smtp-Source: ABdhPJxvBeHm57r2mwHF+roTeEhAmVxM0FLvzB7cxk76/KSuX+nlkd4qDCNU59NYYoehXW+VVIiCvg== X-Received: by 2002:adf:e74d:: with SMTP id c13mr4514766wrn.45.1601042344244; Fri, 25 Sep 2020 06:59:04 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id k4sm2918748wrx.51.2020.09.25.06.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 06:59:03 -0700 (PDT) Date: Fri, 25 Sep 2020 14:59:00 +0100 From: Quentin Perret To: Ionela Voinescu Cc: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org, dietmar.eggemann@arm.com, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes Message-ID: <20200925135900.GA11648@google.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-4-ionela.voinescu@arm.com> <20200924133925.GC3920949@google.com> <20200924161002.GC17927@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924161002.GC17927@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Ionela, On Thursday 24 Sep 2020 at 17:10:02 (+0100), Ionela Voinescu wrote: > I'm not sure what is a good way of fixing this.. I could add more info > to the warning to suggest it might be temporary ("Disabling EAS: > frequency-invariant load tracking currently not supported"). For further > debugging there are the additional prints guarded by sched_debug(). > > I'll look over the code some more to see if other ideas pop out. Any > suggestions are appreciated. Right, I'm not seeing anything perfect here, but I think I'd be personally happy with this message being entirely guarded by sched_debug(), like we do for asym CPU capacities for instance. It's not easy to see if EAS has started at all w/o sched debug anyway, so I expect folks who need it to enable the debug stuff during bring-up. With a descriptive enough warn message, that should be just fine. But that's my 2p, so I'm happy to hear if others disagree. Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D72C4363D for ; Fri, 25 Sep 2020 14:00:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 720972086A for ; Fri, 25 Sep 2020 14:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lh34h+er"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="u8161EQl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 720972086A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HO8a6GV70JAkMnIGLZQlkA3dVwmfkIX6QrD7xm001gA=; b=Lh34h+erUFsbz/4zp2J1ucc5e ZNQtFKYtVIuIPSvoj3VwEk6zQcKhxX6Ec+R0J63nNqmRIzAOiA2eizKHz0Qh3SJLrmYSqwXgXAJUA +VwsEGO1PtICmTNOH9QlcuzEB9K4d6WbYd9YpxZy7/j/9yISaYj6c4T92gYFG2E08SJddtfNS9NIc Uq8arv+KlDs8YuqYPnM6D45FeQHieIsTACI0xOapRFOw0u4hwQjoNI81/n2rNJy7YaYoMEGOWanCV 4aD2S7zaWl3Q0xQm3V6L0O9CfvbVsXpkyJ8t2AHj4Kq79doxF9WTB5WTw6K/MhknKVeGmu94WLf+m nH7Y4Libw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLoFi-0002EU-1p; Fri, 25 Sep 2020 13:59:10 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLoFf-0002DL-IW for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 13:59:08 +0000 Received: by mail-wr1-x441.google.com with SMTP id m6so3768258wrn.0 for ; Fri, 25 Sep 2020 06:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mlSpbnI9f91cxfpqsFRezlZGD6ngDghBIQQyjrFOHMY=; b=u8161EQlqviptebdc4sX9yDB4kT7ymxUhWkQcFpEHwyZT6vrFqFy8yaU3NouV/ZI6u kwGEMGNAtiOeIrIUjRzcZgYv0SV9wqorMIDtTbmQ+Ur7A0Uv5KbrTVSZa07Of4UQagqF bT337pyYRI1ftEOCTLXLh/Lf1l0cIZFj09KTdTZ+5/3/fSptrdnIjNYweW1q8eOrnXM7 sSHa4seYHBxhWKmV1i/U35X9dvHuC5k+Wpu50EI/ii3W/yjC0dbAsMINsgSlcGGfPRXx IUMktXSjeQqM5ly8OPPSW4RonTJO1/1+JoBsyLhhUmEjo8Y+USZqMojlVxrhqksWuE/m OCwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mlSpbnI9f91cxfpqsFRezlZGD6ngDghBIQQyjrFOHMY=; b=l2wv+HTsu0seqN/Ma3rY3k+hSVv15pUctDMvBoWeElSYBmjWf4c72a3RRw2C0mAIEy 5UpX+ErB0Z/K4OuywZ/+m4SPChGzDFDAvxyC97g2GKBWvMcBJsIcgaZ00Fg/SGJQ0zun 9cyOL8hrAUWGY+1BbJiYBXW7lB3Vg+lJv3lPxbKJ/lYP83JR6YE+GcT/dVOyKiOM+3Zb TOfAUCGyvZNhLk2FOVte69oVNQ02pVMsVZN56vJgv7PmZi7HImCwJWr96Ua1f3vapEIu F1H73UgTBp2mFB+fEqRFLIKMqW7uOd+nfknoFpsv34HzwPonfD2wZRA8he1gWF7auZKL T+ew== X-Gm-Message-State: AOAM530XnhWkSH775ug9HFa4S8fR+OoXa0kluzGk4B5NxRhPWNCOxlbM d9qP/COFm+QIbpnjf5oHBDR7Ew== X-Google-Smtp-Source: ABdhPJxvBeHm57r2mwHF+roTeEhAmVxM0FLvzB7cxk76/KSuX+nlkd4qDCNU59NYYoehXW+VVIiCvg== X-Received: by 2002:adf:e74d:: with SMTP id c13mr4514766wrn.45.1601042344244; Fri, 25 Sep 2020 06:59:04 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id k4sm2918748wrx.51.2020.09.25.06.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 06:59:03 -0700 (PDT) Date: Fri, 25 Sep 2020 14:59:00 +0100 From: Quentin Perret To: Ionela Voinescu Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes Message-ID: <20200925135900.GA11648@google.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-4-ionela.voinescu@arm.com> <20200924133925.GC3920949@google.com> <20200924161002.GC17927@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924161002.GC17927@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_095907_708592_12A408E1 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, valentin.schneider@arm.com, mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Ionela, On Thursday 24 Sep 2020 at 17:10:02 (+0100), Ionela Voinescu wrote: > I'm not sure what is a good way of fixing this.. I could add more info > to the warning to suggest it might be temporary ("Disabling EAS: > frequency-invariant load tracking currently not supported"). For further > debugging there are the additional prints guarded by sched_debug(). > > I'll look over the code some more to see if other ideas pop out. Any > suggestions are appreciated. Right, I'm not seeing anything perfect here, but I think I'd be personally happy with this message being entirely guarded by sched_debug(), like we do for asym CPU capacities for instance. It's not easy to see if EAS has started at all w/o sched debug anyway, so I expect folks who need it to enable the debug stuff during bring-up. With a descriptive enough warn message, that should be just fine. But that's my 2p, so I'm happy to hear if others disagree. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel