From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35805C4363D for ; Fri, 25 Sep 2020 12:56:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF935206DB for ; Fri, 25 Sep 2020 12:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729616AbgIYM4R (ORCPT ); Fri, 25 Sep 2020 08:56:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:50524 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728968AbgIYM4P (ORCPT ); Fri, 25 Sep 2020 08:56:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0AB59AB9F; Fri, 25 Sep 2020 12:56:13 +0000 (UTC) Date: Fri, 25 Sep 2020 14:56:08 +0200 From: Petr Tesarik To: Heiner Kallweit Cc: Realtek linux nic maintainers , netdev@vger.kernel.org Subject: Re: RTL8402 stops working after hibernate/resume Message-ID: <20200925145608.66a89e73@ezekiel.suse.cz> In-Reply-To: <20200925115241.3709caf6@ezekiel.suse.cz> References: <20200715102820.7207f2f8@ezekiel.suse.cz> <20200716105835.32852035@ezekiel.suse.cz> <20200903104122.1e90e03c@ezekiel.suse.cz> <7e6bbb75-d8db-280d-ac5b-86013af39071@gmail.com> <20200924211444.3ba3874b@ezekiel.suse.cz> <20200925093037.0fac65b7@ezekiel.suse.cz> <20200925105455.50d4d1cc@ezekiel.suse.cz> <20200925115241.3709caf6@ezekiel.suse.cz> Organization: SUSE Linux, s.r.o. X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/b8LGBPor=EJGIBwVHH63w9T"; protocol="application/pgp-signature"; micalg=pgp-sha256 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --Sig_/b8LGBPor=EJGIBwVHH63w9T Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 25 Sep 2020 11:52:41 +0200 Petr Tesarik wrote: > On Fri, 25 Sep 2020 11:44:09 +0200 > Heiner Kallweit wrote: >=20 > > On 25.09.2020 10:54, Petr Tesarik wrote: =20 >[...] > > > Does it make sense to bisect the change that broke the driver for me,= or should I rather dispose of this waste^Wlaptop in an environmentally fri= endly manner? I mean, would you eventually accept a workaround for a few ma= chines with a broken BIOS? > > > =20 > > If the workaround is small and there's little chance to break other stu= ff: then usually yes. > > If you can spend the effort to bisect the issue, this would be apprecia= ted. =20 >=20 > OK, then I'm going to give it a try. Done. The system freezes when this commit is applied: commit 9f0b54cd167219266bd3864570ae8f4987b57520 Author: Heiner Kallweit Date: Wed Jun 17 22:55:40 2020 +0200 r8169: move switching optional clock on/off to pll power functions =20 Relevant chip clocks are disabled in rtl_pll_power_down(), therefore move calling clk_disable_unprepare() there. Similar for enabling the clock. =20 Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller I cannot be sure this is related to the malfunction after resume reported e= arlier, but it again touches the suspend/resume path... Anything else I should try? Petr T --Sig_/b8LGBPor=EJGIBwVHH63w9T Content-Type: application/pgp-signature Content-Description: Digitální podpis OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEHl2YIZkIo5VO2MxYqlA7ya4PR6cFAl9t6OgACgkQqlA7ya4P R6f6Jwf+OYYjG9d0GqcIPETy5IMvFCl47Tnl61MWxOR58sGTaPo6RRZuisVR/bDQ NwmDp86CQsFATRftz+BWyxjU751zlpW7EIGvFWAGQ5hi/pbF3Pac+FRH87T3fMJC /0g1Cznz6E/c9zlt98MYyVjmyrEAwWvdAddWNdtYFaGt0gWSwFWitCN7Bhc5DTlw tmaPJ6TjFKs8FhVKZXAurVy0MjWRn2T5ER9VeaCA163DlJyIm3hxDYynaIuSaLqP pXYNrXjxvhJmej9jCnaiR0NRje9nd1XhOEelM0PX+1adZG/SQMKqJ+E1KlMx4Opp 3l1DBFb4/cRRtIVSmDJUiXAvu6y0OQ== =gefK -----END PGP SIGNATURE----- --Sig_/b8LGBPor=EJGIBwVHH63w9T--