From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B15C4363D for ; Fri, 25 Sep 2020 18:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6575208B6 for ; Fri, 25 Sep 2020 18:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kxLgHHO6"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Gv8p+qRn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729749AbgIYSRb (ORCPT ); Fri, 25 Sep 2020 14:17:31 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:57782 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728353AbgIYSRb (ORCPT ); Fri, 25 Sep 2020 14:17:31 -0400 Date: Fri, 25 Sep 2020 20:17:27 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1601057849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ApJSn3nP5f5v5qpiq3riDa73pSf6mSl6sm6etN1AWSw=; b=kxLgHHO66Whjcurm2es2JMse9P5SXbGIcnL/VNvhag/yMkT3Wh7nFbp9H5oJuLt++j3r9q LuhXzKx8gHksAdDEDUrPmdGeunY3LjjLFp/kUuvRh//FtrDQPmB8iO3pUQS7l1w3RAp+A6 dvBjGltxoV4YZkbFjtJkuSvIvQVeiklO+FY3pc+zrJl2ub/zyTLqa+wyLQGGC54un9wN14 cpzyB77re9dPjKy2FMlpAuZgQFAtsas7JcnsWKtaobraZW+SNP0vKsE/Oq5N/SQ7fkrho8 4YlAN+FJV3IInWfhiEFExt+oav2qE6ChBCKVHWpjJqU256AeBuqjpc+iQpgW1A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1601057849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ApJSn3nP5f5v5qpiq3riDa73pSf6mSl6sm6etN1AWSw=; b=Gv8p+qRnpkPzvejwydj8EPN+XSrKn4v5/t3o6oIczrR9s3yAxYw+5Ut8Vkr7LBM6eGt56U hVFmVGZoD+sTlwBg== From: Sebastian Andrzej Siewior To: Peter Zijlstra Cc: tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, qais.yousef@arm.com, swood@redhat.com, valentin.schneider@arm.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vincent.donnefort@arm.com Subject: Re: [PATCH 0/9] sched: Migrate disable support Message-ID: <20200925181727.ryuacrsipyaz65z7@linutronix.de> References: <20200921163557.234036895@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200921163557.234036895@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-21 18:35:57 [+0200], Peter Zijlstra wrote: > Hi, Hi, > Here's my take on migrate_disable(). It avoids growing a second means of I have here: |005: numa_remove_cpu cpu 5 node 0: mask now 0,3-4,6-7 |007: smpboot: CPU 5 is now offline |006: ------------[ cut here ]------------ |006: rq->balance_callback |006: WARNING: CPU: 6 PID: 8392 at kernel/sched/sched.h:1234 try_to_wake_up+0x696/0x860 |006: Modules linked in: |006: |006: CPU: 6 PID: 8392 Comm: hackbench Not tainted 5.9.0-rc6-rt9+ #60 |006: Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-1 04/01/2014 |006: RIP: 0010:try_to_wake_up+0x696/0x860 |006: Code: c0 01 00 00 01 e9 d9 fb ff ff 80 3d 90 ef 6d 01 00 0f 85 6c fb ff ff 48 c7 c7 d4 4a 2c 82 c6 05 7c ef 6d 01 01 e8 dd 21 fc ff <0f> 0b e9 52 fb ff ff 0f 0b e9 b2 |006: RSP: 0018:ffffc90005b978f8 EFLAGS: 00010082 |006: |006: RAX: 0000000000000000 RBX: ffff8882755cca40 RCX: 0000000000000000 |006: RDX: ffffffff8247aab8 RSI: 00000000ffffffff RDI: 00000000ffffffff |006: RBP: 0000000000000000 R08: 0000000000000001 R09: ffffffff8247a9a0 |006: R10: ffffc90005b97838 R11: 332e39313320205b R12: ffff888276da8600 |006: R13: 0000000000000093 R14: ffff8882755cd7a0 R15: ffff888276da8618 |006: FS: 00007f6fa7805740(0000) GS:ffff888276d80000(0000) knlGS:0000000000000000 |006: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 |006: CR2: 00007f6fa796af90 CR3: 0000000262588000 CR4: 00000000003506e0 |006: Call Trace: |006: ? cpu_stop_queue_work+0x8e/0x150 |006: __wake_up_q+0x96/0xc0 |006: cpu_stop_queue_work+0x9a/0x150 |006: finish_task_switch.isra.0+0x2f1/0x460 |006: __schedule+0x3bd/0xb20 |006: schedule+0x4a/0x100 |006: schedule_hrtimeout_range_clock+0x14f/0x160 |006: ? rt_spin_unlock+0x39/0x90 |006: ? rt_mutex_futex_unlock+0xcb/0xe0 |006: poll_schedule_timeout.constprop.0+0x4d/0x90 |006: do_sys_poll+0x314/0x430 |006: ? __lock_acquire+0x39b/0x2010 |006: ? poll_schedule_timeout.constprop.0+0x90/0x90 |006: ? mark_held_locks+0x49/0x70 |006: ? find_held_lock+0x2b/0x80 |006: ? rt_spin_unlock+0x39/0x90 |006: ? rt_mutex_futex_unlock+0xcb/0xe0 |006: ? rt_spin_unlock+0x51/0x90 |006: ? handle_mm_fault+0xfbd/0x1510 |006: ? find_held_lock+0x2b/0x80 |006: ? do_user_addr_fault+0x214/0x420 |006: __x64_sys_poll+0x37/0x130 |006: do_syscall_64+0x33/0x40 |006: entry_SYSCALL_64_after_hwframe+0x44/0xa9 |006: RIP: 0033:0x7f6fa78fb483 Is this somewhere among the fixes Valentin received? This SCHED_WARN_ON(rq->balance_callback); in rq_pin_lock(). Sebastian