From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00762C4727E for ; Fri, 25 Sep 2020 19:04:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7825A21D42 for ; Fri, 25 Sep 2020 19:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="vn5FNzXT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7825A21D42 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9DC9B6B005C; Fri, 25 Sep 2020 15:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93BCF8E0003; Fri, 25 Sep 2020 15:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B55E8E0001; Fri, 25 Sep 2020 15:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 58FE36B005C for ; Fri, 25 Sep 2020 15:04:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1F8F1180AD804 for ; Fri, 25 Sep 2020 19:04:53 +0000 (UTC) X-FDA: 77302510866.21.door75_330f5552716a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id E98DC180442C3 for ; Fri, 25 Sep 2020 19:04:52 +0000 (UTC) X-HE-Tag: door75_330f5552716a X-Filterd-Recvd-Size: 5288 Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com [207.171.184.29]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 19:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1601060692; x=1632596692; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DEwVMNNAxG5t04sf/ERocCPHsXOzC3I1duBnCyy9B6A=; b=vn5FNzXT09F3vQscqPFKPQClbZ44DJdsXV/Vi8ft9nEKuDn4JW9Y3A8X aTtw811SGpz4Rb02QBpvZAUW5MFRJHzNfbfvh3zQMVHvDSy/Zcxqw1pcP xM0IQFo3UTnc9sbtSiw5AwhCW6CvMcTL9zaNIX9TL/lgUDPSJwWl603uT 4=; X-IronPort-AV: E=Sophos;i="5.77,303,1596499200"; d="scan'208";a="79358644" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-e7be2041.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 25 Sep 2020 19:04:41 +0000 Received: from EX13MTAUEE002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2a-e7be2041.us-west-2.amazon.com (Postfix) with ESMTPS id 115A4A1C3F; Fri, 25 Sep 2020 19:04:40 +0000 (UTC) Received: from EX13D08UEE003.ant.amazon.com (10.43.62.118) by EX13MTAUEE002.ant.amazon.com (10.43.62.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 19:04:24 +0000 Received: from EX13MTAUEE002.ant.amazon.com (10.43.62.24) by EX13D08UEE003.ant.amazon.com (10.43.62.118) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 19:04:24 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.62.224) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 25 Sep 2020 19:04:24 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id 05B2640150; Fri, 25 Sep 2020 19:04:24 +0000 (UTC) Date: Fri, 25 Sep 2020 19:04:23 +0000 From: Anchal Agarwal To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode Message-ID: <20200925190423.GA31885@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <9b970e12491107afda0c1d4a6f154b52d90346ac.1598042152.git.anchalag@amazon.com> <4b2bbc8b-7817-271a-4ff0-5ee5df956049@oracle.com> <20200914214754.GA19975@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200915180055.GB19975@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <5f1e4772-7bd9-e6c0-3fe6-eef98bb72bd8@oracle.com> <20200921215447.GA28503@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200922231736.GA24215@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200922231736.GA24215@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 22, 2020 at 11:17:36PM +0000, Anchal Agarwal wrote: > On Tue, Sep 22, 2020 at 12:18:05PM -0400, boris.ostrovsky@oracle.com wrote: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > On 9/21/20 5:54 PM, Anchal Agarwal wrote: > > > Thanks for the above suggestion. You are right I didn't find a way to declare > > > a global state either. I just broke the above check in 2 so that once we have > > > support for ARM we should be able to remove aarch64 condition easily. Let me > > > know if I am missing nay corner cases with this one. > > > > > > static int xen_pm_notifier(struct notifier_block *notifier, > > > unsigned long pm_event, void *unused) > > > { > > > int ret = NOTIFY_OK; > > > if (!xen_hvm_domain() || xen_initial_domain()) > > > ret = NOTIFY_BAD; > > > if(IS_ENABLED(CONFIG_ARM64) && (pm_event == PM_SUSPEND_PREPARE || pm_event == HIBERNATION_PREPARE)) > > > ret = NOTIFY_BAD; > > > > > > return ret; > > > } > > > > > > > > This will allow PM suspend to proceed on x86. > Right!! Missed it. > Also, wrt KASLR stuff, that issue is still seen sometimes but I haven't had > bandwidth to dive deep into the issue and fix it. I seem to have lost your email > in my inbox hence covering the question here. > > > > Can I add your Reviewed-by or Signed-off-by to it? > > -boris > > > -Anchal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3444C4727E for ; Fri, 25 Sep 2020 19:05:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F71B21741 for ; Fri, 25 Sep 2020 19:05:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="vn5FNzXT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F71B21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kLt1b-00057f-7H; Fri, 25 Sep 2020 19:04:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kLt1Z-00057a-Ks for xen-devel@lists.xenproject.org; Fri, 25 Sep 2020 19:04:53 +0000 X-Inumbo-ID: 0630a9e8-993a-475c-b839-f0cdab34b360 Received: from smtp-fw-9102.amazon.com (unknown [207.171.184.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0630a9e8-993a-475c-b839-f0cdab34b360; Fri, 25 Sep 2020 19:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1601060692; x=1632596692; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DEwVMNNAxG5t04sf/ERocCPHsXOzC3I1duBnCyy9B6A=; b=vn5FNzXT09F3vQscqPFKPQClbZ44DJdsXV/Vi8ft9nEKuDn4JW9Y3A8X aTtw811SGpz4Rb02QBpvZAUW5MFRJHzNfbfvh3zQMVHvDSy/Zcxqw1pcP xM0IQFo3UTnc9sbtSiw5AwhCW6CvMcTL9zaNIX9TL/lgUDPSJwWl603uT 4=; X-IronPort-AV: E=Sophos;i="5.77,303,1596499200"; d="scan'208";a="79358644" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-e7be2041.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 25 Sep 2020 19:04:41 +0000 Received: from EX13MTAUEE002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2a-e7be2041.us-west-2.amazon.com (Postfix) with ESMTPS id 115A4A1C3F; Fri, 25 Sep 2020 19:04:40 +0000 (UTC) Received: from EX13D08UEE003.ant.amazon.com (10.43.62.118) by EX13MTAUEE002.ant.amazon.com (10.43.62.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 19:04:24 +0000 Received: from EX13MTAUEE002.ant.amazon.com (10.43.62.24) by EX13D08UEE003.ant.amazon.com (10.43.62.118) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Sep 2020 19:04:24 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.62.224) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 25 Sep 2020 19:04:24 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id 05B2640150; Fri, 25 Sep 2020 19:04:24 +0000 (UTC) Date: Fri, 25 Sep 2020 19:04:23 +0000 From: Anchal Agarwal To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 01/11] xen/manage: keep track of the on-going suspend mode Message-ID: <20200925190423.GA31885@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <9b970e12491107afda0c1d4a6f154b52d90346ac.1598042152.git.anchalag@amazon.com> <4b2bbc8b-7817-271a-4ff0-5ee5df956049@oracle.com> <20200914214754.GA19975@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200915180055.GB19975@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <5f1e4772-7bd9-e6c0-3fe6-eef98bb72bd8@oracle.com> <20200921215447.GA28503@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <20200922231736.GA24215@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200922231736.GA24215@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: Bulk X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Tue, Sep 22, 2020 at 11:17:36PM +0000, Anchal Agarwal wrote: > On Tue, Sep 22, 2020 at 12:18:05PM -0400, boris.ostrovsky@oracle.com wrote: > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > On 9/21/20 5:54 PM, Anchal Agarwal wrote: > > > Thanks for the above suggestion. You are right I didn't find a way to declare > > > a global state either. I just broke the above check in 2 so that once we have > > > support for ARM we should be able to remove aarch64 condition easily. Let me > > > know if I am missing nay corner cases with this one. > > > > > > static int xen_pm_notifier(struct notifier_block *notifier, > > > unsigned long pm_event, void *unused) > > > { > > > int ret = NOTIFY_OK; > > > if (!xen_hvm_domain() || xen_initial_domain()) > > > ret = NOTIFY_BAD; > > > if(IS_ENABLED(CONFIG_ARM64) && (pm_event == PM_SUSPEND_PREPARE || pm_event == HIBERNATION_PREPARE)) > > > ret = NOTIFY_BAD; > > > > > > return ret; > > > } > > > > > > > > This will allow PM suspend to proceed on x86. > Right!! Missed it. > Also, wrt KASLR stuff, that issue is still seen sometimes but I haven't had > bandwidth to dive deep into the issue and fix it. I seem to have lost your email > in my inbox hence covering the question here. > > > > Can I add your Reviewed-by or Signed-off-by to it? > > -boris > > > -Anchal